From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 6/7] ARM: tegra: enable Tegra RTC for Venice2
Date: Wed, 09 Oct 2013 17:27:49 -0600 [thread overview]
Message-ID: <5255E675.5040706@wwwdotorg.org> (raw)
In-Reply-To: <1381310411-11391-7-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 10/09/2013 03:20 AM, Joseph Lo wrote:
> Enable the Tegra RTC device on Venice2. It also can be used as a wakeup
> device when platform suspended.
> diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
> + rtc@7000e000 {
> + status = "okay";
> + };
Does that mean this node has status = "disabled" in tegra124.dtsi? It
shouldn't have, since the RTC doesn't depend on any board-specific HW,
and hence can be enabled by default. We certainly have it enabled by
default on all previous SoCs.
I assume this was caused by one of the commits of yours I already
applied? Let's have a fixup patch to tegra124.dtsi.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] ARM: tegra: enable Tegra RTC for Venice2
Date: Wed, 09 Oct 2013 17:27:49 -0600 [thread overview]
Message-ID: <5255E675.5040706@wwwdotorg.org> (raw)
In-Reply-To: <1381310411-11391-7-git-send-email-josephl@nvidia.com>
On 10/09/2013 03:20 AM, Joseph Lo wrote:
> Enable the Tegra RTC device on Venice2. It also can be used as a wakeup
> device when platform suspended.
> diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
> + rtc at 7000e000 {
> + status = "okay";
> + };
Does that mean this node has status = "disabled" in tegra124.dtsi? It
shouldn't have, since the RTC doesn't depend on any board-specific HW,
and hence can be enabled by default. We certainly have it enabled by
default on all previous SoCs.
I assume this was caused by one of the commits of yours I already
applied? Let's have a fixup patch to tegra124.dtsi.
next prev parent reply other threads:[~2013-10-09 23:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 9:20 [PATCH 0/7] ARM: tegra: support LP1 suspend mode for Tegra124 Joseph Lo
2013-10-09 9:20 ` Joseph Lo
[not found] ` <1381310411-11391-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-09 9:20 ` [PATCH 1/7] clk: tegra124: add suspend/resume function for tegra_cpu_car_ops Joseph Lo
2013-10-09 9:20 ` Joseph Lo
[not found] ` <1381310411-11391-2-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-09 9:26 ` Joseph Lo
2013-10-09 9:26 ` Joseph Lo
2013-10-09 23:12 ` Stephen Warren
2013-10-09 23:12 ` Stephen Warren
2013-10-09 9:20 ` [PATCH 2/7] ARM: tegra: add flow controller to support suspend for Tegra124 Joseph Lo
2013-10-09 9:20 ` Joseph Lo
[not found] ` <1381310411-11391-3-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-09 23:21 ` Stephen Warren
2013-10-09 23:21 ` Stephen Warren
2013-10-09 9:20 ` [PATCH 3/7] ARM: tegra: hook tegra_cpu_tear_down " Joseph Lo
2013-10-09 9:20 ` Joseph Lo
2013-10-09 9:20 ` [PATCH 4/7] ARM: tegra: add LP1 support code " Joseph Lo
2013-10-09 9:20 ` Joseph Lo
[not found] ` <1381310411-11391-5-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-09 23:20 ` Stephen Warren
2013-10-09 23:20 ` Stephen Warren
[not found] ` <5255E4CD.1050509-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-11 7:38 ` Joseph Lo
2013-10-11 7:38 ` Joseph Lo
[not found] ` <1381477089.5685.3.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2013-10-11 15:40 ` Stephen Warren
2013-10-11 15:40 ` Stephen Warren
2013-10-09 9:20 ` [PATCH 5/7] ARM: tegra: hook the LP1 iram code area and sleep_core function " Joseph Lo
2013-10-09 9:20 ` Joseph Lo
[not found] ` <1381310411-11391-6-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-09 23:25 ` Stephen Warren
2013-10-09 23:25 ` Stephen Warren
2013-10-09 9:20 ` [PATCH 6/7] ARM: tegra: enable Tegra RTC for Venice2 Joseph Lo
2013-10-09 9:20 ` Joseph Lo
[not found] ` <1381310411-11391-7-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-09 23:27 ` Stephen Warren [this message]
2013-10-09 23:27 ` Stephen Warren
2013-10-09 9:20 ` [PATCH 7/7] ARM: tegra: enable LP1 suspend mode " Joseph Lo
2013-10-09 9:20 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5255E675.5040706@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.