From: Li Zefan <lizefan@huawei.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Christoph Lameter <cl@linux.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] slub: Fix calculation of cpu slabs
Date: Mon, 14 Oct 2013 15:27:40 +0800 [thread overview]
Message-ID: <525B9CEC.5000903@huawei.com> (raw)
In-Reply-To: <0000014109b29246-61170b4a-7ab7-41f0-a887-a1cd62603196-000000@email.amazonses.com>
Hi Pekka,
could you pick up this patch?
On 2013/9/11 5:06, Christoph Lameter wrote:
> On Tue, 10 Sep 2013, Li Zefan wrote:
>
>> We should use page->pages instead of page->pobjects when calculating
>> the number of cpu partial slabs. This also fixes the mapping of slabs
>> and nodes.
>
> True.
>
>> As there's no variable storing the number of total/active objects in
>> cpu partial slabs, and we don't have user interfaces requiring those
>> statistics, I just add WARN_ON for those cases.
>
>
> Well that is not strictly required but it does not hurt either.
>
> Acked-by: Christoph Lameter <cl@linux.com>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Christoph Lameter <cl@linux.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] slub: Fix calculation of cpu slabs
Date: Mon, 14 Oct 2013 15:27:40 +0800 [thread overview]
Message-ID: <525B9CEC.5000903@huawei.com> (raw)
In-Reply-To: <0000014109b29246-61170b4a-7ab7-41f0-a887-a1cd62603196-000000@email.amazonses.com>
Hi Pekka,
could you pick up this patch?
On 2013/9/11 5:06, Christoph Lameter wrote:
> On Tue, 10 Sep 2013, Li Zefan wrote:
>
>> We should use page->pages instead of page->pobjects when calculating
>> the number of cpu partial slabs. This also fixes the mapping of slabs
>> and nodes.
>
> True.
>
>> As there's no variable storing the number of total/active objects in
>> cpu partial slabs, and we don't have user interfaces requiring those
>> statistics, I just add WARN_ON for those cases.
>
>
> Well that is not strictly required but it does not hurt either.
>
> Acked-by: Christoph Lameter <cl@linux.com>
>
next prev parent reply other threads:[~2013-10-14 7:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 3:43 [PATCH] slub: Fix calculation of cpu slabs Li Zefan
2013-09-10 3:43 ` Li Zefan
2013-09-10 21:06 ` Christoph Lameter
2013-09-10 21:06 ` Christoph Lameter
2013-10-14 7:27 ` Li Zefan [this message]
2013-10-14 7:27 ` Li Zefan
2013-10-05 7:48 ` Wanpeng Li
2013-12-29 11:45 ` Pekka Enberg
2013-12-29 11:45 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525B9CEC.5000903@huawei.com \
--to=lizefan@huawei.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.