All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore
Date: Tue, 15 Oct 2013 17:05:00 +0200	[thread overview]
Message-ID: <525D599C.5020307@redhat.com> (raw)
In-Reply-To: <525D4D2C.9040805@redhat.com>

On 10/15/13 16:11, Eric Blake wrote:
> On 10/15/2013 07:10 AM, Laszlo Ersek wrote:
>> Also sort the test-* entries in the latter.
>>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  .gitignore       |  9 ---------
>>  tests/.gitignore | 11 +++++++++--
>>  2 files changed, 9 insertions(+), 11 deletions(-)
> 
> This feels backwards to me.  I'd much rather have a single top-level
> .gitignore for everything.  We are no longer in the CVS days of having a
> per-directory ignore file.

Yes, I'm aware. I re-read your previous comment before posting:

http://thread.gmane.org/gmane.comp.emulators.qemu/228886/focus=229185

and I agree with it in theory.

However, current qemu practice (even recent patches, eg. 9dbb52e8) seem
to point in the opposite direction.

I don't feel strongly about this -- I just promised earlier to do it and
I want it off my shouler.

Thanks!
Laszlo



WARNING: multiple messages have this Message-ID (diff)
From: Laszlo Ersek <lersek@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore
Date: Tue, 15 Oct 2013 17:05:00 +0200	[thread overview]
Message-ID: <525D599C.5020307@redhat.com> (raw)
In-Reply-To: <525D4D2C.9040805@redhat.com>

On 10/15/13 16:11, Eric Blake wrote:
> On 10/15/2013 07:10 AM, Laszlo Ersek wrote:
>> Also sort the test-* entries in the latter.
>>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  .gitignore       |  9 ---------
>>  tests/.gitignore | 11 +++++++++--
>>  2 files changed, 9 insertions(+), 11 deletions(-)
> 
> This feels backwards to me.  I'd much rather have a single top-level
> .gitignore for everything.  We are no longer in the CVS days of having a
> per-directory ignore file.

Yes, I'm aware. I re-read your previous comment before posting:

http://thread.gmane.org/gmane.comp.emulators.qemu/228886/focus=229185

and I agree with it in theory.

However, current qemu practice (even recent patches, eg. 9dbb52e8) seem
to point in the opposite direction.

I don't feel strongly about this -- I just promised earlier to do it and
I want it off my shouler.

Thanks!
Laszlo

  reply	other threads:[~2013-10-15 15:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 13:10 [Qemu-trivial] [PATCH] move test-* from .gitignore to tests/.gitignore Laszlo Ersek
2013-10-15 13:10 ` [Qemu-devel] " Laszlo Ersek
2013-10-15 14:11 ` [Qemu-trivial] " Eric Blake
2013-10-15 14:11   ` Eric Blake
2013-10-15 15:05   ` Laszlo Ersek [this message]
2013-10-15 15:05     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525D599C.5020307@redhat.com \
    --to=lersek@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.