* [Qemu-trivial] [PATCH] move test-* from .gitignore to tests/.gitignore
@ 2013-10-15 13:10 ` Laszlo Ersek
0 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2013-10-15 13:10 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Also sort the test-* entries in the latter.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
.gitignore | 9 ---------
tests/.gitignore | 11 +++++++++--
2 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/.gitignore b/.gitignore
index 8e1b73f..7f4c106 100644
--- a/.gitignore
+++ b/.gitignore
@@ -45,15 +45,6 @@ qemu-bridge-helper
qemu-monitor.texi
vscclient
QMP/qmp-commands.txt
-test-bitops
-test-coroutine
-test-int128
-test-opts-visitor
-test-qmp-input-visitor
-test-qmp-output-visitor
-test-string-input-visitor
-test-string-output-visitor
-test-visitor-serialization
fsdev/virtfs-proxy-helper
fsdev/virtfs-proxy-helper.1
fsdev/virtfs-proxy-helper.pod
diff --git a/tests/.gitignore b/tests/.gitignore
index 425757c..dbed60f 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -6,20 +6,27 @@ check-qlist
check-qstring
test-aio
test-bitops
-test-throttle
+test-coroutine
test-cutils
test-hbitmap
test-int128
test-iov
test-mul64
+test-opts-visitor
test-qapi-types.[ch]
test-qapi-visit.[ch]
test-qdev-global-props
-test-qmp-commands.h
test-qmp-commands
+test-qmp-commands.h
test-qmp-input-strict
+test-qmp-input-visitor
test-qmp-marshal.c
+test-qmp-output-visitor
+test-string-input-visitor
+test-string-output-visitor
test-thread-pool
+test-throttle
+test-visitor-serialization
test-x86-cpuid
test-xbzrle
*-test
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore
@ 2013-10-15 13:10 ` Laszlo Ersek
0 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2013-10-15 13:10 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Also sort the test-* entries in the latter.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
.gitignore | 9 ---------
tests/.gitignore | 11 +++++++++--
2 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/.gitignore b/.gitignore
index 8e1b73f..7f4c106 100644
--- a/.gitignore
+++ b/.gitignore
@@ -45,15 +45,6 @@ qemu-bridge-helper
qemu-monitor.texi
vscclient
QMP/qmp-commands.txt
-test-bitops
-test-coroutine
-test-int128
-test-opts-visitor
-test-qmp-input-visitor
-test-qmp-output-visitor
-test-string-input-visitor
-test-string-output-visitor
-test-visitor-serialization
fsdev/virtfs-proxy-helper
fsdev/virtfs-proxy-helper.1
fsdev/virtfs-proxy-helper.pod
diff --git a/tests/.gitignore b/tests/.gitignore
index 425757c..dbed60f 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -6,20 +6,27 @@ check-qlist
check-qstring
test-aio
test-bitops
-test-throttle
+test-coroutine
test-cutils
test-hbitmap
test-int128
test-iov
test-mul64
+test-opts-visitor
test-qapi-types.[ch]
test-qapi-visit.[ch]
test-qdev-global-props
-test-qmp-commands.h
test-qmp-commands
+test-qmp-commands.h
test-qmp-input-strict
+test-qmp-input-visitor
test-qmp-marshal.c
+test-qmp-output-visitor
+test-string-input-visitor
+test-string-output-visitor
test-thread-pool
+test-throttle
+test-visitor-serialization
test-x86-cpuid
test-xbzrle
*-test
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore
2013-10-15 13:10 ` [Qemu-devel] " Laszlo Ersek
@ 2013-10-15 14:11 ` Eric Blake
-1 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2013-10-15 14:11 UTC (permalink / raw)
To: Laszlo Ersek, qemu-devel, qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On 10/15/2013 07:10 AM, Laszlo Ersek wrote:
> Also sort the test-* entries in the latter.
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> .gitignore | 9 ---------
> tests/.gitignore | 11 +++++++++--
> 2 files changed, 9 insertions(+), 11 deletions(-)
This feels backwards to me. I'd much rather have a single top-level
.gitignore for everything. We are no longer in the CVS days of having a
per-directory ignore file.
But I'm not the maintainer, so someone with actual check-in privileges
can feel free to override me preference.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore
@ 2013-10-15 14:11 ` Eric Blake
0 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2013-10-15 14:11 UTC (permalink / raw)
To: Laszlo Ersek, qemu-devel, qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On 10/15/2013 07:10 AM, Laszlo Ersek wrote:
> Also sort the test-* entries in the latter.
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> .gitignore | 9 ---------
> tests/.gitignore | 11 +++++++++--
> 2 files changed, 9 insertions(+), 11 deletions(-)
This feels backwards to me. I'd much rather have a single top-level
.gitignore for everything. We are no longer in the CVS days of having a
per-directory ignore file.
But I'm not the maintainer, so someone with actual check-in privileges
can feel free to override me preference.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore
2013-10-15 14:11 ` Eric Blake
@ 2013-10-15 15:05 ` Laszlo Ersek
-1 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2013-10-15 15:05 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-trivial, qemu-devel
On 10/15/13 16:11, Eric Blake wrote:
> On 10/15/2013 07:10 AM, Laszlo Ersek wrote:
>> Also sort the test-* entries in the latter.
>>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> .gitignore | 9 ---------
>> tests/.gitignore | 11 +++++++++--
>> 2 files changed, 9 insertions(+), 11 deletions(-)
>
> This feels backwards to me. I'd much rather have a single top-level
> .gitignore for everything. We are no longer in the CVS days of having a
> per-directory ignore file.
Yes, I'm aware. I re-read your previous comment before posting:
http://thread.gmane.org/gmane.comp.emulators.qemu/228886/focus=229185
and I agree with it in theory.
However, current qemu practice (even recent patches, eg. 9dbb52e8) seem
to point in the opposite direction.
I don't feel strongly about this -- I just promised earlier to do it and
I want it off my shouler.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore
@ 2013-10-15 15:05 ` Laszlo Ersek
0 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2013-10-15 15:05 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-trivial, qemu-devel
On 10/15/13 16:11, Eric Blake wrote:
> On 10/15/2013 07:10 AM, Laszlo Ersek wrote:
>> Also sort the test-* entries in the latter.
>>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> .gitignore | 9 ---------
>> tests/.gitignore | 11 +++++++++--
>> 2 files changed, 9 insertions(+), 11 deletions(-)
>
> This feels backwards to me. I'd much rather have a single top-level
> .gitignore for everything. We are no longer in the CVS days of having a
> per-directory ignore file.
Yes, I'm aware. I re-read your previous comment before posting:
http://thread.gmane.org/gmane.comp.emulators.qemu/228886/focus=229185
and I agree with it in theory.
However, current qemu practice (even recent patches, eg. 9dbb52e8) seem
to point in the opposite direction.
I don't feel strongly about this -- I just promised earlier to do it and
I want it off my shouler.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-15 15:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-15 13:10 [Qemu-trivial] [PATCH] move test-* from .gitignore to tests/.gitignore Laszlo Ersek
2013-10-15 13:10 ` [Qemu-devel] " Laszlo Ersek
2013-10-15 14:11 ` [Qemu-trivial] " Eric Blake
2013-10-15 14:11 ` Eric Blake
2013-10-15 15:05 ` [Qemu-trivial] " Laszlo Ersek
2013-10-15 15:05 ` Laszlo Ersek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.