All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Peter De Schrijver
	<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Prashant Gaikwad
	<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Mike Turquette
	<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 08/19] clk: tegra: add common infra for DT clocks
Date: Tue, 15 Oct 2013 13:01:43 -0600	[thread overview]
Message-ID: <525D9117.9050009@wwwdotorg.org> (raw)
In-Reply-To: <1381848794-11761-9-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 10/15/2013 08:52 AM, Peter De Schrijver wrote:
> Introduce a common infrastructure for sharing clock initialization between
> SoCs.

> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c

> +struct clk ** __init tegra_lookup_dt_id(int clk_id,
> +					struct tegra_clk *tegra_clk)
> +{
> +	if (tegra_clk[clk_id].present)
> +		return &clks[tegra_clk[clk_id].dt_id];
> +	else
> +		return NULL;

Does this need range-checking? Or do we assume that since this is an
internal function, "clk_id" will never be out-of-range?

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 08/19] clk: tegra: add common infra for DT clocks
Date: Tue, 15 Oct 2013 13:01:43 -0600	[thread overview]
Message-ID: <525D9117.9050009@wwwdotorg.org> (raw)
In-Reply-To: <1381848794-11761-9-git-send-email-pdeschrijver@nvidia.com>

On 10/15/2013 08:52 AM, Peter De Schrijver wrote:
> Introduce a common infrastructure for sharing clock initialization between
> SoCs.

> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c

> +struct clk ** __init tegra_lookup_dt_id(int clk_id,
> +					struct tegra_clk *tegra_clk)
> +{
> +	if (tegra_clk[clk_id].present)
> +		return &clks[tegra_clk[clk_id].dt_id];
> +	else
> +		return NULL;

Does this need range-checking? Or do we assume that since this is an
internal function, "clk_id" will never be out-of-range?

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Prashant Gaikwad <pgaikwad@nvidia.com>,
	Mike Turquette <mturquette@linaro.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Hiroshi Doyu <hdoyu@nvidia.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 08/19] clk: tegra: add common infra for DT clocks
Date: Tue, 15 Oct 2013 13:01:43 -0600	[thread overview]
Message-ID: <525D9117.9050009@wwwdotorg.org> (raw)
In-Reply-To: <1381848794-11761-9-git-send-email-pdeschrijver@nvidia.com>

On 10/15/2013 08:52 AM, Peter De Schrijver wrote:
> Introduce a common infrastructure for sharing clock initialization between
> SoCs.

> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c

> +struct clk ** __init tegra_lookup_dt_id(int clk_id,
> +					struct tegra_clk *tegra_clk)
> +{
> +	if (tegra_clk[clk_id].present)
> +		return &clks[tegra_clk[clk_id].dt_id];
> +	else
> +		return NULL;

Does this need range-checking? Or do we assume that since this is an
internal function, "clk_id" will never be out-of-range?

  parent reply	other threads:[~2013-10-15 19:01 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 14:52 [PATCH v3 00/19] Introduce common infra for tegra clocks Peter De Schrijver
2013-10-15 14:52 ` Peter De Schrijver
2013-10-15 14:52 ` Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 01/19] ARM: tegra30: add missing CLK IDs Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 02/19] clk: tegra: simplify periph clock data Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
     [not found]   ` <1381848794-11761-3-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 18:46     ` Stephen Warren
2013-10-15 18:46       ` Stephen Warren
2013-10-15 18:46       ` Stephen Warren
     [not found]       ` <525D8D7D.10301-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-16 15:06         ` Peter De Schrijver
2013-10-16 15:06           ` Peter De Schrijver
2013-10-16 15:06           ` Peter De Schrijver
2013-10-16 17:06           ` Stephen Warren
2013-10-16 17:06             ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 03/19] clk: tegra: common periph_clk_enb_refcnt and clks Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
     [not found]   ` <1381848794-11761-4-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 18:52     ` Stephen Warren
2013-10-15 18:52       ` Stephen Warren
2013-10-15 18:52       ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 05/19] clk: tegra: move some PLLC and PLLXC init to clk-pll.c Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
     [not found]   ` <1381848794-11761-6-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 18:59     ` Stephen Warren
2013-10-15 18:59       ` Stephen Warren
2013-10-15 18:59       ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 06/19] clk: tegra: move fields to tegra_clk_pll_params Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 07/19] clk: tegra: add header for common tegra clock IDs Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 08/19] clk: tegra: add common infra for DT clocks Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
     [not found]   ` <1381848794-11761-9-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 19:01     ` Stephen Warren [this message]
2013-10-15 19:01       ` Stephen Warren
2013-10-15 19:01       ` Stephen Warren
     [not found]       ` <525D9117.9050009-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-16 14:34         ` Peter De Schrijver
2013-10-16 14:34           ` Peter De Schrijver
2013-10-16 14:34           ` Peter De Schrijver
     [not found]           ` <20131016143448.GK5643-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-10-16 17:02             ` Stephen Warren
2013-10-16 17:02               ` Stephen Warren
2013-10-16 17:02               ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 09/19] clk: tegra: add clkdev registration infra Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 19:08   ` Stephen Warren
2013-10-15 19:08     ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 10/19] clk: tegra: move audio clk to common file Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
     [not found]   ` <1381848794-11761-11-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 19:13     ` Stephen Warren
2013-10-15 19:13       ` Stephen Warren
2013-10-15 19:13       ` Stephen Warren
     [not found]       ` <525D93E8.1010903-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-16  7:35         ` Peter De Schrijver
2013-10-16  7:35           ` Peter De Schrijver
2013-10-16  7:35           ` Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 11/19] clk: tegra: move periph clocks " Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
     [not found]   ` <1381848794-11761-12-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 19:19     ` Stephen Warren
2013-10-15 19:19       ` Stephen Warren
2013-10-15 19:19       ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 12/19] clk: tegra: move PMC, fixed clocks to common files Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 13/19] clk: tegra: introduce common gen4 super clock Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
     [not found]   ` <1381848794-11761-14-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 19:37     ` Stephen Warren
2013-10-15 19:37       ` Stephen Warren
2013-10-15 19:37       ` Stephen Warren
     [not found]       ` <525D9973.2070501-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-16  7:38         ` Peter De Schrijver
2013-10-16  7:38           ` Peter De Schrijver
2013-10-16  7:38           ` Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 14/19] clk: tegra30: replace enum by binding header Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
2013-10-15 14:52   ` Peter De Schrijver
     [not found]   ` <1381848794-11761-15-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 19:41     ` Stephen Warren
2013-10-15 19:41       ` Stephen Warren
2013-10-15 19:41       ` Stephen Warren
     [not found]       ` <525D9A85.40102-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-16 14:46         ` Peter De Schrijver
2013-10-16 14:46           ` Peter De Schrijver
2013-10-16 14:46           ` Peter De Schrijver
     [not found]           ` <20131016144618.GL5643-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-10-16 17:02             ` Stephen Warren
2013-10-16 17:02               ` Stephen Warren
2013-10-16 17:02               ` Stephen Warren
2013-10-15 14:53 ` [PATCH v3 16/19] clk: tegra20: move tegra20 to common clkdev Peter De Schrijver
2013-10-15 14:53   ` Peter De Schrijver
2013-10-15 14:53   ` Peter De Schrijver
2013-10-15 14:53 ` [PATCH v3 17/19] clk: tegra30: move tegra30 " Peter De Schrijver
2013-10-15 14:53   ` Peter De Schrijver
2013-10-15 14:53   ` Peter De Schrijver
2013-10-15 14:53 ` [PATCH v3 18/19] clk: tegra20: move to common periph clk Peter De Schrijver
2013-10-15 14:53   ` Peter De Schrijver
2013-10-15 14:53   ` Peter De Schrijver
2013-10-15 14:53 ` [PATCH v3 19/19] clk: tegra30: move to common tegra clk infra Peter De Schrijver
2013-10-15 14:53   ` Peter De Schrijver
2013-10-15 14:53   ` Peter De Schrijver
     [not found]   ` <1381848794-11761-20-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 19:43     ` Stephen Warren
2013-10-15 19:43       ` Stephen Warren
2013-10-15 19:43       ` Stephen Warren
     [not found] ` <1381848794-11761-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-15 14:52   ` [PATCH v3 04/19] clk: tegra: Add TEGRA_PERIPH_NO_DIV flag Peter De Schrijver
2013-10-15 14:52     ` Peter De Schrijver
2013-10-15 14:52     ` Peter De Schrijver
2013-10-15 14:53   ` [PATCH v3 15/19] clk: tegra20: replace enum by binding header Peter De Schrijver
2013-10-15 14:53     ` Peter De Schrijver
2013-10-15 14:53     ` Peter De Schrijver
2013-10-15 17:48   ` [PATCH v3 00/19] Introduce common infra for tegra clocks Stephen Warren
2013-10-15 17:48     ` Stephen Warren
2013-10-15 17:48     ` Stephen Warren
     [not found]     ` <525D8009.5040907-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-16  9:06       ` Peter De Schrijver
2013-10-16  9:06         ` Peter De Schrijver
2013-10-16  9:06         ` Peter De Schrijver
     [not found]         ` <20131016090643.GI5643-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-10-16 17:14           ` Stephen Warren
2013-10-16 17:14             ` Stephen Warren
2013-10-16 17:14             ` Stephen Warren
2013-10-17  7:52             ` Peter De Schrijver
2013-10-17  7:52               ` Peter De Schrijver
2013-10-15 19:43   ` Stephen Warren
2013-10-15 19:43     ` Stephen Warren
2013-10-15 19:43     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525D9117.9050009@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.