From: mugunthanvnm@ti.com (Mugunthan V N)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net/ethernet: cpsw: Bugfix interrupts before enabling napi
Date: Wed, 16 Oct 2013 18:28:36 +0530 [thread overview]
Message-ID: <525E8D7C.5050702@ti.com> (raw)
In-Reply-To: <1381691821-25498-1-git-send-email-mpa@pengutronix.de>
On Monday 14 October 2013 12:47 AM, Markus Pargmann wrote:
> If interrupts happen before napi_enable was called, the driver will not
> work as expected. Network transmissions are impossible in this state.
> This bug can be reproduced easily by restarting the network interface in
> a loop. After some time any network transmissions on the network
> interface will fail.
>
> This patch fixes the bug by enabling napi before enabling the network
> interface interrupts.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: Mugunthan V N <mugunthanvnm@ti.com>
To: Markus Pargmann <mpa@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>
Cc: kernel@pengutronix.de, netdev@vger.kernel.org,
Peter Korsgaard <peter@korsgaard.com>,
Florian Fainelli <florian@openwrt.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net/ethernet: cpsw: Bugfix interrupts before enabling napi
Date: Wed, 16 Oct 2013 18:28:36 +0530 [thread overview]
Message-ID: <525E8D7C.5050702@ti.com> (raw)
In-Reply-To: <1381691821-25498-1-git-send-email-mpa@pengutronix.de>
On Monday 14 October 2013 12:47 AM, Markus Pargmann wrote:
> If interrupts happen before napi_enable was called, the driver will not
> work as expected. Network transmissions are impossible in this state.
> This bug can be reproduced easily by restarting the network interface in
> a loop. After some time any network transmissions on the network
> interface will fail.
>
> This patch fixes the bug by enabling napi before enabling the network
> interface interrupts.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-10-16 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 19:17 [PATCH] net/ethernet: cpsw: Bugfix interrupts before enabling napi Markus Pargmann
2013-10-13 19:17 ` Markus Pargmann
2013-10-14 11:48 ` Peter Korsgaard
2013-10-14 11:48 ` Peter Korsgaard
2013-10-16 12:58 ` Mugunthan V N [this message]
2013-10-16 12:58 ` Mugunthan V N
2013-10-17 19:48 ` David Miller
2013-10-17 19:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E8D7C.5050702@ti.com \
--to=mugunthanvnm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.