From: peter@korsgaard.com (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net/ethernet: cpsw: Bugfix interrupts before enabling napi
Date: Mon, 14 Oct 2013 13:48:29 +0200 [thread overview]
Message-ID: <8738o4rs36.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1381691821-25498-1-git-send-email-mpa@pengutronix.de> (Markus Pargmann's message of "Sun, 13 Oct 2013 21:17:01 +0200")
>>>>> "Markus" == Markus Pargmann <mpa@pengutronix.de> writes:
Markus> If interrupts happen before napi_enable was called, the driver will not
Markus> work as expected. Network transmissions are impossible in this state.
Markus> This bug can be reproduced easily by restarting the network interface in
Markus> a loop. After some time any network transmissions on the network
Markus> interface will fail.
Markus> This patch fixes the bug by enabling napi before enabling the network
Markus> interface interrupts.
Markus> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <peter@korsgaard.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <florian@openwrt.org>,
Mugunthan V N <mugunthanvnm@ti.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] net/ethernet: cpsw: Bugfix interrupts before enabling napi
Date: Mon, 14 Oct 2013 13:48:29 +0200 [thread overview]
Message-ID: <8738o4rs36.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1381691821-25498-1-git-send-email-mpa@pengutronix.de> (Markus Pargmann's message of "Sun, 13 Oct 2013 21:17:01 +0200")
>>>>> "Markus" == Markus Pargmann <mpa@pengutronix.de> writes:
Markus> If interrupts happen before napi_enable was called, the driver will not
Markus> work as expected. Network transmissions are impossible in this state.
Markus> This bug can be reproduced easily by restarting the network interface in
Markus> a loop. After some time any network transmissions on the network
Markus> interface will fail.
Markus> This patch fixes the bug by enabling napi before enabling the network
Markus> interface interrupts.
Markus> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-10-14 11:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 19:17 [PATCH] net/ethernet: cpsw: Bugfix interrupts before enabling napi Markus Pargmann
2013-10-13 19:17 ` Markus Pargmann
2013-10-14 11:48 ` Peter Korsgaard [this message]
2013-10-14 11:48 ` Peter Korsgaard
2013-10-16 12:58 ` Mugunthan V N
2013-10-16 12:58 ` Mugunthan V N
2013-10-17 19:48 ` David Miller
2013-10-17 19:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738o4rs36.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.