All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Niklas Cassel" <cassel@kernel.org>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Hans Zhang" <18255117159@163.com>,
	"open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS"
	<linux-pci@vger.kernel.org>,
	"moderated list:ARM/Rockchip SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC support"
	<linux-rockchip@lists.infradead.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Anand Moon" <linux.amoon@gmail.com>
Cc: Anand Moon <linux.amoon@gmail.com>
Subject: Re: [PATCH v1 0/2] Add runtime PM support to Rockchip DW PCIe driver
Date: Mon, 27 Oct 2025 16:06:44 +0100	[thread overview]
Message-ID: <5264377.31r3eYUQgx@workhorse> (raw)
In-Reply-To: <20251027145602.199154-1-linux.amoon@gmail.com>

On Monday, 27 October 2025 15:55:28 Central European Standard Time Anand Moon wrote:
> Introduce runtime power management support in the Rockchip DesignWare PCIe
> controller driver.  These changes allow the PCIe controller to suspend and
> resume dynamically, improving power efficiency on supported platforms.
> 
> Can Patch 1 can be backpoted to stable? It helps clean shutdown of PCIe.

You can do this by adding a Fixes tag to your patch. In your case, it
might be fixing whatever introduced the clk_bulk_prepare_enable, i.e.:

Fixes: 0e898eb8df4e ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver")

This would be put above your Signed-off-by in the first patch, after
the empty line.

To generate fixes tags like this, I use the following pretty format
in my .git/config:

    [pretty]
        fixes = Fixes: %h (\"%s\")

I can then do `git log --pretty=fixes` to show commits formatted
the right way. To find which commit to pick, `git blame` and
some sleuthing are helpful.

With this tag, stable bots can pick the commit into any release
that the commit it fixes is in.

Kind regards,
Nicolas Frattaroli

> 
> Clarification: the series is based on
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git
> branch : controller/dw-rockchip
> 
> Thanks
> -Anand
> 
> Anand Moon (2):
>   PCI: dw-rockchip: Add remove callback for resource cleanup
>   PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe driver
> 
>  drivers/pci/controller/dwc/pcie-dw-rockchip.c | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> 
> base-commit: 7ad31f88429369ada44710176e176256a2812c3f
> 






WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Niklas Cassel" <cassel@kernel.org>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Hans Zhang" <18255117159@163.com>,
	"open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS"
	<linux-pci@vger.kernel.org>,
	"moderated list:ARM/Rockchip SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC support"
	<linux-rockchip@lists.infradead.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Anand Moon" <linux.amoon@gmail.com>
Cc: Anand Moon <linux.amoon@gmail.com>
Subject: Re: [PATCH v1 0/2] Add runtime PM support to Rockchip DW PCIe driver
Date: Mon, 27 Oct 2025 16:06:44 +0100	[thread overview]
Message-ID: <5264377.31r3eYUQgx@workhorse> (raw)
In-Reply-To: <20251027145602.199154-1-linux.amoon@gmail.com>

On Monday, 27 October 2025 15:55:28 Central European Standard Time Anand Moon wrote:
> Introduce runtime power management support in the Rockchip DesignWare PCIe
> controller driver.  These changes allow the PCIe controller to suspend and
> resume dynamically, improving power efficiency on supported platforms.
> 
> Can Patch 1 can be backpoted to stable? It helps clean shutdown of PCIe.

You can do this by adding a Fixes tag to your patch. In your case, it
might be fixing whatever introduced the clk_bulk_prepare_enable, i.e.:

Fixes: 0e898eb8df4e ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver")

This would be put above your Signed-off-by in the first patch, after
the empty line.

To generate fixes tags like this, I use the following pretty format
in my .git/config:

    [pretty]
        fixes = Fixes: %h (\"%s\")

I can then do `git log --pretty=fixes` to show commits formatted
the right way. To find which commit to pick, `git blame` and
some sleuthing are helpful.

With this tag, stable bots can pick the commit into any release
that the commit it fixes is in.

Kind regards,
Nicolas Frattaroli

> 
> Clarification: the series is based on
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git
> branch : controller/dw-rockchip
> 
> Thanks
> -Anand
> 
> Anand Moon (2):
>   PCI: dw-rockchip: Add remove callback for resource cleanup
>   PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe driver
> 
>  drivers/pci/controller/dwc/pcie-dw-rockchip.c | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> 
> base-commit: 7ad31f88429369ada44710176e176256a2812c3f
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2025-10-27 15:07 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27 14:55 [PATCH v1 0/2] Add runtime PM support to Rockchip DW PCIe driver Anand Moon
2025-10-27 14:55 ` Anand Moon
2025-10-27 14:55 ` [PATCH v1 1/2] PCI: dw-rockchip: Add remove callback for resource cleanup Anand Moon
2025-10-27 14:55   ` Anand Moon
2025-10-27 15:12   ` Nicolas Frattaroli
2025-10-27 15:12     ` Nicolas Frattaroli
2025-10-27 16:31     ` Anand Moon
2025-10-27 16:31       ` Anand Moon
2025-10-27 17:17       ` Nicolas Frattaroli
2025-10-27 17:17         ` Nicolas Frattaroli
2025-10-28  0:26   ` Shawn Lin
2025-10-28  0:26     ` Shawn Lin
2025-10-28  9:34     ` Anand Moon
2025-10-28  9:34       ` Anand Moon
2025-10-29  0:28       ` Shawn Lin
2025-10-29  0:28         ` Shawn Lin
2025-10-29  6:24         ` Anand Moon
2025-10-29  6:24           ` Anand Moon
2025-10-31  8:36   ` Manivannan Sadhasivam
2025-10-31  8:36     ` Manivannan Sadhasivam
2025-10-31 12:29     ` Nicolas Frattaroli
2025-10-31 12:29       ` Nicolas Frattaroli
2025-10-31 15:08       ` Manivannan Sadhasivam
2025-10-31 15:08         ` Manivannan Sadhasivam
2025-10-27 14:55 ` [PATCH v1 2/2] PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe driver Anand Moon
2025-10-27 14:55   ` Anand Moon
2025-10-28  0:44   ` Shawn Lin
2025-10-28  0:44     ` Shawn Lin
2025-10-28  9:34     ` Anand Moon
2025-10-28  9:34       ` Anand Moon
2025-10-31  8:39   ` Manivannan Sadhasivam
2025-10-31  8:39     ` Manivannan Sadhasivam
2025-10-31 14:03     ` Anand Moon
2025-10-31 14:03       ` Anand Moon
2025-10-31 14:53       ` Manivannan Sadhasivam
2025-10-31 14:53         ` Manivannan Sadhasivam
2025-11-01  8:09         ` Anand Moon
2025-11-01  8:09           ` Anand Moon
2025-10-27 15:06 ` Nicolas Frattaroli [this message]
2025-10-27 15:06   ` [PATCH v1 0/2] Add runtime PM support to Rockchip DW " Nicolas Frattaroli
2025-10-29  6:29   ` Anand Moon
2025-10-29  6:29     ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5264377.31r3eYUQgx@workhorse \
    --to=nicolas.frattaroli@collabora.com \
    --cc=18255117159@163.com \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=heiko@sntech.de \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux.amoon@gmail.com \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.