All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>,
	Benoit Cousson <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jyri Sarha <jsarha-l0cyMroinI0@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: am4372: Add McASP nodes
Date: Mon, 21 Oct 2013 23:01:15 +0400	[thread overview]
Message-ID: <526579FB.10005@cogentembedded.com> (raw)
In-Reply-To: <1382348758-1083-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>

Hello.

On 10/21/2013 01:45 PM, Peter Ujfalusi wrote:

> Add nodes for McASP0 and McASP1 for AM43xx.

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
> ---
>   arch/arm/boot/dts/am4372.dtsi | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)

> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index c328d5c..defaad1 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -633,5 +633,32 @@
>   			dma-names = "tx", "rx";
>   		};
>
> +		mcasp0: mcasp@48038000 {

    According to ePAPR spec [1], "the name of a node should be somewhat 
generic, reflecting the function of the device and not its
precise programming model". In this case probably "sound"?

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: am4372: Add McASP nodes
Date: Mon, 21 Oct 2013 23:01:15 +0400	[thread overview]
Message-ID: <526579FB.10005@cogentembedded.com> (raw)
In-Reply-To: <1382348758-1083-1-git-send-email-peter.ujfalusi@ti.com>

Hello.

On 10/21/2013 01:45 PM, Peter Ujfalusi wrote:

> Add nodes for McASP0 and McASP1 for AM43xx.

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>   arch/arm/boot/dts/am4372.dtsi | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)

> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index c328d5c..defaad1 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -633,5 +633,32 @@
>   			dma-names = "tx", "rx";
>   		};
>
> +		mcasp0: mcasp at 48038000 {

    According to ePAPR spec [1], "the name of a node should be somewhat 
generic, reflecting the function of the device and not its
precise programming model". In this case probably "sound"?

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Benoit Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	Jyri Sarha <jsarha@ti.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: am4372: Add McASP nodes
Date: Mon, 21 Oct 2013 23:01:15 +0400	[thread overview]
Message-ID: <526579FB.10005@cogentembedded.com> (raw)
In-Reply-To: <1382348758-1083-1-git-send-email-peter.ujfalusi@ti.com>

Hello.

On 10/21/2013 01:45 PM, Peter Ujfalusi wrote:

> Add nodes for McASP0 and McASP1 for AM43xx.

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>   arch/arm/boot/dts/am4372.dtsi | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)

> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index c328d5c..defaad1 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -633,5 +633,32 @@
>   			dma-names = "tx", "rx";
>   		};
>
> +		mcasp0: mcasp@48038000 {

    According to ePAPR spec [1], "the name of a node should be somewhat 
generic, reflecting the function of the device and not its
precise programming model". In this case probably "sound"?

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei


  parent reply	other threads:[~2013-10-21 19:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21  9:45 [PATCH] ARM: dts: am4372: Add McASP nodes Peter Ujfalusi
2013-10-21  9:45 ` Peter Ujfalusi
2013-10-21  9:45 ` Peter Ujfalusi
     [not found] ` <1382348758-1083-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2013-10-21 19:01   ` Sergei Shtylyov [this message]
2013-10-21 19:01     ` Sergei Shtylyov
2013-10-21 19:01     ` Sergei Shtylyov
2013-10-22  7:46     ` Peter Ujfalusi
2013-10-22  7:46       ` Peter Ujfalusi
2013-10-22  7:46       ` Peter Ujfalusi
2013-10-22  8:33       ` Benoit Cousson
2013-10-22  8:33         ` Benoit Cousson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526579FB.10005@cogentembedded.com \
    --to=sergei.shtylyov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jsarha-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.