From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH] ARM: dts: am4372: Add McASP nodes
Date: Tue, 22 Oct 2013 10:46:03 +0300 [thread overview]
Message-ID: <52662D3B.5050204@ti.com> (raw)
In-Reply-To: <526579FB.10005@cogentembedded.com>
Hi,
On 10/21/2013 10:01 PM, Sergei Shtylyov wrote:
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index c328d5c..defaad1 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -633,5 +633,32 @@
>> dma-names = "tx", "rx";
>> };
>>
>> + mcasp0: mcasp@48038000 {
>
> According to ePAPR spec [1], "the name of a node should be somewhat
> generic, reflecting the function of the device and not its
> precise programming model". In this case probably "sound"?
We use the 'sound' node name for the sound card itself. The case with McASP is
a bit complicated. It can operate in I2S mode (and similar protocols like RJM,
LJM, TDM) or it can interface with S/PDIF, IEC60958-1, AES-3 codecs.
The mode we put McASP depends on the external components, so the same McASP
can be used in I2S mode in one board while on the other it can be S/PDIF.
It would have been convenient if I could use 'i2s' as node name but it is not
true for McASP (Tegra, Exynos for example have I2S, AC97, S/PDIF as separate IP).
IMHO the 'mcasp' is still the best node name for this IP. McASP stands for:
'Multichannel Audio Serial Port' and this is pretty much what McASP is.
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: am4372: Add McASP nodes
Date: Tue, 22 Oct 2013 10:46:03 +0300 [thread overview]
Message-ID: <52662D3B.5050204@ti.com> (raw)
In-Reply-To: <526579FB.10005@cogentembedded.com>
Hi,
On 10/21/2013 10:01 PM, Sergei Shtylyov wrote:
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index c328d5c..defaad1 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -633,5 +633,32 @@
>> dma-names = "tx", "rx";
>> };
>>
>> + mcasp0: mcasp at 48038000 {
>
> According to ePAPR spec [1], "the name of a node should be somewhat
> generic, reflecting the function of the device and not its
> precise programming model". In this case probably "sound"?
We use the 'sound' node name for the sound card itself. The case with McASP is
a bit complicated. It can operate in I2S mode (and similar protocols like RJM,
LJM, TDM) or it can interface with S/PDIF, IEC60958-1, AES-3 codecs.
The mode we put McASP depends on the external components, so the same McASP
can be used in I2S mode in one board while on the other it can be S/PDIF.
It would have been convenient if I could use 'i2s' as node name but it is not
true for McASP (Tegra, Exynos for example have I2S, AC97, S/PDIF as separate IP).
IMHO the 'mcasp' is still the best node name for this IP. McASP stands for:
'Multichannel Audio Serial Port' and this is pretty much what McASP is.
--
P?ter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>
Cc: <devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>,
Jyri Sarha <jsarha@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: am4372: Add McASP nodes
Date: Tue, 22 Oct 2013 10:46:03 +0300 [thread overview]
Message-ID: <52662D3B.5050204@ti.com> (raw)
In-Reply-To: <526579FB.10005@cogentembedded.com>
Hi,
On 10/21/2013 10:01 PM, Sergei Shtylyov wrote:
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index c328d5c..defaad1 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -633,5 +633,32 @@
>> dma-names = "tx", "rx";
>> };
>>
>> + mcasp0: mcasp@48038000 {
>
> According to ePAPR spec [1], "the name of a node should be somewhat
> generic, reflecting the function of the device and not its
> precise programming model". In this case probably "sound"?
We use the 'sound' node name for the sound card itself. The case with McASP is
a bit complicated. It can operate in I2S mode (and similar protocols like RJM,
LJM, TDM) or it can interface with S/PDIF, IEC60958-1, AES-3 codecs.
The mode we put McASP depends on the external components, so the same McASP
can be used in I2S mode in one board while on the other it can be S/PDIF.
It would have been convenient if I could use 'i2s' as node name but it is not
true for McASP (Tegra, Exynos for example have I2S, AC97, S/PDIF as separate IP).
IMHO the 'mcasp' is still the best node name for this IP. McASP stands for:
'Multichannel Audio Serial Port' and this is pretty much what McASP is.
--
Péter
next prev parent reply other threads:[~2013-10-22 7:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 9:45 [PATCH] ARM: dts: am4372: Add McASP nodes Peter Ujfalusi
2013-10-21 9:45 ` Peter Ujfalusi
2013-10-21 9:45 ` Peter Ujfalusi
[not found] ` <1382348758-1083-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2013-10-21 19:01 ` Sergei Shtylyov
2013-10-21 19:01 ` Sergei Shtylyov
2013-10-21 19:01 ` Sergei Shtylyov
2013-10-22 7:46 ` Peter Ujfalusi [this message]
2013-10-22 7:46 ` Peter Ujfalusi
2013-10-22 7:46 ` Peter Ujfalusi
2013-10-22 8:33 ` Benoit Cousson
2013-10-22 8:33 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52662D3B.5050204@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.