Re: [Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[]

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

On 10/21/2013 03:16 AM, Wenchao Xia wrote:
> Use the generated table in qapi-types.h.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  monitor.c |   36 ++----------------------------------
>  1 files changed, 2 insertions(+), 34 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

(but may change if you rebase things to avoid churn in 3/5)

> @@ -1070,7 +1038,7 @@ EventInfoList *qmp_query_events(Error **errp)
>      QEvent e;
>  
>      for (e = 0 ; e < Q_EVENT_MAX ; e++) {
> -        const char *event_name = monitor_event_names[e];
> +        const char *event_name = QEvent_lookup[e];
>          assert(event_name != NULL);
>          info = g_malloc0(sizeof(*info));
>          info->value = g_malloc0(sizeof(*info->value));
> 

Remember this spot in patch 6/6...


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]