Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

于 2013/10/22 4:41, Eric Blake 写道:
> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
>> The define will be moved to qapi-schema.json later, so rename the
>> prefix to match its naming style.
> Wouldn't it be simpler to fix the code generator to special case QEvent
> to turn into QEVENT, instead of having to go through this churn?  But if
> we _like_ the Q_EVENT_ prefix, then this looks fairly mechanical:
>
>> Also fixed code style error reported in spice-core.c.
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> ---
>>   balloon.c                 |    2 +-
>>   block.c                   |    4 +-
>>   block/qcow2-refcount.c    |    2 +-
>>   blockdev.c                |    4 +-
>>   blockjob.c                |    5 ++-
>>   cpus.c                    |    2 +-
>>   hw/acpi/core.c            |    2 +-
>>   hw/core/qdev.c            |    2 +-
>>   hw/misc/pvpanic.c         |    2 +-
>>   hw/net/virtio-net.c       |    2 +-
>>   hw/watchdog/watchdog.c    |    2 +-
>>   include/monitor/monitor.h |   58 +++++++++++++++++-----------------
>>   monitor.c                 |   74 ++++++++++++++++++++++----------------------
>>   target-s390x/kvm.c        |    2 +-
>>   ui/spice-core.c           |    8 ++--
>>   ui/vnc.c                  |    6 ++--
>>   vl.c                      |   14 ++++----
>>   17 files changed, 96 insertions(+), 95 deletions(-)
> If no one else is as opposed to the Q_EVENT naming as I seem to be, then
> you can add my reluctant
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> in that your change is mechanical and correct.
>
   Personally I think less special case is better, and there is no harm
to do a mechanical prefix change in code. Markus, can I have your opinion?
also cc qapi-types.py author Anthony.