Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

于 2013/10/30 19:55, Paolo Bonzini 写道:
> Il 30/10/2013 08:27, Wenchao Xia ha scritto:
>> 于 2013/10/30 2:18, Kevin Wolf 写道:
>>> Am 21.10.2013 um 22:41 hat Eric Blake geschrieben:
>>>> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
>>>>> The define will be moved to qapi-schema.json later, so rename the
>>>>> prefix to match its naming style.
>>>> Wouldn't it be simpler to fix the code generator to special case QEvent
>>>> to turn into QEVENT, instead of having to go through this churn?  But if
>>>> we _like_ the Q_EVENT_ prefix, then this looks fairly mechanical:
>>> Or rather, instead of special casing QEvent, it shouldn't insert
>>> underscores if there is nothing between the two capital letters.
>
> ... but it should still insert one before the very last capital letter.
>   For example AIOType should become AIO_TYPE, not AIOTYPE.
>
>>> I've had a similar case with AIO in the blockdev-add series; and while
>>> renaming it to Aio worked, this kind of thing doesn't seem to be a rare
>>> exception in practice, so it might be worth adjusting the generator.
>>
>> It seems the right way, will adjust the generator.
>
> I think even if you adjusted it, it would be a no-op in this case.  For
> example:
>
>      AIOType => AIO_TYPE
>      QEvent  => Q_EVENT
>
> Paolo
>

   Maybe check whether there is more than two continous capitalized char?