From: Tero Kristo <t-kristo@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Archit Taneja <archit@ti.com>
Subject: Re: [PATCH 1/3] ARM: OMAP4: use CLK_SET_RATE_PARENT for dss_dss_clk
Date: Thu, 24 Oct 2013 16:23:13 +0300 [thread overview]
Message-ID: <52691F41.1030900@ti.com> (raw)
In-Reply-To: <5268D44D.5010205@ti.com>
On 10/24/2013 11:03 AM, Tomi Valkeinen wrote:
> Hi Tony, Tero,
>
> On 09/10/13 16:12, Tomi Valkeinen wrote:
>> Set CLK_SET_RATE_PARENT flag for dss_dss_clk so that the DSS's fclk can
>> be configured without the need to get the parent of the fclk.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> ---
>> arch/arm/mach-omap2/cclock44xx_data.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
>> index b237950..ec0dc0b 100644
>> --- a/arch/arm/mach-omap2/cclock44xx_data.c
>> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
>> @@ -830,7 +830,8 @@ DEFINE_CLK_GATE(dss_tv_clk, "extalt_clkin_ck", &extalt_clkin_ck, 0x0,
>> OMAP4430_CM_DSS_DSS_CLKCTRL,
>> OMAP4430_OPTFCLKEN_TV_CLK_SHIFT, 0x0, NULL);
>>
>> -DEFINE_CLK_GATE(dss_dss_clk, "dpll_per_m5x2_ck", &dpll_per_m5x2_ck, 0x0,
>> +DEFINE_CLK_GATE(dss_dss_clk, "dpll_per_m5x2_ck", &dpll_per_m5x2_ck,
>> + CLK_SET_RATE_PARENT,
>> OMAP4430_CM_DSS_DSS_CLKCTRL, OMAP4430_OPTFCLKEN_DSSCLK_SHIFT,
>> 0x0, NULL);
>
> I was discussing with Tero about these three patches, and he was ok with
> them being merged.
>
> Tony, it'd be great to have these for 3.13, so that I can start cleaning
> up the DSS driver's fclk management.
Yea, am ok with these, I can incorporate the changes to my DT clk series.
-Tero
WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: OMAP4: use CLK_SET_RATE_PARENT for dss_dss_clk
Date: Thu, 24 Oct 2013 16:23:13 +0300 [thread overview]
Message-ID: <52691F41.1030900@ti.com> (raw)
In-Reply-To: <5268D44D.5010205@ti.com>
On 10/24/2013 11:03 AM, Tomi Valkeinen wrote:
> Hi Tony, Tero,
>
> On 09/10/13 16:12, Tomi Valkeinen wrote:
>> Set CLK_SET_RATE_PARENT flag for dss_dss_clk so that the DSS's fclk can
>> be configured without the need to get the parent of the fclk.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> ---
>> arch/arm/mach-omap2/cclock44xx_data.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
>> index b237950..ec0dc0b 100644
>> --- a/arch/arm/mach-omap2/cclock44xx_data.c
>> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
>> @@ -830,7 +830,8 @@ DEFINE_CLK_GATE(dss_tv_clk, "extalt_clkin_ck", &extalt_clkin_ck, 0x0,
>> OMAP4430_CM_DSS_DSS_CLKCTRL,
>> OMAP4430_OPTFCLKEN_TV_CLK_SHIFT, 0x0, NULL);
>>
>> -DEFINE_CLK_GATE(dss_dss_clk, "dpll_per_m5x2_ck", &dpll_per_m5x2_ck, 0x0,
>> +DEFINE_CLK_GATE(dss_dss_clk, "dpll_per_m5x2_ck", &dpll_per_m5x2_ck,
>> + CLK_SET_RATE_PARENT,
>> OMAP4430_CM_DSS_DSS_CLKCTRL, OMAP4430_OPTFCLKEN_DSSCLK_SHIFT,
>> 0x0, NULL);
>
> I was discussing with Tero about these three patches, and he was ok with
> them being merged.
>
> Tony, it'd be great to have these for 3.13, so that I can start cleaning
> up the DSS driver's fclk management.
Yea, am ok with these, I can incorporate the changes to my DT clk series.
-Tero
next prev parent reply other threads:[~2013-10-24 13:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 13:12 [PATCH 1/3] ARM: OMAP4: use CLK_SET_RATE_PARENT for dss_dss_clk Tomi Valkeinen
2013-10-09 13:12 ` Tomi Valkeinen
2013-10-09 13:12 ` [PATCH 2/3] ARM: OMAP3: use CLK_SET_RATE_PARENT for dss clocks Tomi Valkeinen
2013-10-09 13:12 ` Tomi Valkeinen
2013-10-24 15:13 ` Paul Walmsley
2013-10-24 15:13 ` Paul Walmsley
2013-10-09 13:12 ` [PATCH 3/3] ARM: OMAP3: fix dpll4_m3_ck and dpll4_m4_ck dividers Tomi Valkeinen
2013-10-09 13:12 ` Tomi Valkeinen
2013-10-09 13:22 ` Tero Kristo
2013-10-09 13:22 ` Tero Kristo
2013-10-09 13:33 ` Tomi Valkeinen
2013-10-09 13:33 ` Tomi Valkeinen
2013-10-09 13:43 ` Tero Kristo
2013-10-09 13:43 ` Tero Kristo
2013-10-24 15:14 ` Paul Walmsley
2013-10-24 15:14 ` Paul Walmsley
2013-10-09 13:22 ` [PATCH 1/3] ARM: OMAP4: use CLK_SET_RATE_PARENT for dss_dss_clk Tero Kristo
2013-10-09 13:22 ` Tero Kristo
2013-10-09 13:39 ` Tomi Valkeinen
2013-10-09 13:39 ` Tomi Valkeinen
2013-10-24 8:03 ` Tomi Valkeinen
2013-10-24 8:03 ` Tomi Valkeinen
2013-10-24 13:23 ` Tero Kristo [this message]
2013-10-24 13:23 ` Tero Kristo
2013-10-24 13:28 ` Tony Lindgren
2013-10-24 13:28 ` Tony Lindgren
2013-10-24 13:31 ` Tero Kristo
2013-10-24 13:31 ` Tero Kristo
2013-10-24 13:42 ` Tony Lindgren
2013-10-24 13:42 ` Tony Lindgren
2013-10-24 15:13 ` Paul Walmsley
2013-10-24 15:13 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52691F41.1030900@ti.com \
--to=t-kristo@ti.com \
--cc=archit@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.