* [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override @ 2013-10-30 13:41 Gary Thomas 2013-10-30 14:06 ` Eric Nelson 2013-10-30 14:10 ` Otavio Salvador 0 siblings, 2 replies; 16+ messages in thread From: Gary Thomas @ 2013-10-30 13:41 UTC (permalink / raw) To: meta-freescale This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version. Signed-off-by: Gary Thomas <gary@mlbassoc.com> --- conf/machine/nitrogen6x.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/machine/nitrogen6x.conf b/conf/machine/nitrogen6x.conf index dbf31c5..b292d75 100644 --- a/conf/machine/nitrogen6x.conf +++ b/conf/machine/nitrogen6x.conf @@ -33,7 +33,7 @@ include conf/machine/include/tune-cortexa9.inc SOC_FAMILY = "mx6:mx6q" PREFERRED_PROVIDER_u-boot = "u-boot-boundary" -PREFERRED_PROVIDER_virtual/kernel = "linux-boundary" +PREFERRED_PROVIDER_virtual/kernel ?= "linux-boundary" # Use SPI NOR U-Boot by default IMAGE_BOOTLOADER ?= "" -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 13:41 [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override Gary Thomas @ 2013-10-30 14:06 ` Eric Nelson 2013-10-30 14:10 ` Otavio Salvador 1 sibling, 0 replies; 16+ messages in thread From: Eric Nelson @ 2013-10-30 14:06 UTC (permalink / raw) To: Gary Thomas, meta-freescale On 10/30/2013 06:41 AM, Gary Thomas wrote: > This change lets the user override the choice of kernel in local.conf > Without it, there is no way to build any kernel, e.g. linux-imx, other > than the linux-boundary version. > > Signed-off-by: Gary Thomas <gary@mlbassoc.com> > --- > conf/machine/nitrogen6x.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/conf/machine/nitrogen6x.conf b/conf/machine/nitrogen6x.conf > index dbf31c5..b292d75 100644 > --- a/conf/machine/nitrogen6x.conf > +++ b/conf/machine/nitrogen6x.conf > @@ -33,7 +33,7 @@ include conf/machine/include/tune-cortexa9.inc > SOC_FAMILY = "mx6:mx6q" > PREFERRED_PROVIDER_u-boot = "u-boot-boundary" > -PREFERRED_PROVIDER_virtual/kernel = "linux-boundary" > +PREFERRED_PROVIDER_virtual/kernel ?= "linux-boundary" > # Use SPI NOR U-Boot by default > IMAGE_BOOTLOADER ?= "" Good catch Gary. I would warn folks that there are known omissions in the SABRE Lite code and no Nitrogen6X support in the other trees, but you should absolutely be able to override this, especially to use a custom tree, so... Acked-by: Eric Nelson <eric.nelson@boundarydevices.com> ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 13:41 [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override Gary Thomas 2013-10-30 14:06 ` Eric Nelson @ 2013-10-30 14:10 ` Otavio Salvador 2013-10-30 14:25 ` Eric Nelson 2013-10-30 14:25 ` Gary Thomas 1 sibling, 2 replies; 16+ messages in thread From: Otavio Salvador @ 2013-10-30 14:10 UTC (permalink / raw) To: Gary Thomas, Eric Nelson; +Cc: meta-freescale@yoctoproject.org On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: > This change lets the user override the choice of kernel in local.conf > Without it, there is no way to build any kernel, e.g. linux-imx, other > than the linux-boundary version. > > Signed-off-by: Gary Thomas <gary@mlbassoc.com> I really dislike this. I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there. If we start allow all kind of override in machine configuration it loses its meaning and complicates the support. Eric? comments? -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 14:10 ` Otavio Salvador @ 2013-10-30 14:25 ` Eric Nelson 2013-10-30 14:28 ` Otavio Salvador 2013-10-30 14:25 ` Gary Thomas 1 sibling, 1 reply; 16+ messages in thread From: Eric Nelson @ 2013-10-30 14:25 UTC (permalink / raw) To: Otavio Salvador, Gary Thomas; +Cc: meta-freescale@yoctoproject.org Hi Otavio, On 10/30/2013 07:10 AM, Otavio Salvador wrote: > On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >> This change lets the user override the choice of kernel in local.conf >> Without it, there is no way to build any kernel, e.g. linux-imx, other >> than the linux-boundary version. >> >> Signed-off-by: Gary Thomas <gary@mlbassoc.com> > > I really dislike this. > > I understand your need, and it is a valid one, but it'd be better you > to make a new machine (which includes this one) and override it there. > I'm not sure I understand why. It seems perfectly reasonable to me to build a new kernel recipe and use it, while retaining other information from the machine configuration. I'm thinking specifically of a user who may have a custom kernel tree with pin-muxing based on their usage. > If we start allow all kind of override in machine configuration it > loses its meaning and complicates the support. > > Eric? comments? > I'm not sure I understand the concern. This seems pretty straightforward. The default is there, but a user can over-ride it. Regards, Eric ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 14:25 ` Eric Nelson @ 2013-10-30 14:28 ` Otavio Salvador 2013-10-30 14:42 ` Eric Nelson 0 siblings, 1 reply; 16+ messages in thread From: Otavio Salvador @ 2013-10-30 14:28 UTC (permalink / raw) To: Eric Nelson; +Cc: meta-freescale@yoctoproject.org Hello Eric, On Wed, Oct 30, 2013 at 12:25 PM, Eric Nelson <eric.nelson@boundarydevices.com> wrote: > On 10/30/2013 07:10 AM, Otavio Salvador wrote: >> >> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>> >>> This change lets the user override the choice of kernel in local.conf >>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>> than the linux-boundary version. >>> >>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >> >> >> I really dislike this. >> >> I understand your need, and it is a valid one, but it'd be better you >> to make a new machine (which includes this one) and override it there. >> > > I'm not sure I understand why. It seems perfectly reasonable to me > to build a new kernel recipe and use it, while retaining other > information from the machine configuration. > > I'm thinking specifically of a user who may have a custom kernel > tree with pin-muxing based on their usage. I see the point and I do have this case internally here; the point is if we have it 'soft' and someone reports: Nitrogen6X is not working. Next question needs to be, are you using linux-boundary or another? >> If we start allow all kind of override in machine configuration it >> loses its meaning and complicates the support. >> >> Eric? comments? >> > > I'm not sure I understand the concern. This seems pretty > straightforward. The default is there, but a user can > over-ride it. If user forks the kernel, adding a machine .conf file is the easiest part of it. I'd to avoid support uncertainty regarding settings. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 14:28 ` Otavio Salvador @ 2013-10-30 14:42 ` Eric Nelson 0 siblings, 0 replies; 16+ messages in thread From: Eric Nelson @ 2013-10-30 14:42 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org Hi Otavio, On 10/30/2013 07:28 AM, Otavio Salvador wrote: > Hello Eric, > > On Wed, Oct 30, 2013 at 12:25 PM, Eric Nelson > <eric.nelson@boundarydevices.com> wrote: >> On 10/30/2013 07:10 AM, Otavio Salvador wrote: >>> >>> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>>> >>>> This change lets the user override the choice of kernel in local.conf >>>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>>> than the linux-boundary version. >>>> >>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >>> >>> >>> I really dislike this. >>> >>> I understand your need, and it is a valid one, but it'd be better you >>> to make a new machine (which includes this one) and override it there. >>> >> >> I'm not sure I understand why. It seems perfectly reasonable to me >> to build a new kernel recipe and use it, while retaining other >> information from the machine configuration. >> >> I'm thinking specifically of a user who may have a custom kernel >> tree with pin-muxing based on their usage. > > I see the point and I do have this case internally here; the point is > if we have it 'soft' and someone reports: > > Nitrogen6X is not working. Next question needs to be, are you using > linux-boundary or another? > I understand your point, but it's going to happen anyway. The beauty (and curse) of flexible hardware is that it's flexible ;) I think the best we can hope for in terms of support is to always ask if a failure occurs with a "stock" build... Fresh "repo sync", specified U-Boot, et cetera. I don't know if hard-coding this value will meaningfully change things. >>> If we start allow all kind of override in machine configuration it >>> loses its meaning and complicates the support. >>> >>> Eric? comments? >>> >> >> I'm not sure I understand the concern. This seems pretty >> straightforward. The default is there, but a user can >> over-ride it. > > If user forks the kernel, adding a machine .conf file is the easiest > part of it. I'd to avoid support uncertainty regarding settings. > That's true, too (machine configurations aren't very complicated), but my understanding of that is recent. Regards, Eric ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 14:10 ` Otavio Salvador 2013-10-30 14:25 ` Eric Nelson @ 2013-10-30 14:25 ` Gary Thomas 2013-10-30 14:33 ` Otavio Salvador 1 sibling, 1 reply; 16+ messages in thread From: Gary Thomas @ 2013-10-30 14:25 UTC (permalink / raw) To: Otavio Salvador, Eric Nelson; +Cc: meta-freescale@yoctoproject.org On 2013-10-30 08:10, Otavio Salvador wrote: > On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >> This change lets the user override the choice of kernel in local.conf >> Without it, there is no way to build any kernel, e.g. linux-imx, other >> than the linux-boundary version. >> >> Signed-off-by: Gary Thomas <gary@mlbassoc.com> > > I really dislike this. > > I understand your need, and it is a valid one, but it'd be better you > to make a new machine (which includes this one) and override it there. Even if I did that (and I have), if I include this config file, I can never override this setting in a soft (user settable) way. > If we start allow all kind of override in machine configuration it > loses its meaning and complicates the support. > > Eric? comments? > Eric has already approved this change. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 14:25 ` Gary Thomas @ 2013-10-30 14:33 ` Otavio Salvador 2013-10-30 14:44 ` Gary Thomas 0 siblings, 1 reply; 16+ messages in thread From: Otavio Salvador @ 2013-10-30 14:33 UTC (permalink / raw) To: Gary Thomas; +Cc: meta-freescale@yoctoproject.org On Wed, Oct 30, 2013 at 12:25 PM, Gary Thomas <gary@mlbassoc.com> wrote: > On 2013-10-30 08:10, Otavio Salvador wrote: >> >> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>> >>> This change lets the user override the choice of kernel in local.conf >>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>> than the linux-boundary version. >>> >>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >> >> >> I really dislike this. >> >> I understand your need, and it is a valid one, but it'd be better you >> to make a new machine (which includes this one) and override it there. > > Even if I did that (and I have), if I include this config file, I can > never override this setting in a soft (user settable) way. Then you can force it in your machine. >> If we start allow all kind of override in machine configuration it >> loses its meaning and complicates the support. >> >> Eric? comments? >> > > Eric has already approved this change. This is not up to me but I'd like to discuss it a little bit further before merging it... My main concern about this is the support. As I said it is a valid use-case but /most/ people will end with a .conf for the custom settings in the end with their internal fork or so. Do it in local.conf or environment is not advised as it is easy to be forgotten or do wrong so for every product it is better to have a .conf in case it needs specific kernel/u-boot patches. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 14:33 ` Otavio Salvador @ 2013-10-30 14:44 ` Gary Thomas 2013-10-30 16:01 ` Otavio Salvador 0 siblings, 1 reply; 16+ messages in thread From: Gary Thomas @ 2013-10-30 14:44 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org On 2013-10-30 08:33, Otavio Salvador wrote: > On Wed, Oct 30, 2013 at 12:25 PM, Gary Thomas <gary@mlbassoc.com> wrote: >> On 2013-10-30 08:10, Otavio Salvador wrote: >>> >>> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>>> >>>> This change lets the user override the choice of kernel in local.conf >>>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>>> than the linux-boundary version. >>>> >>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >>> >>> >>> I really dislike this. >>> >>> I understand your need, and it is a valid one, but it'd be better you >>> to make a new machine (which includes this one) and override it there. >> >> Even if I did that (and I have), if I include this config file, I can >> never override this setting in a soft (user settable) way. > > Then you can force it in your machine. > >>> If we start allow all kind of override in machine configuration it >>> loses its meaning and complicates the support. >>> >>> Eric? comments? >>> >> >> Eric has already approved this change. > > This is not up to me but I'd like to discuss it a little bit further > before merging it... > > My main concern about this is the support. As I said it is a valid > use-case but /most/ people will end with a .conf for the custom > settings in the end with their internal fork or so. Do it in > local.conf or environment is not advised as it is easy to be forgotten > or do wrong so for every product it is better to have a .conf in case > it needs specific kernel/u-boot patches. > A reasonable concern. I do note that having this be soft in <MACHINE>.conf seems to be common practice in the rest of the Yocto world. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 14:44 ` Gary Thomas @ 2013-10-30 16:01 ` Otavio Salvador 2013-10-30 16:16 ` Eric Nelson 2013-10-30 16:56 ` Daiane Angolini 0 siblings, 2 replies; 16+ messages in thread From: Otavio Salvador @ 2013-10-30 16:01 UTC (permalink / raw) To: Gary Thomas; +Cc: meta-freescale@yoctoproject.org On Wed, Oct 30, 2013 at 12:44 PM, Gary Thomas <gary@mlbassoc.com> wrote: > On 2013-10-30 08:33, Otavio Salvador wrote: >> >> On Wed, Oct 30, 2013 at 12:25 PM, Gary Thomas <gary@mlbassoc.com> wrote: >>> >>> On 2013-10-30 08:10, Otavio Salvador wrote: >>>> >>>> >>>> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>> >>>>> >>>>> This change lets the user override the choice of kernel in local.conf >>>>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>>>> than the linux-boundary version. >>>>> >>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >>>> >>>> >>>> >>>> I really dislike this. >>>> >>>> I understand your need, and it is a valid one, but it'd be better you >>>> to make a new machine (which includes this one) and override it there. >>> >>> >>> Even if I did that (and I have), if I include this config file, I can >>> never override this setting in a soft (user settable) way. >> >> >> Then you can force it in your machine. >> >>>> If we start allow all kind of override in machine configuration it >>>> loses its meaning and complicates the support. >>>> >>>> Eric? comments? >>>> >>> >>> Eric has already approved this change. >> >> >> This is not up to me but I'd like to discuss it a little bit further >> before merging it... >> >> My main concern about this is the support. As I said it is a valid >> use-case but /most/ people will end with a .conf for the custom >> settings in the end with their internal fork or so. Do it in >> local.conf or environment is not advised as it is easy to be forgotten >> or do wrong so for every product it is better to have a .conf in case >> it needs specific kernel/u-boot patches. >> > > A reasonable concern. I do note that having this be soft in <MACHINE>.conf > seems to be common practice in the rest of the Yocto world. Ok; you guys won :-) I applied it to dora and master (I manually applied it as it has not applied cleanly). Eric, please, if you have time do the same change in nitrogen6x-lite so it is kept in sync. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 16:01 ` Otavio Salvador @ 2013-10-30 16:16 ` Eric Nelson 2013-10-30 16:56 ` Daiane Angolini 1 sibling, 0 replies; 16+ messages in thread From: Eric Nelson @ 2013-10-30 16:16 UTC (permalink / raw) To: Otavio Salvador, Gary Thomas; +Cc: meta-freescale@yoctoproject.org On 10/30/2013 09:01 AM, Otavio Salvador wrote: > On Wed, Oct 30, 2013 at 12:44 PM, Gary Thomas <gary@mlbassoc.com> wrote: >> On 2013-10-30 08:33, Otavio Salvador wrote: >>> On Wed, Oct 30, 2013 at 12:25 PM, Gary Thomas <gary@mlbassoc.com> wrote: >>>> On 2013-10-30 08:10, Otavio Salvador wrote: >>>>> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>>> >>>>>> This change lets the user override the choice of kernel in local.conf >>>>>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>>>>> than the linux-boundary version. >>>>>> >>>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >>>>> >>>>> I really dislike this. >>>>> >>>>> I understand your need, and it is a valid one, but it'd be better you >>>>> to make a new machine (which includes this one) and override it there. >>>> >>>> Even if I did that (and I have), if I include this config file, I can >>>> never override this setting in a soft (user settable) way. >>> >>> Then you can force it in your machine. >>> >>>>> If we start allow all kind of override in machine configuration it >>>>> loses its meaning and complicates the support. >>>>> >>>>> Eric? comments? >>>>> >>>> Eric has already approved this change. >>> >>> This is not up to me but I'd like to discuss it a little bit further >>> before merging it... >>> >>> My main concern about this is the support. As I said it is a valid >>> use-case but /most/ people will end with a .conf for the custom >>> settings in the end with their internal fork or so. Do it in >>> local.conf or environment is not advised as it is easy to be forgotten >>> or do wrong so for every product it is better to have a .conf in case >>> it needs specific kernel/u-boot patches. >> >> A reasonable concern. I do note that having this be soft in <MACHINE>.conf >> seems to be common practice in the rest of the Yocto world. > > Ok; you guys won :-) > > I applied it to dora and master (I manually applied it as it has not > applied cleanly). > > Eric, please, if you have time do the same change in nitrogen6x-lite > so it is kept in sync. > Will do. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 16:01 ` Otavio Salvador 2013-10-30 16:16 ` Eric Nelson @ 2013-10-30 16:56 ` Daiane Angolini 2013-10-30 17:29 ` Otavio Salvador 1 sibling, 1 reply; 16+ messages in thread From: Daiane Angolini @ 2013-10-30 16:56 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org On Wed, Oct 30, 2013 at 2:01 PM, Otavio Salvador <otavio@ossystems.com.br> wrote: > On Wed, Oct 30, 2013 at 12:44 PM, Gary Thomas <gary@mlbassoc.com> wrote: >> On 2013-10-30 08:33, Otavio Salvador wrote: >>> >>> On Wed, Oct 30, 2013 at 12:25 PM, Gary Thomas <gary@mlbassoc.com> wrote: >>>> >>>> On 2013-10-30 08:10, Otavio Salvador wrote: >>>>> >>>>> >>>>> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>>> >>>>>> >>>>>> This change lets the user override the choice of kernel in local.conf >>>>>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>>>>> than the linux-boundary version. >>>>>> >>>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >>>>> >>>>> >>>>> >>>>> I really dislike this. >>>>> >>>>> I understand your need, and it is a valid one, but it'd be better you >>>>> to make a new machine (which includes this one) and override it there. >>>> >>>> >>>> Even if I did that (and I have), if I include this config file, I can >>>> never override this setting in a soft (user settable) way. >>> >>> >>> Then you can force it in your machine. >>> >>>>> If we start allow all kind of override in machine configuration it >>>>> loses its meaning and complicates the support. >>>>> >>>>> Eric? comments? >>>>> >>>> >>>> Eric has already approved this change. >>> >>> >>> This is not up to me but I'd like to discuss it a little bit further >>> before merging it... >>> >>> My main concern about this is the support. As I said it is a valid >>> use-case but /most/ people will end with a .conf for the custom >>> settings in the end with their internal fork or so. Do it in >>> local.conf or environment is not advised as it is easy to be forgotten >>> or do wrong so for every product it is better to have a .conf in case >>> it needs specific kernel/u-boot patches. >>> >> >> A reasonable concern. I do note that having this be soft in <MACHINE>.conf >> seems to be common practice in the rest of the Yocto world. > > Ok; you guys won :-) > > I applied it to dora and master (I manually applied it as it has not > applied cleanly). > > Eric, please, if you have time do the same change in nitrogen6x-lite > so it is kept in sync. I do agree with both sides. But I think you didn´t presented the complete set of possibilities. I mean, it´s not a "support" X "flexibility" fight. If nitrogen-any deserves to be flexible, so all other deserves it the same way. If it´s "wrong" for one board. It´s "wrong" for any. So, please submit the patch to fix all/every board. As I really don´t have an strong position for this. I would say, let´s change and see what´s happens. For support nightmare, we always need to say what is u-boot/kernel/yocto problem in this ML, so the nightmare is already here. But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora. Daiane > > -- > Otavio Salvador O.S. Systems > http://www.ossystems.com.br http://code.ossystems.com.br > Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 16:56 ` Daiane Angolini @ 2013-10-30 17:29 ` Otavio Salvador 2013-10-30 17:46 ` Eric Nelson 0 siblings, 1 reply; 16+ messages in thread From: Otavio Salvador @ 2013-10-30 17:29 UTC (permalink / raw) To: Daiane Angolini; +Cc: meta-freescale@yoctoproject.org On Wed, Oct 30, 2013 at 2:56 PM, Daiane Angolini <daiane.list@gmail.com> wrote: > On Wed, Oct 30, 2013 at 2:01 PM, Otavio Salvador > <otavio@ossystems.com.br> wrote: >> On Wed, Oct 30, 2013 at 12:44 PM, Gary Thomas <gary@mlbassoc.com> wrote: >>> On 2013-10-30 08:33, Otavio Salvador wrote: >>>> >>>> On Wed, Oct 30, 2013 at 12:25 PM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>> >>>>> On 2013-10-30 08:10, Otavio Salvador wrote: >>>>>> >>>>>> >>>>>> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>>>> >>>>>>> >>>>>>> This change lets the user override the choice of kernel in local.conf >>>>>>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>>>>>> than the linux-boundary version. >>>>>>> >>>>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >>>>>> >>>>>> >>>>>> >>>>>> I really dislike this. >>>>>> >>>>>> I understand your need, and it is a valid one, but it'd be better you >>>>>> to make a new machine (which includes this one) and override it there. >>>>> >>>>> >>>>> Even if I did that (and I have), if I include this config file, I can >>>>> never override this setting in a soft (user settable) way. >>>> >>>> >>>> Then you can force it in your machine. >>>> >>>>>> If we start allow all kind of override in machine configuration it >>>>>> loses its meaning and complicates the support. >>>>>> >>>>>> Eric? comments? >>>>>> >>>>> >>>>> Eric has already approved this change. >>>> >>>> >>>> This is not up to me but I'd like to discuss it a little bit further >>>> before merging it... >>>> >>>> My main concern about this is the support. As I said it is a valid >>>> use-case but /most/ people will end with a .conf for the custom >>>> settings in the end with their internal fork or so. Do it in >>>> local.conf or environment is not advised as it is easy to be forgotten >>>> or do wrong so for every product it is better to have a .conf in case >>>> it needs specific kernel/u-boot patches. >>>> >>> >>> A reasonable concern. I do note that having this be soft in <MACHINE>.conf >>> seems to be common practice in the rest of the Yocto world. >> >> Ok; you guys won :-) >> >> I applied it to dora and master (I manually applied it as it has not >> applied cleanly). >> >> Eric, please, if you have time do the same change in nitrogen6x-lite >> so it is kept in sync. > > I do agree with both sides. But I think you didn´t presented the > complete set of possibilities. I mean, it´s not a "support" X > "flexibility" fight. > > If nitrogen-any deserves to be flexible, so all other deserves it the same way. > > If it´s "wrong" for one board. It´s "wrong" for any. So, please submit > the patch to fix all/every board. Agreed here. > As I really don´t have an strong position for this. I would say, let´s > change and see what´s happens. > > For support nightmare, we always need to say what is > u-boot/kernel/yocto problem in this ML, so the nightmare is already > here. :-( > But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora. Yes I agree it is not a bugfix but I think that it'd be better to be consistent with dora and master at this point. Most people will keep using dora for a while and it'd be better to have this deplyed now than see how it goes in 1.6 only. Comments? -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 17:29 ` Otavio Salvador @ 2013-10-30 17:46 ` Eric Nelson 2013-10-30 17:51 ` Otavio Salvador 2013-10-30 18:04 ` Gary Thomas 0 siblings, 2 replies; 16+ messages in thread From: Eric Nelson @ 2013-10-30 17:46 UTC (permalink / raw) To: Otavio Salvador, Daiane Angolini; +Cc: meta-freescale@yoctoproject.org Hi Otavio, On 10/30/2013 10:29 AM, Otavio Salvador wrote: > On Wed, Oct 30, 2013 at 2:56 PM, Daiane Angolini <daiane.list@gmail.com> wrote: >> On Wed, Oct 30, 2013 at 2:01 PM, Otavio Salvador >> <otavio@ossystems.com.br> wrote: >>> On Wed, Oct 30, 2013 at 12:44 PM, Gary Thomas <gary@mlbassoc.com> wrote: >>>> On 2013-10-30 08:33, Otavio Salvador wrote: >>>>> On Wed, Oct 30, 2013 at 12:25 PM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>>> On 2013-10-30 08:10, Otavio Salvador wrote: >>>>>>> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>>>>> >>>>>>>> This change lets the user override the choice of kernel in local.conf >>>>>>>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>>>>>>> than the linux-boundary version. >>>>>>>> >>>>>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >>>>>>> >> >> <snip> >> >> I do agree with both sides. But I think you didn´t presented the >> complete set of possibilities. I mean, it´s not a "support" X >> "flexibility" fight. >> >> If nitrogen-any deserves to be flexible, so all other deserves it the same way. >> >> If it´s "wrong" for one board. It´s "wrong" for any. So, please submit >> the patch to fix all/every board. > > Agreed here. > Works for me. Gary, do you want to take the patch? Otavio asked me 'cause he was asking about our board... >> As I really don´t have an strong position for this. I would say, let´s >> change and see what´s happens. >> >> For support nightmare, we always need to say what is >> u-boot/kernel/yocto problem in this ML, so the nightmare is already >> here. > > :-( > Aww, it's not a nightmare. It's a jobs program ;) >> But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora. > > Yes I agree it is not a bugfix but I think that it'd be better to be > consistent with dora and master at this point. Most people will keep > using dora for a while and it'd be better to have this deplyed now > than see how it goes in 1.6 only. > > Comments? > Gary, did you ever think a single question mark would prompt so much discussion? I wish we had a clean "MAKEALL" to make sure nothing breaks, but that seems unlikely. Regards, Eric ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 17:46 ` Eric Nelson @ 2013-10-30 17:51 ` Otavio Salvador 2013-10-30 18:04 ` Gary Thomas 1 sibling, 0 replies; 16+ messages in thread From: Otavio Salvador @ 2013-10-30 17:51 UTC (permalink / raw) To: Eric Nelson; +Cc: meta-freescale@yoctoproject.org Hello, On Wed, Oct 30, 2013 at 3:46 PM, Eric Nelson <eric.nelson@boundarydevices.com> wrote: > On 10/30/2013 10:29 AM, Otavio Salvador wrote: >> On Wed, Oct 30, 2013 at 2:56 PM, Daiane Angolini <daiane.list@gmail.com> >> wrote: >>> But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora. >> >> >> Yes I agree it is not a bugfix but I think that it'd be better to be >> consistent with dora and master at this point. Most people will keep >> using dora for a while and it'd be better to have this deplyed now >> than see how it goes in 1.6 only. >> >> Comments? >> > > Gary, did you ever think a single question mark would prompt so much > discussion? The 'question mark' has a very strong meaning in 'bitbake-language'. > I wish we had a clean "MAKEALL" to make sure nothing breaks, but that > seems unlikely. I do build /all/ board weekly :-) I look for help here ;-) -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override 2013-10-30 17:46 ` Eric Nelson 2013-10-30 17:51 ` Otavio Salvador @ 2013-10-30 18:04 ` Gary Thomas 1 sibling, 0 replies; 16+ messages in thread From: Gary Thomas @ 2013-10-30 18:04 UTC (permalink / raw) To: meta-freescale On 2013-10-30 11:46, Eric Nelson wrote: > Hi Otavio, > > On 10/30/2013 10:29 AM, Otavio Salvador wrote: >> On Wed, Oct 30, 2013 at 2:56 PM, Daiane Angolini <daiane.list@gmail.com> wrote: >>> On Wed, Oct 30, 2013 at 2:01 PM, Otavio Salvador >>> <otavio@ossystems.com.br> wrote: >>>> On Wed, Oct 30, 2013 at 12:44 PM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>> On 2013-10-30 08:33, Otavio Salvador wrote: >>>>>> On Wed, Oct 30, 2013 at 12:25 PM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>>>> On 2013-10-30 08:10, Otavio Salvador wrote: >>>>>>>> On Wed, Oct 30, 2013 at 11:41 AM, Gary Thomas <gary@mlbassoc.com> wrote: >>>>>>>>> >>>>>>>>> This change lets the user override the choice of kernel in local.conf >>>>>>>>> Without it, there is no way to build any kernel, e.g. linux-imx, other >>>>>>>>> than the linux-boundary version. >>>>>>>>> >>>>>>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >>>>>>>> >>> >>> <snip> >>> >>> I do agree with both sides. But I think you didn´t presented the >>> complete set of possibilities. I mean, it´s not a "support" X >>> "flexibility" fight. >>> >>> If nitrogen-any deserves to be flexible, so all other deserves it the same way. >>> >>> If it´s "wrong" for one board. It´s "wrong" for any. So, please submit >>> the patch to fix all/every board. >> >> Agreed here. >> > Works for me. > > Gary, do you want to take the patch? Otavio asked me 'cause he > was asking about our board... Sure, I'll take this on for all the boards in meta-fsl-arm-* Look for it later today or tomorrow. > >>> As I really don´t have an strong position for this. I would say, let´s >>> change and see what´s happens. >>> >>> For support nightmare, we always need to say what is >>> u-boot/kernel/yocto problem in this ML, so the nightmare is already >>> here. >> >> :-( >> > > Aww, it's not a nightmare. It's a jobs program ;) > >>> But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora. >> >> Yes I agree it is not a bugfix but I think that it'd be better to be >> consistent with dora and master at this point. Most people will keep >> using dora for a while and it'd be better to have this deplyed now >> than see how it goes in 1.6 only. >> >> Comments? >> > > Gary, did you ever think a single question mark would prompt so much > discussion? Not unlike the recent headline "Single bit error in Toyota firmware kills ..." > > I wish we had a clean "MAKEALL" to make sure nothing breaks, but that > seems unlikely. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2013-10-30 18:04 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-10-30 13:41 [meta-fsl-arm-extra][PATCH] nitrogen6x.conf: Allow kernel provider override Gary Thomas 2013-10-30 14:06 ` Eric Nelson 2013-10-30 14:10 ` Otavio Salvador 2013-10-30 14:25 ` Eric Nelson 2013-10-30 14:28 ` Otavio Salvador 2013-10-30 14:42 ` Eric Nelson 2013-10-30 14:25 ` Gary Thomas 2013-10-30 14:33 ` Otavio Salvador 2013-10-30 14:44 ` Gary Thomas 2013-10-30 16:01 ` Otavio Salvador 2013-10-30 16:16 ` Eric Nelson 2013-10-30 16:56 ` Daiane Angolini 2013-10-30 17:29 ` Otavio Salvador 2013-10-30 17:46 ` Eric Nelson 2013-10-30 17:51 ` Otavio Salvador 2013-10-30 18:04 ` Gary Thomas
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.