Re: [PATCH] drm/radeon/audio: fix missing multichannel PCM SAD in some cases

From: Anssi Hannula <anssi.hannula@iki.fi>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/radeon/audio: fix missing multichannel PCM SAD in some cases
Date: Sat, 02 Nov 2013 03:08:10 +0200	[thread overview]
Message-ID: <5274507A.707@iki.fi> (raw)
In-Reply-To: <CACna6ryJjHJwu7_=rHfff8f8=f3BFEDrDcKgx-kTEofoJDn3Fg@mail.gmail.com>

02.11.2013 03:01, Rafał Miłecki kirjoitti:
> 2013/10/29 Anssi Hannula <anssi.hannula@iki.fi>:
>> Fix the code to pick the PCM SAD with the highest number of channels,
>> while merging the rate masks of PCM SADs with lower amount of channels
>> into the additional stereo rate mask byte.
> 
> Don't you think that we should use SUPPORTED_FREQUENCIES_STEREO for
> stereo frequencies only?
> 
> 
>>                                 if (sad->format == HDMI_AUDIO_CODING_TYPE_PCM)
>> +                                       stereo_freqs |= sad->freq;
> 
> I mean making that (... && sad->channels == 1)
> 

SAD with channels=6,freqs=32..96kHz,bits=16..24 implies that those freqs
and bps are supported for all channel counts up to 6 (since it is "Max
Number of channels"). Therefore the specified rates are supported in
stereo mode as well and I believe should be included in the stereo bitmask.

As per AMD HDA Verbs documentation the 4th byte is "Rates supported for
stereo". And since those rates _are_ supported by stereo, IMO they
should be there.

-- 
Anssi Hannula
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel