Re: [PATCH v3 0/5] ALSA: hda - hdmi: ATI/AMD multi-channel and HBR support

[Anssi Hannula <anssi.hannula@iki.fi>]

[-- Attachment #1: Type: text/plain, Size: 2474 bytes --]

08.11.2013 23:28, Olivier Langlois kirjoitti:
> On Fri, 2013-11-08 at 13:17 -0500, Olivier Langlois wrote:
>>>>
>>>> What is sound-next? A git branch? Where can I get it?
>>>
>>> The sound tree is at:
>>> https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/
>>>
>>> You can use the master branch now, it has been merged there.
>>>
>> I'm no git expert but I had problem cloning the repository:
>>
>> lano1106@whippet2 ~/dev $ git clone
>> https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/
>> Cloning into 'sound'...
>> error: Unable to find 97c4de8fc0a47b99220b1209c7457c7dde05637a under
>> https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git
>> Cannot obtain needed object 97c4de8fc0a47b99220b1209c7457c7dde05637a
>> while processing commit ff8c5075a3b474cd9e422eb7e5a97e48f38a9b08.

That is just a web URL, in there you can see the checkoutable URL:
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

>>
>> but I did cherrypicked successfully hda_codec,hda_jack,hda_eld and
>> patch_hdmi modules from the browser interface of the repo and 3.11.7 did
>> compile fine.

You mean you just downloaded the files and put them in-tree, right?

If it built without warnings, it is probably OK...

>> I'll probably be able to report the testing of your patch sometime later
>> this afternoon.
>>
> Hi Anssi,
> 
> here is initial result of my testing of v3 of your patch.
> 
> Either my backporting missed something or a regression has slipped into
> the newest version but speaker mapping looks slightly broken. I have
> this:
> 
> lano1106@whippet2 ~ $ speaker-test -D hdmi:CARD=HDMI,DEV=0 -c8 -r192000
> -F S32_LE
> 
> speaker-test 1.0.27.2
> 
> Playback device is hdmi:CARD=HDMI,DEV=0
> Stream parameters are 192000Hz, S32_LE, 8 channels
> Using 16 octaves of pink noise
> Rate set to 192000Hz (requested 192000Hz)
> Buffer size range from 8 to 131072
> Period size range from 4 to 65536
> Using max buffer size 131072
> Periods = 4
> was set period_size = 32768
> was set buffer_size = 131072
>  0 - Front Left
>  4 - Center
>  1 - Front Right
>  7 - Side Right
>  7 - Side Right
>  6 - Side Left
>  6 - Side Left
>  5 - LFE
> 
> With v2, rear channels were there.

OK, this is pretty weird indeed. Could you apply the attached debugging
prints and then provide dmesg?


> Codec: ATI R6xx HDMI
> Address: 0
> AFG Function Id: 0x1 (unsol 0)
> Vendor Id: 0x1002aa01
> Subsystem Id: 0x00aa0100
> Revision Id: 0x100300


-- 
Anssi Hannula

[-- Attachment #2: chmap-hdmi-debug.patch --]
[-- Type: text/x-patch, Size: 647 bytes --]

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index a96403a828af..2dc47c53d379 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -878,9 +878,13 @@ static void hdmi_setup_fake_chmap(unsigned char *map, int ca)
 {
 	int i;
 	int ordered_ca = get_channel_allocation_order(ca);
+	printk(KERN_INFO "CA XX %d => %d\n", ca, ordered_ca);
 	for (i = 0; i < 8; i++) {
 		if (i < channel_allocations[ordered_ca].channels)
+		{
+			printk(KERN_INFO "XX hdmi_map %02x\n", hdmi_channel_mapping[ca][i]);
 			map[i] = from_cea_slot(ordered_ca, hdmi_channel_mapping[ca][i] & 0x0f);
+		}
 		else
 			map[i] = 0;
 	}

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]