[PATCH] hexagon: kernel: kgdb: include related header for pass compiling.

[PATCH] hexagon: kernel: kgdb: include related header for pass compiling.

[Chen Gang]

Need include related headers for pass compiling, the related error
(with allmodconfig for v4):

    CC      arch/hexagon/kernel/kgdb.o
  arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'
  arch/hexagon/kernel/kgdb.c:31: error: invalid use of undefined type 'struct pt_regs'
  ...
  arch/hexagon/kernel/kgdb.c:220: error: implicit declaration of function 'local_irq_save'
  arch/hexagon/kernel/kgdb.c:222: error: implicit declaration of function 'local_irq_restore'
  ...


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 arch/hexagon/kernel/kgdb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/hexagon/kernel/kgdb.c b/arch/hexagon/kernel/kgdb.c
index 82d5c25..038580c 100644
--- a/arch/hexagon/kernel/kgdb.c
+++ b/arch/hexagon/kernel/kgdb.c
@@ -18,6 +18,8 @@
  * 02110-1301, USA.
  */
 
+#include <linux/irq.h>
+#include <linux/sched.h>
 #include <linux/kdebug.h>
 #include <linux/kgdb.h>
 
-- 
1.7.7.6

Re: [PATCH] hexagon: kernel: kgdb: include related header for pass compiling.

[Linas Vepstas]

On 1 November 2013 06:54, Chen Gang <gang.chen@asianux.com> wrote:
> Need include related headers for pass compiling, the related error
> (with allmodconfig for v4):
>
>     CC      arch/hexagon/kernel/kgdb.o
>   arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'

looks good to me

Acked-by: Linas Vepstas <linasvepstas@gmail.com>

Re: [PATCH] hexagon: kernel: kgdb: include related header for pass compiling.

[Chen Gang]

On 11/02/2013 01:16 AM, Linas Vepstas wrote:
> On 1 November 2013 06:54, Chen Gang <gang.chen@asianux.com> wrote:
>> Need include related headers for pass compiling, the related error
>> (with allmodconfig for v4):
>>
>>     CC      arch/hexagon/kernel/kgdb.o
>>   arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'
> 
> looks good to me
> 
> Acked-by: Linas Vepstas <linasvepstas@gmail.com>
> 
> 

Thanks.
-- 
Chen Gang

Re: [PATCH] hexagon: kernel: kgdb: include related header for pass compiling.

[rkuo]

On Fri, Nov 01, 2013 at 07:54:17PM +0800, Chen Gang wrote:
> Need include related headers for pass compiling, the related error
> (with allmodconfig for v4):
> 
>     CC      arch/hexagon/kernel/kgdb.o
>   arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'
>   arch/hexagon/kernel/kgdb.c:31: error: invalid use of undefined type 'struct pt_regs'
>   ...
>   arch/hexagon/kernel/kgdb.c:220: error: implicit declaration of function 'local_irq_save'
>   arch/hexagon/kernel/kgdb.c:222: error: implicit declaration of function 'local_irq_restore'
>   ...
> 
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  arch/hexagon/kernel/kgdb.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 

Thanks for the cleanup.  I can take these patches into my tree for my next
push, or they can go in one of the other tree.  In that case,

Acked-by: Richard Kuo <rkuo@codeaurora.org>


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

Re: [PATCH] hexagon: kernel: kgdb: include related header for pass compiling.

[Chen Gang]

On 11/04/2013 09:15 AM, rkuo wrote:
> On Fri, Nov 01, 2013 at 07:54:17PM +0800, Chen Gang wrote:
>> Need include related headers for pass compiling, the related error
>> (with allmodconfig for v4):
>>
>>     CC      arch/hexagon/kernel/kgdb.o
>>   arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'
>>   arch/hexagon/kernel/kgdb.c:31: error: invalid use of undefined type 'struct pt_regs'
>>   ...
>>   arch/hexagon/kernel/kgdb.c:220: error: implicit declaration of function 'local_irq_save'
>>   arch/hexagon/kernel/kgdb.c:222: error: implicit declaration of function 'local_irq_restore'
>>   ...
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>>  arch/hexagon/kernel/kgdb.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
> 
> Thanks for the cleanup.  I can take these patches into my tree for my next
> push, or they can go in one of the other tree.  In that case,
> 
> Acked-by: Richard Kuo <rkuo@codeaurora.org>
> 
> 

For me, both are OK.

Thanks.
-- 
Chen Gang