* [PATCH] hexagon: kernel: kgdb: include related header for pass compiling.
@ 2013-11-01 11:54 Chen Gang
2013-11-01 17:16 ` Linas Vepstas
2013-11-04 1:15 ` rkuo
0 siblings, 2 replies; 5+ messages in thread
From: Chen Gang @ 2013-11-01 11:54 UTC (permalink / raw)
To: Richard Kuo; +Cc: linux-hexagon
Need include related headers for pass compiling, the related error
(with allmodconfig for v4):
CC arch/hexagon/kernel/kgdb.o
arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'
arch/hexagon/kernel/kgdb.c:31: error: invalid use of undefined type 'struct pt_regs'
...
arch/hexagon/kernel/kgdb.c:220: error: implicit declaration of function 'local_irq_save'
arch/hexagon/kernel/kgdb.c:222: error: implicit declaration of function 'local_irq_restore'
...
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/hexagon/kernel/kgdb.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/hexagon/kernel/kgdb.c b/arch/hexagon/kernel/kgdb.c
index 82d5c25..038580c 100644
--- a/arch/hexagon/kernel/kgdb.c
+++ b/arch/hexagon/kernel/kgdb.c
@@ -18,6 +18,8 @@
* 02110-1301, USA.
*/
+#include <linux/irq.h>
+#include <linux/sched.h>
#include <linux/kdebug.h>
#include <linux/kgdb.h>
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] hexagon: kernel: kgdb: include related header for pass compiling.
2013-11-01 11:54 [PATCH] hexagon: kernel: kgdb: include related header for pass compiling Chen Gang
@ 2013-11-01 17:16 ` Linas Vepstas
2013-11-02 13:20 ` Chen Gang
2013-11-04 1:15 ` rkuo
1 sibling, 1 reply; 5+ messages in thread
From: Linas Vepstas @ 2013-11-01 17:16 UTC (permalink / raw)
To: Chen Gang; +Cc: Richard Kuo, linux-hexagon
On 1 November 2013 06:54, Chen Gang <gang.chen@asianux.com> wrote:
> Need include related headers for pass compiling, the related error
> (with allmodconfig for v4):
>
> CC arch/hexagon/kernel/kgdb.o
> arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'
looks good to me
Acked-by: Linas Vepstas <linasvepstas@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hexagon: kernel: kgdb: include related header for pass compiling.
2013-11-01 17:16 ` Linas Vepstas
@ 2013-11-02 13:20 ` Chen Gang
0 siblings, 0 replies; 5+ messages in thread
From: Chen Gang @ 2013-11-02 13:20 UTC (permalink / raw)
To: linasvepstas; +Cc: Richard Kuo, linux-hexagon
On 11/02/2013 01:16 AM, Linas Vepstas wrote:
> On 1 November 2013 06:54, Chen Gang <gang.chen@asianux.com> wrote:
>> Need include related headers for pass compiling, the related error
>> (with allmodconfig for v4):
>>
>> CC arch/hexagon/kernel/kgdb.o
>> arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'
>
> looks good to me
>
> Acked-by: Linas Vepstas <linasvepstas@gmail.com>
>
>
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hexagon: kernel: kgdb: include related header for pass compiling.
2013-11-01 11:54 [PATCH] hexagon: kernel: kgdb: include related header for pass compiling Chen Gang
2013-11-01 17:16 ` Linas Vepstas
@ 2013-11-04 1:15 ` rkuo
2013-11-04 1:45 ` Chen Gang
1 sibling, 1 reply; 5+ messages in thread
From: rkuo @ 2013-11-04 1:15 UTC (permalink / raw)
To: Chen Gang; +Cc: linux-hexagon
On Fri, Nov 01, 2013 at 07:54:17PM +0800, Chen Gang wrote:
> Need include related headers for pass compiling, the related error
> (with allmodconfig for v4):
>
> CC arch/hexagon/kernel/kgdb.o
> arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'
> arch/hexagon/kernel/kgdb.c:31: error: invalid use of undefined type 'struct pt_regs'
> ...
> arch/hexagon/kernel/kgdb.c:220: error: implicit declaration of function 'local_irq_save'
> arch/hexagon/kernel/kgdb.c:222: error: implicit declaration of function 'local_irq_restore'
> ...
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/hexagon/kernel/kgdb.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
Thanks for the cleanup. I can take these patches into my tree for my next
push, or they can go in one of the other tree. In that case,
Acked-by: Richard Kuo <rkuo@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hexagon: kernel: kgdb: include related header for pass compiling.
2013-11-04 1:15 ` rkuo
@ 2013-11-04 1:45 ` Chen Gang
0 siblings, 0 replies; 5+ messages in thread
From: Chen Gang @ 2013-11-04 1:45 UTC (permalink / raw)
To: rkuo; +Cc: linux-hexagon
On 11/04/2013 09:15 AM, rkuo wrote:
> On Fri, Nov 01, 2013 at 07:54:17PM +0800, Chen Gang wrote:
>> Need include related headers for pass compiling, the related error
>> (with allmodconfig for v4):
>>
>> CC arch/hexagon/kernel/kgdb.o
>> arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'
>> arch/hexagon/kernel/kgdb.c:31: error: invalid use of undefined type 'struct pt_regs'
>> ...
>> arch/hexagon/kernel/kgdb.c:220: error: implicit declaration of function 'local_irq_save'
>> arch/hexagon/kernel/kgdb.c:222: error: implicit declaration of function 'local_irq_restore'
>> ...
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>> arch/hexagon/kernel/kgdb.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>
> Thanks for the cleanup. I can take these patches into my tree for my next
> push, or they can go in one of the other tree. In that case,
>
> Acked-by: Richard Kuo <rkuo@codeaurora.org>
>
>
For me, both are OK.
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-04 1:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-01 11:54 [PATCH] hexagon: kernel: kgdb: include related header for pass compiling Chen Gang
2013-11-01 17:16 ` Linas Vepstas
2013-11-02 13:20 ` Chen Gang
2013-11-04 1:15 ` rkuo
2013-11-04 1:45 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.