From: Dave Hansen <dave@sr71.net>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dave.jiang@intel.com, Mel Gorman <mgorman@suse.de>,
akpm@linux-foundation.org, dhillf@gmail.com
Subject: Re: [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page
Date: Tue, 05 Nov 2013 10:47:03 -0800 [thread overview]
Message-ID: <52793D27.8050607@sr71.net> (raw)
In-Reply-To: <20131028221126.GA29431@shutemov.name>
On 10/28/2013 03:11 PM, Kirill A. Shutemov wrote:
> On Mon, Oct 28, 2013 at 03:16:20PM -0700, Dave Hansen wrote:
>> void copy_huge_page(struct page *dst, struct page *src)
>> {
>> struct hstate *h = page_hstate(src);
>> if (unlikely(pages_per_huge_page(h) > MAX_ORDER_NR_PAGES)) {
>> ...
>>
>> This patch creates a copy_high_order_page() which can
>> be used on THP pages.
>
> We already have copy_user_huge_page() and copy_user_gigantic_page() in
> generic code (mm/memory.c). I think copy_gigantic_page() and
> copy_huge_page() should be moved there too.
That would be fine I guesss... in another patch. :)
> BTW, I think pages_per_huge_page in copy_user_huge_page() is redunand:
> compound_order(page) should be enough, right?
The way it is now, the compiler can optimize for the !HUGETLBFS case.
Also, pages_per_huge_page() works for gigantic pages. compound_order()
wouldn't work for those.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dave.jiang@intel.com, Mel Gorman <mgorman@suse.de>,
akpm@linux-foundation.org, dhillf@gmail.com
Subject: Re: [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page
Date: Tue, 05 Nov 2013 10:47:03 -0800 [thread overview]
Message-ID: <52793D27.8050607@sr71.net> (raw)
In-Reply-To: <20131028221126.GA29431@shutemov.name>
On 10/28/2013 03:11 PM, Kirill A. Shutemov wrote:
> On Mon, Oct 28, 2013 at 03:16:20PM -0700, Dave Hansen wrote:
>> void copy_huge_page(struct page *dst, struct page *src)
>> {
>> struct hstate *h = page_hstate(src);
>> if (unlikely(pages_per_huge_page(h) > MAX_ORDER_NR_PAGES)) {
>> ...
>>
>> This patch creates a copy_high_order_page() which can
>> be used on THP pages.
>
> We already have copy_user_huge_page() and copy_user_gigantic_page() in
> generic code (mm/memory.c). I think copy_gigantic_page() and
> copy_huge_page() should be moved there too.
That would be fine I guesss... in another patch. :)
> BTW, I think pages_per_huge_page in copy_user_huge_page() is redunand:
> compound_order(page) should be enough, right?
The way it is now, the compiler can optimize for the !HUGETLBFS case.
Also, pages_per_huge_page() works for gigantic pages. compound_order()
wouldn't work for those.
next prev parent reply other threads:[~2013-11-05 18:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 22:16 [PATCH 1/2] mm: hugetlbfs: Add some VM_BUG_ON()s to catch non-hugetlbfs pages Dave Hansen
2013-10-28 22:16 ` Dave Hansen
2013-10-28 22:16 ` [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page Dave Hansen
2013-10-28 22:16 ` Dave Hansen
2013-10-28 22:11 ` Kirill A. Shutemov
2013-10-28 22:11 ` Kirill A. Shutemov
2013-10-30 15:31 ` [PATCH 2/2] mm: thp: give transparent hugepage code a separatecopy_page Naoya Horiguchi
2013-10-30 15:31 ` Naoya Horiguchi
2013-11-05 18:47 ` Dave Hansen [this message]
2013-11-05 18:47 ` [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page Dave Hansen
2013-11-06 13:46 ` Hillf Danton
2013-11-06 13:46 ` Hillf Danton
2013-11-06 16:34 ` Dave Hansen
2013-11-06 16:34 ` Dave Hansen
2013-10-30 15:10 ` [PATCH 1/2] mm: hugetlbfs: Add some VM_BUG_ON()s to catchnon-hugetlbfs pages Naoya Horiguchi
2013-10-30 15:10 ` Naoya Horiguchi
-- strict thread matches above, loose matches on Subject: below --
2013-11-14 23:33 [PATCH 0/2] v2: fix hugetlb vs. anon-thp copy page Dave Hansen
2013-11-14 23:34 ` [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page Dave Hansen
2013-11-14 23:34 ` Dave Hansen
2013-11-15 10:26 ` Mel Gorman
2013-11-15 10:26 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52793D27.8050607@sr71.net \
--to=dave@sr71.net \
--cc=akpm@linux-foundation.org \
--cc=dave.jiang@intel.com \
--cc=dhillf@gmail.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.