From: Dave Hansen <dave@sr71.net>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
dave.jiang@intel.com, Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page
Date: Wed, 06 Nov 2013 08:34:27 -0800 [thread overview]
Message-ID: <527A6F93.8070606@sr71.net> (raw)
In-Reply-To: <CAJd=RBAFgn=3GvEEdHDARpw_h+6SbYE_35D5QJX7C60cVd4tmA@mail.gmail.com>
On 11/06/2013 05:46 AM, Hillf Danton wrote:
> On Tue, Oct 29, 2013 at 6:16 AM, Dave Hansen <dave@sr71.net> wrote:
>> +
>> +void copy_high_order_page(struct page *newpage,
>> + struct page *oldpage,
>> + int order)
>> +{
>> + int i;
>> +
>> + might_sleep();
>> + for (i = 0; i < (1<<order); i++) {
>> + cond_resched();
>> + copy_highpage(newpage + i, oldpage + i);
>> + }
>> +}
>
> Can we make no use of might_sleep here with cond_resched in loop?
I'm not sure what you're saying.
Are you pointing out that cond_resched() actually calls might_sleep() so
the might_sleep() is redundant?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
dave.jiang@intel.com, Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page
Date: Wed, 06 Nov 2013 08:34:27 -0800 [thread overview]
Message-ID: <527A6F93.8070606@sr71.net> (raw)
In-Reply-To: <CAJd=RBAFgn=3GvEEdHDARpw_h+6SbYE_35D5QJX7C60cVd4tmA@mail.gmail.com>
On 11/06/2013 05:46 AM, Hillf Danton wrote:
> On Tue, Oct 29, 2013 at 6:16 AM, Dave Hansen <dave@sr71.net> wrote:
>> +
>> +void copy_high_order_page(struct page *newpage,
>> + struct page *oldpage,
>> + int order)
>> +{
>> + int i;
>> +
>> + might_sleep();
>> + for (i = 0; i < (1<<order); i++) {
>> + cond_resched();
>> + copy_highpage(newpage + i, oldpage + i);
>> + }
>> +}
>
> Can we make no use of might_sleep here with cond_resched in loop?
I'm not sure what you're saying.
Are you pointing out that cond_resched() actually calls might_sleep() so
the might_sleep() is redundant?
next prev parent reply other threads:[~2013-11-06 16:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 22:16 [PATCH 1/2] mm: hugetlbfs: Add some VM_BUG_ON()s to catch non-hugetlbfs pages Dave Hansen
2013-10-28 22:16 ` Dave Hansen
2013-10-28 22:16 ` [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page Dave Hansen
2013-10-28 22:16 ` Dave Hansen
2013-10-28 22:11 ` Kirill A. Shutemov
2013-10-28 22:11 ` Kirill A. Shutemov
2013-10-30 15:31 ` [PATCH 2/2] mm: thp: give transparent hugepage code a separatecopy_page Naoya Horiguchi
2013-10-30 15:31 ` Naoya Horiguchi
2013-11-05 18:47 ` [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page Dave Hansen
2013-11-05 18:47 ` Dave Hansen
2013-11-06 13:46 ` Hillf Danton
2013-11-06 13:46 ` Hillf Danton
2013-11-06 16:34 ` Dave Hansen [this message]
2013-11-06 16:34 ` Dave Hansen
2013-10-30 15:10 ` [PATCH 1/2] mm: hugetlbfs: Add some VM_BUG_ON()s to catchnon-hugetlbfs pages Naoya Horiguchi
2013-10-30 15:10 ` Naoya Horiguchi
-- strict thread matches above, loose matches on Subject: below --
2013-11-14 23:33 [PATCH 0/2] v2: fix hugetlb vs. anon-thp copy page Dave Hansen
2013-11-14 23:34 ` [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page Dave Hansen
2013-11-14 23:34 ` Dave Hansen
2013-11-15 10:26 ` Mel Gorman
2013-11-15 10:26 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527A6F93.8070606@sr71.net \
--to=dave@sr71.net \
--cc=akpm@linux-foundation.org \
--cc=dave.jiang@intel.com \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.