* [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled
@ 2013-11-06 19:19 Laurent GONZALEZ
2013-11-06 19:56 ` Thomas De Schampheleire
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Laurent GONZALEZ @ 2013-11-06 19:19 UTC (permalink / raw)
To: buildroot
For configurations using a toolchain that is preinstalled on
the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
empty to avoid downloading any toolchain package.
The actual implementation has been proposed by Thomas Petazzoni.
Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
---
toolchain/toolchain-external/toolchain-external.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
index 2722600..e2e9953 100644
--- a/toolchain/toolchain-external/toolchain-external.mk
+++ b/toolchain/toolchain-external/toolchain-external.mk
@@ -348,6 +348,14 @@ TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
endif
+# In fact, we don't need to download the toolchain, since it is already
+# available on the system, so force the site and source to be empty so
+# that nothing will be downloaded/extracted.
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_PREINSTALLED),y)
+TOOLCHAIN_EXTERNAL_SITE =
+TOOLCHAIN_EXTERNAL_SOURCE =
+endif
+
TOOLCHAIN_EXTERNAL_INSTALL_STAGING = YES
ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled
2013-11-06 19:19 [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled Laurent GONZALEZ
@ 2013-11-06 19:56 ` Thomas De Schampheleire
2013-11-07 6:36 ` Laurent GONZALEZ
2013-11-07 7:57 ` Thomas Petazzoni
2013-11-10 23:08 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Thomas De Schampheleire @ 2013-11-06 19:56 UTC (permalink / raw)
To: buildroot
Laurent GONZALEZ <br2@gezedo.com> wrote:
>For configurations using a toolchain that is preinstalled on
>the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
>empty to avoid downloading any toolchain package.
>The actual implementation has been proposed by Thomas Petazzoni.
>
>Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
>---
> toolchain/toolchain-external/toolchain-external.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
>index 2722600..e2e9953 100644
>--- a/toolchain/toolchain-external/toolchain-external.mk
>+++ b/toolchain/toolchain-external/toolchain-external.mk
>@@ -348,6 +348,14 @@ TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
> TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
> endif
>
>+# In fact, we don't need to download the toolchain, since it is already
>+# available on the system, so force the site and source to be empty so
>+# that nothing will be downloaded/extracted.
>+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_PREINSTALLED),y)
>+TOOLCHAIN_EXTERNAL_SITE =
>+TOOLCHAIN_EXTERNAL_SOURCE =
>+endif
>+
> TOOLCHAIN_EXTERNAL_INSTALL_STAGING = YES
>
> ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
In the previous thread you said there was still a problem with v2...
What was that problem? I tested v2 and seemed to work fine...
Thanks,
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled
2013-11-06 19:56 ` Thomas De Schampheleire
@ 2013-11-07 6:36 ` Laurent GONZALEZ
0 siblings, 0 replies; 6+ messages in thread
From: Laurent GONZALEZ @ 2013-11-07 6:36 UTC (permalink / raw)
To: buildroot
On 06/11/2013 20:56, Thomas De Schampheleire wrote:
> Laurent GONZALEZ <br2@gezedo.com> wrote:
>> For configurations using a toolchain that is preinstalled on
>> the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
>> empty to avoid downloading any toolchain package.
>> The actual implementation has been proposed by Thomas Petazzoni.
>>
>> Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
>> ---
>> toolchain/toolchain-external/toolchain-external.mk | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
>> index 2722600..e2e9953 100644
>> --- a/toolchain/toolchain-external/toolchain-external.mk
>> +++ b/toolchain/toolchain-external/toolchain-external.mk
>> @@ -348,6 +348,14 @@ TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
>> TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
>> endif
>>
>> +# In fact, we don't need to download the toolchain, since it is already
>> +# available on the system, so force the site and source to be empty so
>> +# that nothing will be downloaded/extracted.
>> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_PREINSTALLED),y)
>> +TOOLCHAIN_EXTERNAL_SITE =
>> +TOOLCHAIN_EXTERNAL_SOURCE =
>> +endif
>> +
>> TOOLCHAIN_EXTERNAL_INSTALL_STAGING = YES
>>
>> ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
>
> In the previous thread you said there was still a problem with v2...
> What was that problem? I tested v2 and seemed to work fine...
>
There were no other problem than the one you highlighted in my very first thread.
This v3 looks good, when everyone agrees it should be ready for integration.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled
2013-11-06 19:19 [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled Laurent GONZALEZ
2013-11-06 19:56 ` Thomas De Schampheleire
@ 2013-11-07 7:57 ` Thomas Petazzoni
2013-11-07 8:27 ` Thomas De Schampheleire
2013-11-10 23:08 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2013-11-07 7:57 UTC (permalink / raw)
To: buildroot
Dear Laurent GONZALEZ,
On Wed, 06 Nov 2013 20:19:10 +0100, Laurent GONZALEZ wrote:
> For configurations using a toolchain that is preinstalled on
> the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
> empty to avoid downloading any toolchain package.
> The actual implementation has been proposed by Thomas Petazzoni.
>
> Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
> ---
> toolchain/toolchain-external/toolchain-external.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled
2013-11-07 7:57 ` Thomas Petazzoni
@ 2013-11-07 8:27 ` Thomas De Schampheleire
0 siblings, 0 replies; 6+ messages in thread
From: Thomas De Schampheleire @ 2013-11-07 8:27 UTC (permalink / raw)
To: buildroot
On Thu, Nov 7, 2013 at 8:57 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Laurent GONZALEZ,
>
> On Wed, 06 Nov 2013 20:19:10 +0100, Laurent GONZALEZ wrote:
>> For configurations using a toolchain that is preinstalled on
>> the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
>> empty to avoid downloading any toolchain package.
>> The actual implementation has been proposed by Thomas Petazzoni.
>>
>> Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
>> ---
>> toolchain/toolchain-external/toolchain-external.mk | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled
2013-11-06 19:19 [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled Laurent GONZALEZ
2013-11-06 19:56 ` Thomas De Schampheleire
2013-11-07 7:57 ` Thomas Petazzoni
@ 2013-11-10 23:08 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-11-10 23:08 UTC (permalink / raw)
To: buildroot
>>>>> "Laurent" == Laurent GONZALEZ <br2@gezedo.com> writes:
> For configurations using a toolchain that is preinstalled on
> the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
> empty to avoid downloading any toolchain package.
> The actual implementation has been proposed by Thomas Petazzoni.
> Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-10 23:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-06 19:19 [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled Laurent GONZALEZ
2013-11-06 19:56 ` Thomas De Schampheleire
2013-11-07 6:36 ` Laurent GONZALEZ
2013-11-07 7:57 ` Thomas Petazzoni
2013-11-07 8:27 ` Thomas De Schampheleire
2013-11-10 23:08 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.