* [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW
@ 2013-11-10 17:49 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-10 17:49 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Anthony Liguori
While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny
(gcc-mingw32 4.4.2-3) shows these errors:
In file included from qga/vss-win32.c:17:
qga/vss-win32/requester.h:31:
error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_init«
qga/vss-win32/requester.h:32:
error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_deinit«
The macro STDAPI is unknown, so add the missing include file which
defines it.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
This patch also fixes the same error on the MinGW buildbot.
I did not notice it earlier because I usually compile with MinGW-w64.
Regards,
Stefan
qga/vss-win32/requester.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/vss-win32/requester.h b/qga/vss-win32/requester.h
index cffec01..374f9b8 100644
--- a/qga/vss-win32/requester.h
+++ b/qga/vss-win32/requester.h
@@ -13,6 +13,7 @@
#ifndef VSS_WIN32_REQUESTER_H
#define VSS_WIN32_REQUESTER_H
+#include <basetyps.h> /* STDAPI */
#include "qemu/compiler.h"
#ifdef __cplusplus
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW
@ 2013-11-10 17:49 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-10 17:49 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Anthony Liguori
While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny
(gcc-mingw32 4.4.2-3) shows these errors:
In file included from qga/vss-win32.c:17:
qga/vss-win32/requester.h:31:
error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_init«
qga/vss-win32/requester.h:32:
error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_deinit«
The macro STDAPI is unknown, so add the missing include file which
defines it.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
This patch also fixes the same error on the MinGW buildbot.
I did not notice it earlier because I usually compile with MinGW-w64.
Regards,
Stefan
qga/vss-win32/requester.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/vss-win32/requester.h b/qga/vss-win32/requester.h
index cffec01..374f9b8 100644
--- a/qga/vss-win32/requester.h
+++ b/qga/vss-win32/requester.h
@@ -13,6 +13,7 @@
#ifndef VSS_WIN32_REQUESTER_H
#define VSS_WIN32_REQUESTER_H
+#include <basetyps.h> /* STDAPI */
#include "qemu/compiler.h"
#ifdef __cplusplus
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW
2013-11-10 17:49 ` [Qemu-devel] " Stefan Weil
@ 2013-11-13 11:53 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-11-13 11:53 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Anthony Liguori
10.11.2013 21:49, Stefan Weil wrote:
> While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny
> (gcc-mingw32 4.4.2-3) shows these errors:
I guess you mean Debian lenny, not Ubuntu lenny here ;) And lenny
is an "old-old-stable" Debian release - it was before squeeze which
is now oldstable. Lenny has been released at 14 Feb 2009...
> In file included from qga/vss-win32.c:17:
> qga/vss-win32/requester.h:31:
> error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_init«
> qga/vss-win32/requester.h:32:
> error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_deinit«
>
> The macro STDAPI is unknown, so add the missing include file which
> defines it.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> This patch also fixes the same error on the MinGW buildbot.
> I did not notice it earlier because I usually compile with MinGW-w64.
>
> Regards,
> Stefan
>
> qga/vss-win32/requester.h | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to the trivial-patches queue, with s/Ubuntu/Debian/ - hopefully
this is okay :)
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW
@ 2013-11-13 11:53 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-11-13 11:53 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Anthony Liguori
10.11.2013 21:49, Stefan Weil wrote:
> While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny
> (gcc-mingw32 4.4.2-3) shows these errors:
I guess you mean Debian lenny, not Ubuntu lenny here ;) And lenny
is an "old-old-stable" Debian release - it was before squeeze which
is now oldstable. Lenny has been released at 14 Feb 2009...
> In file included from qga/vss-win32.c:17:
> qga/vss-win32/requester.h:31:
> error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_init«
> qga/vss-win32/requester.h:32:
> error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_deinit«
>
> The macro STDAPI is unknown, so add the missing include file which
> defines it.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> This patch also fixes the same error on the MinGW buildbot.
> I did not notice it earlier because I usually compile with MinGW-w64.
>
> Regards,
> Stefan
>
> qga/vss-win32/requester.h | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to the trivial-patches queue, with s/Ubuntu/Debian/ - hopefully
this is okay :)
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW
2013-11-13 11:53 ` [Qemu-devel] " Michael Tokarev
@ 2013-11-13 17:40 ` Stefan Weil
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-13 17:40 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel, Anthony Liguori
Am 13.11.2013 12:53, schrieb Michael Tokarev:
> 10.11.2013 21:49, Stefan Weil wrote:
>> While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny
>> (gcc-mingw32 4.4.2-3) shows these errors:
> I guess you mean Debian lenny, not Ubuntu lenny here ;) And lenny
> is an "old-old-stable" Debian release - it was before squeeze which
> is now oldstable. Lenny has been released at 14 Feb 2009...
It should have been Ubuntu Lucid (LTS).
> 1 file changed, 1 insertion(+)
> Thanks, applied to the trivial-patches queue, with s/Ubuntu/Debian/ - hopefully
> this is okay :)
>
> /mjt
Debian Lenny is sufficiently old, so I am rather sure that its MinGW
has the same problem, so this is fine, thanks.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW
@ 2013-11-13 17:40 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-13 17:40 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel, Anthony Liguori
Am 13.11.2013 12:53, schrieb Michael Tokarev:
> 10.11.2013 21:49, Stefan Weil wrote:
>> While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny
>> (gcc-mingw32 4.4.2-3) shows these errors:
> I guess you mean Debian lenny, not Ubuntu lenny here ;) And lenny
> is an "old-old-stable" Debian release - it was before squeeze which
> is now oldstable. Lenny has been released at 14 Feb 2009...
It should have been Ubuntu Lucid (LTS).
> 1 file changed, 1 insertion(+)
> Thanks, applied to the trivial-patches queue, with s/Ubuntu/Debian/ - hopefully
> this is okay :)
>
> /mjt
Debian Lenny is sufficiently old, so I am rather sure that its MinGW
has the same problem, so this is fine, thanks.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-13 17:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-10 17:49 [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW Stefan Weil
2013-11-10 17:49 ` [Qemu-devel] " Stefan Weil
2013-11-13 11:53 ` [Qemu-trivial] " Michael Tokarev
2013-11-13 11:53 ` [Qemu-devel] " Michael Tokarev
2013-11-13 17:40 ` Stefan Weil
2013-11-13 17:40 ` [Qemu-devel] " Stefan Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.