* [PATCH 5/5] X86: enable MPX feature to HVM guest
@ 2013-11-19 10:54 Liu, Jinsong
2013-11-21 15:32 ` Andrew Cooper
2013-11-22 13:29 ` Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: Liu, Jinsong @ 2013-11-19 10:54 UTC (permalink / raw)
To: Jan Beulich, keir@xen.org, xen-devel@lists.xen.org
Cc: andrew.cooper3@citrix.com, Ian Campbell, haoxudong.hao@gmail.com
>From 9d0248fddf86c96efcb16963f0842927cb5c23c0 Mon Sep 17 00:00:00 2001
From: Liu Jinsong <jinsong.liu@intel.com>
Date: Tue, 19 Nov 2013 18:48:20 +0800
Subject: [PATCH 5/5] X86: enable MPX feature to HVM guest
Signed-off-by: Xudong Hao <xudong.hao@intel.com>
Reviewed-by: Liu Jinsong <jinsong.liu@intel.com>
---
xen/arch/x86/xstate.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c
index 1fd43c9..2bc9b60 100644
--- a/xen/arch/x86/xstate.c
+++ b/xen/arch/x86/xstate.c
@@ -373,6 +373,7 @@ int handle_xsetbv(u32 index, u64 new_bv)
mask = new_bv & ~curr->arch.xcr0_accum;
curr->arch.xcr0 = new_bv;
curr->arch.xcr0_accum |= new_bv;
+ curr->arch.nonlazy_xstate_used = !!(curr->arch.xcr0 & XSTATE_NONLAZY);
mask &= curr->fpu_dirtied ? ~XSTATE_FP_SSE : XSTATE_NONLAZY;
if ( mask )
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 5/5] X86: enable MPX feature to HVM guest
2013-11-19 10:54 [PATCH 5/5] X86: enable MPX feature to HVM guest Liu, Jinsong
@ 2013-11-21 15:32 ` Andrew Cooper
2013-11-22 13:29 ` Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Cooper @ 2013-11-21 15:32 UTC (permalink / raw)
To: Liu, Jinsong
Cc: haoxudong.hao@gmail.com, keir@xen.org, Ian Campbell, Jan Beulich,
xen-devel@lists.xen.org
On 19/11/13 10:54, Liu, Jinsong wrote:
> From 9d0248fddf86c96efcb16963f0842927cb5c23c0 Mon Sep 17 00:00:00 2001
> From: Liu Jinsong <jinsong.liu@intel.com>
> Date: Tue, 19 Nov 2013 18:48:20 +0800
> Subject: [PATCH 5/5] X86: enable MPX feature to HVM guest
>
> Signed-off-by: Xudong Hao <xudong.hao@intel.com>
> Reviewed-by: Liu Jinsong <jinsong.liu@intel.com>
> ---
> xen/arch/x86/xstate.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c
> index 1fd43c9..2bc9b60 100644
> --- a/xen/arch/x86/xstate.c
> +++ b/xen/arch/x86/xstate.c
> @@ -373,6 +373,7 @@ int handle_xsetbv(u32 index, u64 new_bv)
> mask = new_bv & ~curr->arch.xcr0_accum;
> curr->arch.xcr0 = new_bv;
> curr->arch.xcr0_accum |= new_bv;
> + curr->arch.nonlazy_xstate_used = !!(curr->arch.xcr0 & XSTATE_NONLAZY);
>
> mask &= curr->fpu_dirtied ? ~XSTATE_FP_SSE : XSTATE_NONLAZY;
> if ( mask )
This looks like a bug, and unrelated to the patch description?
~Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 5/5] X86: enable MPX feature to HVM guest
2013-11-19 10:54 [PATCH 5/5] X86: enable MPX feature to HVM guest Liu, Jinsong
2013-11-21 15:32 ` Andrew Cooper
@ 2013-11-22 13:29 ` Jan Beulich
2013-11-22 16:51 ` Liu, Jinsong
1 sibling, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2013-11-22 13:29 UTC (permalink / raw)
To: Jinsong Liu
Cc: andrew.cooper3@citrix.com, xen-devel, keir@xen.org, Ian Campbell,
haoxudong.hao@gmail.com
>>> On 19.11.13 at 11:54, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:
> From 9d0248fddf86c96efcb16963f0842927cb5c23c0 Mon Sep 17 00:00:00 2001
> From: Liu Jinsong <jinsong.liu@intel.com>
> Date: Tue, 19 Nov 2013 18:48:20 +0800
> Subject: [PATCH 5/5] X86: enable MPX feature to HVM guest
>
> Signed-off-by: Xudong Hao <xudong.hao@intel.com>
> Reviewed-by: Liu Jinsong <jinsong.liu@intel.com>
> ---
> xen/arch/x86/xstate.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c
> index 1fd43c9..2bc9b60 100644
> --- a/xen/arch/x86/xstate.c
> +++ b/xen/arch/x86/xstate.c
> @@ -373,6 +373,7 @@ int handle_xsetbv(u32 index, u64 new_bv)
> mask = new_bv & ~curr->arch.xcr0_accum;
> curr->arch.xcr0 = new_bv;
> curr->arch.xcr0_accum |= new_bv;
> + curr->arch.nonlazy_xstate_used = !!(curr->arch.xcr0 & XSTATE_NONLAZY);
See v2 of patch 2. The patch is wrong this way anyway, and
was be mis-ordered (it's a prereq to patch 4).
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 5/5] X86: enable MPX feature to HVM guest
2013-11-22 13:29 ` Jan Beulich
@ 2013-11-22 16:51 ` Liu, Jinsong
0 siblings, 0 replies; 4+ messages in thread
From: Liu, Jinsong @ 2013-11-22 16:51 UTC (permalink / raw)
To: Jan Beulich
Cc: andrew.cooper3@citrix.com, xen-devel, keir@xen.org, Ian Campbell,
haoxudong.hao@gmail.com
Jan Beulich wrote:
>>>> On 19.11.13 at 11:54, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:
>> From 9d0248fddf86c96efcb16963f0842927cb5c23c0 Mon Sep 17 00:00:00
>> 2001 From: Liu Jinsong <jinsong.liu@intel.com>
>> Date: Tue, 19 Nov 2013 18:48:20 +0800
>> Subject: [PATCH 5/5] X86: enable MPX feature to HVM guest
>>
>> Signed-off-by: Xudong Hao <xudong.hao@intel.com>
>> Reviewed-by: Liu Jinsong <jinsong.liu@intel.com>
>> ---
>> xen/arch/x86/xstate.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c
>> index 1fd43c9..2bc9b60 100644
>> --- a/xen/arch/x86/xstate.c
>> +++ b/xen/arch/x86/xstate.c
>> @@ -373,6 +373,7 @@ int handle_xsetbv(u32 index, u64 new_bv)
>> mask = new_bv & ~curr->arch.xcr0_accum;
>> curr->arch.xcr0 = new_bv;
>> curr->arch.xcr0_accum |= new_bv;
>> + curr->arch.nonlazy_xstate_used = !!(curr->arch.xcr0 &
>> XSTATE_NONLAZY);
>
> See v2 of patch 2. The patch is wrong this way anyway, and
> was be mis-ordered (it's a prereq to patch 4).
>
Yes, this patch in fact could be dropped per patch 2 V2.
Thanks Jan and Andrew!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-22 16:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-19 10:54 [PATCH 5/5] X86: enable MPX feature to HVM guest Liu, Jinsong
2013-11-21 15:32 ` Andrew Cooper
2013-11-22 13:29 ` Jan Beulich
2013-11-22 16:51 ` Liu, Jinsong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.