From: Florian Meier <florian.meier@koalo.de>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: devicetree <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
dmaengine <dmaengine@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv4] ASoC: Add support for BCM2835
Date: Fri, 22 Nov 2013 14:32:19 +0100 [thread overview]
Message-ID: <528F5CE3.30105@koalo.de> (raw)
In-Reply-To: <528E4E4A.20403@koalo.de>
> + dev = devm_kzalloc(&pdev->dev, sizeof(*dev),
> + GFP_KERNEL);
> + if (IS_ERR(base))
> + return PTR_ERR(base);
Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev).
Is the patch acceptable apart from that now?
Greetings,
Florian
WARNING: multiple messages have this Message-ID (diff)
From: florian.meier@koalo.de (Florian Meier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4] ASoC: Add support for BCM2835
Date: Fri, 22 Nov 2013 14:32:19 +0100 [thread overview]
Message-ID: <528F5CE3.30105@koalo.de> (raw)
In-Reply-To: <528E4E4A.20403@koalo.de>
> + dev = devm_kzalloc(&pdev->dev, sizeof(*dev),
> + GFP_KERNEL);
> + if (IS_ERR(base))
> + return PTR_ERR(base);
Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev).
Is the patch acceptable apart from that now?
Greetings,
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Meier <florian.meier@koalo.de>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
dmaengine <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv4] ASoC: Add support for BCM2835
Date: Fri, 22 Nov 2013 14:32:19 +0100 [thread overview]
Message-ID: <528F5CE3.30105@koalo.de> (raw)
In-Reply-To: <528E4E4A.20403@koalo.de>
> + dev = devm_kzalloc(&pdev->dev, sizeof(*dev),
> + GFP_KERNEL);
> + if (IS_ERR(base))
> + return PTR_ERR(base);
Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev).
Is the patch acceptable apart from that now?
Greetings,
Florian
next prev parent reply other threads:[~2013-11-22 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 18:17 [PATCHv4] ASoC: Add support for BCM2835 Florian Meier
2013-11-21 18:17 ` Florian Meier
2013-11-21 18:17 ` Florian Meier
2013-11-22 13:32 ` Florian Meier [this message]
2013-11-22 13:32 ` Florian Meier
2013-11-22 13:32 ` Florian Meier
2013-11-22 14:05 ` Mark Brown
2013-11-22 14:05 ` Mark Brown
2013-11-22 14:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528F5CE3.30105@koalo.de \
--to=florian.meier@koalo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.