From: John Crispin <john@phrozen.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH V4 1/2] bcma: gpio: add own IRQ domain
Date: Fri, 29 Nov 2013 21:37:01 +0100 [thread overview]
Message-ID: <5298FAED.7020408@phrozen.org> (raw)
In-Reply-To: <1385752379-19540-1-git-send-email-zajec5@gmail.com>
On 29/11/13 20:12, Rafał Miłecki wrote:
> +#ifdef CONFIG_BCMA_HOST_SOC
> chip->to_irq = bcma_gpio_to_irq;
> +#endif
> chip->ngpio = 16;
Hi,
Should this not be
if (IS_ENABLED(CONFIG_BCMA_HOST_SOC))
chip->to_irq = bcma_gpio_to_irq;
John
next prev parent reply other threads:[~2013-11-29 20:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 16:09 [PATCH V2 1/2] bcma: gpio: add own IRQ domain Rafał Miłecki
2013-11-29 16:09 ` [PATCH V2 2/2] MIPS: BCM47XX: Prepare support for GPIO buttons Rafał Miłecki
2013-12-09 13:33 ` Hauke Mehrtens
2013-12-10 15:24 ` [PATCH V3 " Rafał Miłecki
2013-12-11 21:56 ` Hauke Mehrtens
2014-01-02 12:31 ` [PATCH V4] " Rafał Miłecki
2013-11-29 16:31 ` [PATCH V2 1/2] bcma: gpio: add own IRQ domain Hauke Mehrtens
2013-11-29 16:55 ` Rafał Miłecki
2013-11-29 17:48 ` [PATCH V3 " Rafał Miłecki
2013-11-29 18:37 ` Hauke Mehrtens
2013-11-29 19:12 ` [PATCH V4 " Rafał Miłecki
2013-11-29 20:37 ` John Crispin [this message]
2013-11-29 20:53 ` Rafał Miłecki
2013-11-29 21:16 ` John Crispin
2013-12-08 18:10 ` Hauke Mehrtens
2013-12-08 19:24 ` Sergei Shtylyov
2013-12-10 11:56 ` [PATCH V5 " Rafał Miłecki
2013-12-11 21:53 ` Hauke Mehrtens
2013-12-12 12:42 ` [PATCH V6 " Rafał Miłecki
2013-12-12 12:46 ` [PATCH V7 " Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5298FAED.7020408@phrozen.org \
--to=john@phrozen.org \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.