From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>,
"John Crispin" <john@phrozen.org>,
"Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH V4 1/2] bcma: gpio: add own IRQ domain
Date: Sun, 08 Dec 2013 22:24:02 +0300 [thread overview]
Message-ID: <52A4C752.9030700@cogentembedded.com> (raw)
In-Reply-To: <52A4B609.20805@hauke-m.de>
Hello.
On 12/08/2013 09:10 PM, Hauke Mehrtens wrote:
>>>>> +#ifdef CONFIG_BCMA_HOST_SOC
>>>>> chip->to_irq = bcma_gpio_to_irq;
>>>>> +#endif
>>>>> chip->ngpio = 16;
>>>> Hi,
>>>> Should this not be
>>>> if (IS_ENABLED(CONFIG_BCMA_HOST_SOC))
>>>> chip->to_irq = bcma_gpio_to_irq;
>>> I can't find a proper documentation about that. It's definitely nicer
>>> to use
>>> #if IS_ENABLED(FOO)
>>> instead of
>>> #if defined(FOO) || defined(FOO_MODULE)
>>> But are we supposed to use it also for a simple
>>> #if defined(FOO)
>>> ?
>>> I tried to Google about this but found only some minor flame-wars ;)
>>> Is that documented anywhere?
>> The commit message has the relevant info ...
>> http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=2a11c8ea20bf850b3a2c60db8c2e7497d28aba99
> I read this and as far as I understand that when CONFIG_BCMA_HOST_SOC is
> bool and not tristate "#ifdef CONFIG_BCMA_HOST_SOC" and "#if
> IS_ENABLED(CONFIG_BCMA_HOST_SOC)" will have the same effect?
You can also use IS_BUILTIN(CONFIG_BCMA_HOST_SOC) to avoid unneeded test
for the modular case.
> Hauke
WBR, Sergei
next prev parent reply other threads:[~2013-12-08 18:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 16:09 [PATCH V2 1/2] bcma: gpio: add own IRQ domain Rafał Miłecki
2013-11-29 16:09 ` [PATCH V2 2/2] MIPS: BCM47XX: Prepare support for GPIO buttons Rafał Miłecki
2013-12-09 13:33 ` Hauke Mehrtens
2013-12-10 15:24 ` [PATCH V3 " Rafał Miłecki
2013-12-11 21:56 ` Hauke Mehrtens
2014-01-02 12:31 ` [PATCH V4] " Rafał Miłecki
2013-11-29 16:31 ` [PATCH V2 1/2] bcma: gpio: add own IRQ domain Hauke Mehrtens
2013-11-29 16:55 ` Rafał Miłecki
2013-11-29 17:48 ` [PATCH V3 " Rafał Miłecki
2013-11-29 18:37 ` Hauke Mehrtens
2013-11-29 19:12 ` [PATCH V4 " Rafał Miłecki
2013-11-29 20:37 ` John Crispin
2013-11-29 20:53 ` Rafał Miłecki
2013-11-29 21:16 ` John Crispin
2013-12-08 18:10 ` Hauke Mehrtens
2013-12-08 19:24 ` Sergei Shtylyov [this message]
2013-12-10 11:56 ` [PATCH V5 " Rafał Miłecki
2013-12-11 21:53 ` Hauke Mehrtens
2013-12-12 12:42 ` [PATCH V6 " Rafał Miłecki
2013-12-12 12:46 ` [PATCH V7 " Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A4C752.9030700@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.