From: Antonio Quartulli <antonio@meshcoding.com>
To: David Laight <David.Laight@ACULAB.COM>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: netdev@vger.kernel.org,
The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
David Miller <davem@davemloft.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH] Fix ARM BUILD_BUG_ON() errors withbatman-adv
Date: Mon, 02 Dec 2013 13:50:46 +0100 [thread overview]
Message-ID: <529C8226.2040000@meshcoding.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7451@saturn3.aculab.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/12/13 11:24, David Laight wrote:
> ...
>> The only solutions are: use the GCC packed attribute, redesign
>> the structures...
>
> It is probably enough to mark the inner structure containing the
> three byte fields 'packed'. Marking it aligned(1) might also have
> the desired effect. The outer structure should then be ok. But
> would need to use a specially named attribute so it doesn't get
> removed.
This may work with the structures I reported in a previous email, but
it is not a good solution for us because we have other more complex
substructs that cannot be packed that way.
I think we will simply duplicate the members and avoid substructs in
our packets.
- --
Antonio Quartulli
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iEYEARECAAYFAlKcgiYACgkQpGgxIkP9cwfeeQCfef0xDfD2TucJBhzoTmDfwA29
Oc4An3Etz3USDC0cf/+R+Gyx8LEtpq16
=XZn5
-----END PGP SIGNATURE-----
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <antonio@meshcoding.com>
To: David Laight <David.Laight@ACULAB.COM>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH] Fix ARM BUILD_BUG_ON() errors withbatman-adv
Date: Mon, 02 Dec 2013 13:50:46 +0100 [thread overview]
Message-ID: <529C8226.2040000@meshcoding.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7451@saturn3.aculab.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/12/13 11:24, David Laight wrote:
> ...
>> The only solutions are: use the GCC packed attribute, redesign
>> the structures...
>
> It is probably enough to mark the inner structure containing the
> three byte fields 'packed'. Marking it aligned(1) might also have
> the desired effect. The outer structure should then be ok. But
> would need to use a specially named attribute so it doesn't get
> removed.
This may work with the structures I reported in a previous email, but
it is not a good solution for us because we have other more complex
substructs that cannot be packed that way.
I think we will simply duplicate the members and avoid substructs in
our packets.
- --
Antonio Quartulli
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iEYEARECAAYFAlKcgiYACgkQpGgxIkP9cwfeeQCfef0xDfD2TucJBhzoTmDfwA29
Oc4An3Etz3USDC0cf/+R+Gyx8LEtpq16
=XZn5
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-12-02 12:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 19:15 [B.A.T.M.A.N.] [PATCH] Fix ARM BUILD_BUG_ON() errors with batman-adv Russell King - ARM Linux
2013-11-30 19:15 ` Russell King - ARM Linux
2013-11-30 20:12 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-11-30 20:12 ` Antonio Quartulli
2013-11-30 23:05 ` [B.A.T.M.A.N.] " Russell King - ARM Linux
2013-11-30 23:05 ` Russell King - ARM Linux
2013-12-01 0:27 ` Antonio Quartulli
2013-12-01 0:27 ` Antonio Quartulli
2013-12-01 14:28 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-12-01 14:28 ` Antonio Quartulli
2013-12-01 17:13 ` Russell King - ARM Linux
2013-12-01 17:13 ` Russell King - ARM Linux
2013-12-02 10:24 ` [B.A.T.M.A.N.] [PATCH] Fix ARM BUILD_BUG_ON() errors withbatman-adv David Laight
2013-12-02 10:24 ` David Laight
2013-12-02 12:50 ` Antonio Quartulli [this message]
2013-12-02 12:50 ` Antonio Quartulli
2013-12-02 13:10 ` David Laight
2013-12-02 13:10 ` David Laight
2013-12-02 16:20 ` David Miller
2013-12-02 16:20 ` David Miller
2013-12-01 19:21 ` [B.A.T.M.A.N.] [PATCH] Fix ARM BUILD_BUG_ON() errors with batman-adv David Miller
2013-12-01 19:21 ` David Miller
2013-12-01 20:40 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-11-30 21:05 ` David Miller
2013-11-30 21:05 ` David Miller
2013-11-30 23:03 ` [B.A.T.M.A.N.] " Russell King - ARM Linux
2013-11-30 23:03 ` Russell King - ARM Linux
2013-12-02 17:58 ` [B.A.T.M.A.N.] " Simon Wunderlich
2013-12-02 17:58 ` Simon Wunderlich
2013-12-02 18:38 ` [B.A.T.M.A.N.] " David Miller
2013-12-02 18:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C8226.2040000@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=David.Laight@ACULAB.COM \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.