From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, patches@linaro.org,
Andre Przywara <andre.przywara@linaro.org>,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 1/6] arm: rename xen/arch/arm/psci.c into vpsci.c
Date: Mon, 02 Dec 2013 13:08:36 +0000 [thread overview]
Message-ID: <529C8654.10101@linaro.org> (raw)
In-Reply-To: <1385989569.7108.68.camel@kazak.uk.xensource.com>
On 12/02/2013 01:06 PM, Ian Campbell wrote:
> On Mon, 2013-12-02 at 13:02 +0000, Julien Grall wrote:
>>
>> On 12/02/2013 11:08 AM, Andre Przywara wrote:
>>> Follow the current convention of prefixing guest related names
>>> with "v" by renaming the guest PSCI functionality into vpsci.c to make
>>> room for the host PSCI functions.
>>
>> I would also rename the header asm/psci.h => asm/vpsci.h
>
> The majority of the header is stuff defined by the spec which is equally
> common to be host and guest psci. Apart from a couple of prototypes for
> the guest entry points.
>
> I don't think it makes sense to rename the header, or even to split the
> tiny guest side parts into a new vpsci.h
In this case, can we at least add "guest" (or something else) in the
function name?
--
Julien Grall
next prev parent reply other threads:[~2013-12-02 13:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 11:08 [PATCH v2 0/6] Andre Przywara
2013-12-02 11:08 ` [PATCH v2 1/6] arm: rename xen/arch/arm/psci.c into vpsci.c Andre Przywara
2013-12-02 13:02 ` Julien Grall
2013-12-02 13:06 ` Ian Campbell
2013-12-02 13:08 ` Julien Grall [this message]
2013-12-02 14:53 ` Ian Campbell
2013-12-02 11:08 ` [PATCH v2 2/6] arm: move GIC SGI kicking into separate function Andre Przywara
2013-12-02 13:16 ` Julien Grall
2013-12-02 13:24 ` Andre Przywara
2013-12-02 13:57 ` Julien Grall
2013-12-02 15:01 ` Ian Campbell
2013-12-04 12:15 ` Andre Przywara
2013-12-04 12:28 ` Ian Campbell
2013-12-04 12:33 ` Andre Przywara
2013-12-04 12:35 ` Ian Campbell
2013-12-02 11:08 ` [PATCH v2 3/6] arm: parse PSCI node from the host device-tree Andre Przywara
2013-12-02 13:28 ` Julien Grall
2013-12-02 13:44 ` Andre Przywara
2013-12-02 15:00 ` Julien Grall
2013-12-02 15:14 ` Ian Campbell
2013-12-02 15:05 ` Ian Campbell
2013-12-04 12:37 ` Andre Przywara
2013-12-04 12:41 ` Ian Campbell
2013-12-04 12:44 ` Andre Przywara
2013-12-02 11:08 ` [PATCH v2 4/6] arm: add a function to invoke the PSCI handler Andre Przywara
2013-12-02 15:07 ` Ian Campbell
2013-12-04 12:25 ` Andre Przywara
2013-12-04 12:32 ` Ian Campbell
2013-12-02 11:08 ` [PATCH v2 5/6] arm32: enable PSCI secondary CPU bringup Andre Przywara
2013-12-02 15:09 ` Ian Campbell
2013-12-02 11:08 ` [PATCH v2 6/6] arm64: " Andre Przywara
2013-12-02 15:11 ` Ian Campbell
2013-12-02 14:52 ` [PATCH v2 0/6] Ian Campbell
2013-12-04 12:16 ` Andre Przywara
2013-12-04 12:29 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C8654.10101@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=andre.przywara@linaro.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.