Re: [PATCH v2 2/6] arm: move GIC SGI kicking into separate function

[Julien Grall <julien.grall@linaro.org>]

On 12/02/2013 11:08 AM, Andre Przywara wrote:
> Currently we unconditionally send SGIs to all cores on SMP bringup.
> PSCI will not need this, so we move this into a function and call it
> explicitly from the platforms that need it. This gets us get rid of
> the empty cpu_up() platform functions in ARM32 and the comment in
> there.
>
> Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
> ---
>   xen/arch/arm/arm64/smpboot.c      |  2 +-
>   xen/arch/arm/platform.c           |  2 +-
>   xen/arch/arm/platforms/exynos5.c  | 11 +----------
>   xen/arch/arm/platforms/omap5.c    | 11 +----------
>   xen/arch/arm/platforms/vexpress.c | 10 +---------
>   xen/arch/arm/smpboot.c            | 15 ++++++++++-----
>   xen/include/asm-arm/smp.h         |  2 ++
>   7 files changed, 17 insertions(+), 36 deletions(-)
>

[..]

> diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c
> index a7f9ee4..056d462 100644
> --- a/xen/arch/arm/platform.c
> +++ b/xen/arch/arm/platform.c
> @@ -112,7 +112,7 @@ int __init platform_cpu_up(int cpu)
>       if ( platform && platform->cpu_up )
>           return platform->cpu_up(cpu);
>
> -    return -EAGAIN;
> +    return -ENODEV;

This change seems unrelated to this patch.

-- 
Julien Grall