From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
"swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"pawel.moll-5wv7dgnIgG8@public.gmane.org"
<pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants
Date: Tue, 3 Dec 2013 11:34:13 +0530 [thread overview]
Message-ID: <529D745D.2070503@nvidia.com> (raw)
In-Reply-To: <20131202142522.GA17566-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
On Monday 02 December 2013 07:55 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Mon, Dec 02, 2013 at 07:25:01PM +0530, Laxman Dewangan wrote:
>
> +
> +/* Schmitt enable/disable */
> +#define TEGRA_PIN_DRIVE_SCHMITT_DISABLE 0
> +#define TEGRA_PIN_DRIVE_SCHMITT_ENABLE 1
> These are all boolean, so I wonder if perhaps we should be simply
> defining a single pair and reuse that in different contexts:
>
> #define TEGRA_PIN_DISABLE 0
> #define TEGRA_PIN_ENABLE 1
>
> The property names should provide enough context for them to be used
> unambiguously.
>
>
I can make generic ENABLE/DISABLE macro as you suggested but datasheet
says as 0=NORMAL, 1 = TRISTATE. and that's why I kept name very near to
the datasheet.
Thanks,
Laxman
WARNING: multiple messages have this Message-ID (diff)
From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants
Date: Tue, 3 Dec 2013 11:34:13 +0530 [thread overview]
Message-ID: <529D745D.2070503@nvidia.com> (raw)
In-Reply-To: <20131202142522.GA17566@ulmo.nvidia.com>
On Monday 02 December 2013 07:55 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Mon, Dec 02, 2013 at 07:25:01PM +0530, Laxman Dewangan wrote:
>
> +
> +/* Schmitt enable/disable */
> +#define TEGRA_PIN_DRIVE_SCHMITT_DISABLE 0
> +#define TEGRA_PIN_DRIVE_SCHMITT_ENABLE 1
> These are all boolean, so I wonder if perhaps we should be simply
> defining a single pair and reuse that in different contexts:
>
> #define TEGRA_PIN_DISABLE 0
> #define TEGRA_PIN_ENABLE 1
>
> The property names should provide enough context for them to be used
> unambiguously.
>
>
I can make generic ENABLE/DISABLE macro as you suggested but datasheet
says as 0=NORMAL, 1 = TRISTATE. and that's why I kept name very near to
the datasheet.
Thanks,
Laxman
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants
Date: Tue, 3 Dec 2013 11:34:13 +0530 [thread overview]
Message-ID: <529D745D.2070503@nvidia.com> (raw)
In-Reply-To: <20131202142522.GA17566@ulmo.nvidia.com>
On Monday 02 December 2013 07:55 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Mon, Dec 02, 2013 at 07:25:01PM +0530, Laxman Dewangan wrote:
>
> +
> +/* Schmitt enable/disable */
> +#define TEGRA_PIN_DRIVE_SCHMITT_DISABLE 0
> +#define TEGRA_PIN_DRIVE_SCHMITT_ENABLE 1
> These are all boolean, so I wonder if perhaps we should be simply
> defining a single pair and reuse that in different contexts:
>
> #define TEGRA_PIN_DISABLE 0
> #define TEGRA_PIN_ENABLE 1
>
> The property names should provide enough context for them to be used
> unambiguously.
>
>
I can make generic ENABLE/DISABLE macro as you suggested but datasheet
says as 0=NORMAL, 1 = TRISTATE. and that's why I kept name very near to
the datasheet.
Thanks,
Laxman
next prev parent reply other threads:[~2013-12-03 6:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 13:55 [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants Laxman Dewangan
2013-12-02 13:55 ` Laxman Dewangan
2013-12-02 13:55 ` Laxman Dewangan
2013-12-02 13:55 ` [PATCH 2/2] ARM: tegra: convert device tree file of Dalmore to use pinctrl defines Laxman Dewangan
2013-12-02 13:55 ` Laxman Dewangan
2013-12-02 13:55 ` Laxman Dewangan
[not found] ` <1385992502-12771-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-03 20:09 ` Stephen Warren
2013-12-03 20:09 ` Stephen Warren
2013-12-03 20:09 ` Stephen Warren
[not found] ` <529E3A6E.1050003-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-04 5:51 ` Laxman Dewangan
2013-12-04 5:51 ` Laxman Dewangan
2013-12-04 5:51 ` Laxman Dewangan
2013-12-04 16:59 ` Stephen Warren
2013-12-04 16:59 ` Stephen Warren
[not found] ` <1385992502-12771-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-02 14:25 ` [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants Thierry Reding
2013-12-02 14:25 ` Thierry Reding
2013-12-02 14:25 ` Thierry Reding
[not found] ` <20131202142522.GA17566-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-03 6:04 ` Laxman Dewangan [this message]
2013-12-03 6:04 ` Laxman Dewangan
2013-12-03 6:04 ` Laxman Dewangan
[not found] ` <529D745D.2070503-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-03 20:08 ` Stephen Warren
2013-12-03 20:08 ` Stephen Warren
2013-12-03 20:08 ` Stephen Warren
[not found] ` <529E3A34.4030206-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-04 5:49 ` Laxman Dewangan
2013-12-04 5:49 ` Laxman Dewangan
2013-12-04 5:49 ` Laxman Dewangan
2013-12-03 20:05 ` Stephen Warren
2013-12-03 20:05 ` Stephen Warren
2013-12-03 20:05 ` Stephen Warren
2013-12-03 20:06 ` Stephen Warren
2013-12-03 20:06 ` Stephen Warren
2013-12-03 20:06 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529D745D.2070503@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.