From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org
Cc: pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants
Date: Tue, 03 Dec 2013 13:05:41 -0700 [thread overview]
Message-ID: <529E3995.8090606@wwwdotorg.org> (raw)
In-Reply-To: <1385992502-12771-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 12/02/2013 06:55 AM, Laxman Dewangan wrote:
> Defines pincontrol constants to use from Tegra's DTS file
> for tegra pincontrol properties option.
> diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h
> +/* Tristate/normal */
> +#define TEGRA_PIN_NORMAL 0
> +#define TEGRA_PIN_TRISTATE 1
"NORMAL" is a bit generic. "DRIVEN" might work better.
> +/* High speed mode */
> +#define TEGRA_PIN_DRIVE_HIGH_SPEED_MODE_DISABLE 0
> +#define TEGRA_PIN_DRIVE_HIGH_SPEED_MODE_ENABLE 1
> +
> +/* Schmitt enable/disable */
> +#define TEGRA_PIN_DRIVE_SCHMITT_DISABLE 0
> +#define TEGRA_PIN_DRIVE_SCHMITT_ENABLE 1
I expect you can remove "DRIVE_" from all those names to make things
shorter.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants
Date: Tue, 03 Dec 2013 13:05:41 -0700 [thread overview]
Message-ID: <529E3995.8090606@wwwdotorg.org> (raw)
In-Reply-To: <1385992502-12771-1-git-send-email-ldewangan@nvidia.com>
On 12/02/2013 06:55 AM, Laxman Dewangan wrote:
> Defines pincontrol constants to use from Tegra's DTS file
> for tegra pincontrol properties option.
> diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h
> +/* Tristate/normal */
> +#define TEGRA_PIN_NORMAL 0
> +#define TEGRA_PIN_TRISTATE 1
"NORMAL" is a bit generic. "DRIVEN" might work better.
> +/* High speed mode */
> +#define TEGRA_PIN_DRIVE_HIGH_SPEED_MODE_DISABLE 0
> +#define TEGRA_PIN_DRIVE_HIGH_SPEED_MODE_ENABLE 1
> +
> +/* Schmitt enable/disable */
> +#define TEGRA_PIN_DRIVE_SCHMITT_DISABLE 0
> +#define TEGRA_PIN_DRIVE_SCHMITT_ENABLE 1
I expect you can remove "DRIVE_" from all those names to make things
shorter.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>, rob.herring@calxeda.com
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk,
thierry.reding@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants
Date: Tue, 03 Dec 2013 13:05:41 -0700 [thread overview]
Message-ID: <529E3995.8090606@wwwdotorg.org> (raw)
In-Reply-To: <1385992502-12771-1-git-send-email-ldewangan@nvidia.com>
On 12/02/2013 06:55 AM, Laxman Dewangan wrote:
> Defines pincontrol constants to use from Tegra's DTS file
> for tegra pincontrol properties option.
> diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h
> +/* Tristate/normal */
> +#define TEGRA_PIN_NORMAL 0
> +#define TEGRA_PIN_TRISTATE 1
"NORMAL" is a bit generic. "DRIVEN" might work better.
> +/* High speed mode */
> +#define TEGRA_PIN_DRIVE_HIGH_SPEED_MODE_DISABLE 0
> +#define TEGRA_PIN_DRIVE_HIGH_SPEED_MODE_ENABLE 1
> +
> +/* Schmitt enable/disable */
> +#define TEGRA_PIN_DRIVE_SCHMITT_DISABLE 0
> +#define TEGRA_PIN_DRIVE_SCHMITT_ENABLE 1
I expect you can remove "DRIVE_" from all those names to make things
shorter.
next prev parent reply other threads:[~2013-12-03 20:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 13:55 [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants Laxman Dewangan
2013-12-02 13:55 ` Laxman Dewangan
2013-12-02 13:55 ` Laxman Dewangan
2013-12-02 13:55 ` [PATCH 2/2] ARM: tegra: convert device tree file of Dalmore to use pinctrl defines Laxman Dewangan
2013-12-02 13:55 ` Laxman Dewangan
2013-12-02 13:55 ` Laxman Dewangan
[not found] ` <1385992502-12771-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-03 20:09 ` Stephen Warren
2013-12-03 20:09 ` Stephen Warren
2013-12-03 20:09 ` Stephen Warren
[not found] ` <529E3A6E.1050003-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-04 5:51 ` Laxman Dewangan
2013-12-04 5:51 ` Laxman Dewangan
2013-12-04 5:51 ` Laxman Dewangan
2013-12-04 16:59 ` Stephen Warren
2013-12-04 16:59 ` Stephen Warren
[not found] ` <1385992502-12771-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-02 14:25 ` [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants Thierry Reding
2013-12-02 14:25 ` Thierry Reding
2013-12-02 14:25 ` Thierry Reding
[not found] ` <20131202142522.GA17566-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-03 6:04 ` Laxman Dewangan
2013-12-03 6:04 ` Laxman Dewangan
2013-12-03 6:04 ` Laxman Dewangan
[not found] ` <529D745D.2070503-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-03 20:08 ` Stephen Warren
2013-12-03 20:08 ` Stephen Warren
2013-12-03 20:08 ` Stephen Warren
[not found] ` <529E3A34.4030206-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-04 5:49 ` Laxman Dewangan
2013-12-04 5:49 ` Laxman Dewangan
2013-12-04 5:49 ` Laxman Dewangan
2013-12-03 20:05 ` Stephen Warren [this message]
2013-12-03 20:05 ` Stephen Warren
2013-12-03 20:05 ` Stephen Warren
2013-12-03 20:06 ` Stephen Warren
2013-12-03 20:06 ` Stephen Warren
2013-12-03 20:06 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E3995.8090606@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.