From: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
To: Heikki Krogerus
<heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
balbi-l0cyMroinI0@public.gmane.org
Cc: bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH v3 04/10] usb: dwc3: use quirks to know if a particualr platform doesn't have PHY
Date: Thu, 5 Dec 2013 12:04:46 +0530 [thread overview]
Message-ID: <52A01E86.50406@ti.com> (raw)
In-Reply-To: <20131204144027.GB21055@xps8300>
Hi,
On Wednesday 04 December 2013 08:10 PM, Heikki Krogerus wrote:
> Hi guys,
>
> Kishon, sorry I did not see this v3 set.
>
> On Mon, Nov 25, 2013 at 03:31:24PM +0530, Kishon Vijay Abraham I wrote:
>> There can be systems which does not have an external phy, so get
>> phy only if no quirks are added that indicates the PHY is not present.
>> Introduced two quirk flags to indicate the *absence* of usb2 phy and
>> usb3 phy. Also remove checking if return value is -ENXIO since it's now
>> changed to always enable usb_phy layer.
>
> Can you guys explain why is something like this needed? Like with
> clocks and gpios, the device drivers shouldn't need to care any more
> if the platform has the phys or not. -ENODEV tells you your platform
Shouldn't we report if a particular platform needs a PHY and not able to get
it. How will a user know if a particular controller is not working because it's
not able to get and initialize the PHYs? Don't you think in such cases it's
better to fail (and return from probe) because the controller will not work
anyway without the PHY?
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 04/10] usb: dwc3: use quirks to know if a particualr platform doesn't have PHY
Date: Thu, 5 Dec 2013 12:04:46 +0530 [thread overview]
Message-ID: <52A01E86.50406@ti.com> (raw)
In-Reply-To: <20131204144027.GB21055@xps8300>
Hi,
On Wednesday 04 December 2013 08:10 PM, Heikki Krogerus wrote:
> Hi guys,
>
> Kishon, sorry I did not see this v3 set.
>
> On Mon, Nov 25, 2013 at 03:31:24PM +0530, Kishon Vijay Abraham I wrote:
>> There can be systems which does not have an external phy, so get
>> phy only if no quirks are added that indicates the PHY is not present.
>> Introduced two quirk flags to indicate the *absence* of usb2 phy and
>> usb3 phy. Also remove checking if return value is -ENXIO since it's now
>> changed to always enable usb_phy layer.
>
> Can you guys explain why is something like this needed? Like with
> clocks and gpios, the device drivers shouldn't need to care any more
> if the platform has the phys or not. -ENODEV tells you your platform
Shouldn't we report if a particular platform needs a PHY and not able to get
it. How will a user know if a particular controller is not working because it's
not able to get and initialize the PHYs? Don't you think in such cases it's
better to fail (and return from probe) because the controller will not work
anyway without the PHY?
Thanks
Kishon
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>, <balbi@ti.com>
Cc: <bcousson@baylibre.com>, <devicetree@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <rob.herring@calxeda.com>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<swarren@wwwdotorg.org>, <ijc+devicetree@hellion.org.uk>,
<rob@landley.net>, <tony@atomide.com>, <linux@arm.linux.org.uk>,
<gregkh@linuxfoundation.org>, <grant.likely@linaro.org>,
<s.nawrocki@samsung.com>, <galak@codeaurora.org>
Subject: Re: [PATCH v3 04/10] usb: dwc3: use quirks to know if a particualr platform doesn't have PHY
Date: Thu, 5 Dec 2013 12:04:46 +0530 [thread overview]
Message-ID: <52A01E86.50406@ti.com> (raw)
In-Reply-To: <20131204144027.GB21055@xps8300>
Hi,
On Wednesday 04 December 2013 08:10 PM, Heikki Krogerus wrote:
> Hi guys,
>
> Kishon, sorry I did not see this v3 set.
>
> On Mon, Nov 25, 2013 at 03:31:24PM +0530, Kishon Vijay Abraham I wrote:
>> There can be systems which does not have an external phy, so get
>> phy only if no quirks are added that indicates the PHY is not present.
>> Introduced two quirk flags to indicate the *absence* of usb2 phy and
>> usb3 phy. Also remove checking if return value is -ENXIO since it's now
>> changed to always enable usb_phy layer.
>
> Can you guys explain why is something like this needed? Like with
> clocks and gpios, the device drivers shouldn't need to care any more
> if the platform has the phys or not. -ENODEV tells you your platform
Shouldn't we report if a particular platform needs a PHY and not able to get
it. How will a user know if a particular controller is not working because it's
not able to get and initialize the PHYs? Don't you think in such cases it's
better to fail (and return from probe) because the controller will not work
anyway without the PHY?
Thanks
Kishon
next prev parent reply other threads:[~2013-12-05 6:34 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 10:01 [PATCH v3 00/10] Make dwc3 use Generic PHY Framework Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 01/10] usb: dwc3: invoke phy_resume after phy_init Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 02/10] usb: dwc3: power off usb phy in error path Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 03/10] usb: dwc3: preparation for adapting dwc3 to generic phy framework Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 04/10] usb: dwc3: use quirks to know if a particualr platform doesn't have PHY Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 21:21 ` Felipe Balbi
2013-11-25 21:21 ` Felipe Balbi
2013-11-25 21:21 ` Felipe Balbi
2013-12-04 14:40 ` Heikki Krogerus
2013-12-04 14:40 ` Heikki Krogerus
2013-12-05 6:34 ` Kishon Vijay Abraham I [this message]
2013-12-05 6:34 ` Kishon Vijay Abraham I
2013-12-05 6:34 ` Kishon Vijay Abraham I
2013-12-05 7:58 ` Heikki Krogerus
2013-12-05 7:58 ` Heikki Krogerus
2013-12-09 7:13 ` Kishon Vijay Abraham I
2013-12-09 7:13 ` Kishon Vijay Abraham I
2013-12-09 7:13 ` Kishon Vijay Abraham I
2013-12-09 9:26 ` Heikki Krogerus
2013-12-09 9:26 ` Heikki Krogerus
2013-12-11 8:53 ` Heikki Krogerus
2013-12-11 8:53 ` Heikki Krogerus
2013-12-11 9:07 ` Kishon Vijay Abraham I
2013-12-11 9:07 ` Kishon Vijay Abraham I
2013-12-11 9:07 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 05/10] usb: dwc3: adapt dwc3 core to use Generic PHY Framework Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 06/10] Documentation: dt bindings: move ..usb/usb-phy.txt to ..phy/ti-phy.txt Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 07/10] drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-12-06 14:35 ` Roger Quadros
2013-12-06 14:35 ` Roger Quadros
2013-12-06 14:35 ` Roger Quadros
2013-12-10 14:40 ` Kishon Vijay Abraham I
2013-12-10 14:40 ` Kishon Vijay Abraham I
2013-12-10 14:40 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 08/10] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 09/10] phy: omap-usb2: move omap_usb.h from linux/usb/ to linux/phy/ Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` [PATCH v3 10/10] arm/dts: added dt properties to adapt to the new phy framwork Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
2013-11-25 10:01 ` Kishon Vijay Abraham I
[not found] ` <1385373690-12170-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2014-01-21 10:11 ` [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO Kishon Vijay Abraham I
2014-01-21 10:11 ` Kishon Vijay Abraham I
2014-01-21 10:11 ` Kishon Vijay Abraham I
[not found] ` <1390299099-14764-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2014-01-21 10:11 ` [PATCH v4 2/2] usb: dwc3: adapt dwc3 core to use Generic PHY Framework Kishon Vijay Abraham I
2014-01-21 10:11 ` Kishon Vijay Abraham I
2014-01-21 10:11 ` Kishon Vijay Abraham I
2014-01-21 14:00 ` Roger Quadros
2014-01-21 14:00 ` Roger Quadros
2014-01-21 14:00 ` Roger Quadros
2014-01-22 6:04 ` Vivek Gautam
2014-01-22 6:04 ` Vivek Gautam
2014-01-22 7:59 ` Roger Quadros
2014-01-22 7:59 ` Roger Quadros
2014-01-22 7:59 ` Roger Quadros
2014-01-22 10:14 ` Kishon Vijay Abraham I
2014-01-22 10:14 ` Kishon Vijay Abraham I
2014-01-22 10:14 ` Kishon Vijay Abraham I
2014-01-21 13:53 ` [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO Roger Quadros
2014-01-21 13:53 ` Roger Quadros
2014-01-21 13:53 ` Roger Quadros
2014-01-21 14:47 ` Felipe Balbi
2014-01-21 14:47 ` Felipe Balbi
2014-01-21 14:47 ` Felipe Balbi
2014-01-24 14:09 ` Kishon Vijay Abraham I
2014-01-24 14:09 ` Kishon Vijay Abraham I
2014-01-24 14:09 ` Kishon Vijay Abraham I
[not found] ` <20140121144725.GF30451-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-01-27 15:08 ` Heikki Krogerus
2014-01-27 15:08 ` Heikki Krogerus
2014-01-27 15:08 ` Heikki Krogerus
2014-01-27 16:05 ` Felipe Balbi
2014-01-27 16:05 ` Felipe Balbi
2014-01-27 16:05 ` Felipe Balbi
2014-01-28 15:32 ` Heikki Krogerus
2014-01-28 15:32 ` Heikki Krogerus
2014-01-28 16:30 ` Felipe Balbi
2014-01-28 16:30 ` Felipe Balbi
2014-01-28 16:30 ` Felipe Balbi
2014-01-29 14:47 ` Heikki Krogerus
2014-01-29 14:47 ` Heikki Krogerus
2014-02-12 9:46 ` Kishon Vijay Abraham I
2014-02-12 9:46 ` Kishon Vijay Abraham I
2014-02-12 9:46 ` Kishon Vijay Abraham I
[not found] ` <52FB42DE.4090203-l0cyMroinI0@public.gmane.org>
2014-02-19 12:37 ` Roger Quadros
2014-02-19 12:37 ` Roger Quadros
2014-02-19 12:37 ` Roger Quadros
2014-02-21 12:25 ` Kishon Vijay Abraham I
2014-02-21 12:25 ` Kishon Vijay Abraham I
2014-02-21 12:25 ` Kishon Vijay Abraham I
2014-02-21 12:29 ` Roger Quadros
2014-02-21 12:29 ` Roger Quadros
2014-02-21 12:29 ` Roger Quadros
2014-02-24 9:51 ` Kishon Vijay Abraham I
2014-02-24 9:51 ` Kishon Vijay Abraham I
2014-02-24 9:51 ` Kishon Vijay Abraham I
2014-02-24 11:05 ` Roger Quadros
2014-02-24 11:05 ` Roger Quadros
2014-02-24 11:05 ` Roger Quadros
2014-02-24 14:24 ` Kishon Vijay Abraham I
2014-02-24 14:24 ` Kishon Vijay Abraham I
2014-02-24 14:24 ` Kishon Vijay Abraham I
2014-02-24 15:49 ` Felipe Balbi
2014-02-24 15:49 ` Felipe Balbi
2014-02-24 15:49 ` Felipe Balbi
2014-02-24 9:55 ` Kishon Vijay Abraham I
2014-02-24 9:55 ` Kishon Vijay Abraham I
2014-02-24 9:55 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A01E86.50406@ti.com \
--to=kishon-l0cymroini0@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.