From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>, linus.walleij@linaro.org
Cc: rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
thierry.reding@gmail.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi
Date: Thu, 05 Dec 2013 16:16:02 -0700 [thread overview]
Message-ID: <52A10932.1040903@wwwdotorg.org> (raw)
In-Reply-To: <1386241070-4350-3-git-send-email-ldewangan@nvidia.com>
On 12/05/2013 03:57 AM, Laxman Dewangan wrote:
> The tegra124 pinmux controller is identical to tegra114 with
> removing some of existing pins from T114 and adding new pins.
I already sent this patch.
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> + pinmux: pinmux {
Note that the rules for DT node naming have changed recently. Node name
must include a unit address if the node includes a reg property, and not
include a unit address otherwise. So, that should be:
+ pinmux: pinmux@70000868 {
The patch I sent already does that.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi
Date: Thu, 05 Dec 2013 16:16:02 -0700 [thread overview]
Message-ID: <52A10932.1040903@wwwdotorg.org> (raw)
In-Reply-To: <1386241070-4350-3-git-send-email-ldewangan@nvidia.com>
On 12/05/2013 03:57 AM, Laxman Dewangan wrote:
> The tegra124 pinmux controller is identical to tegra114 with
> removing some of existing pins from T114 and adding new pins.
I already sent this patch.
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> + pinmux: pinmux {
Note that the rules for DT node naming have changed recently. Node name
must include a unit address if the node includes a reg property, and not
include a unit address otherwise. So, that should be:
+ pinmux: pinmux at 70000868 {
The patch I sent already does that.
next prev parent reply other threads:[~2013-12-05 23:16 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 10:57 [PATCH 0/4] pinctrl: tegra: Add pincontrol driver for Tegra124 SoC Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
[not found] ` <1386241070-4350-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 10:57 ` [PATCH 1/4] pinctrl: tegra: Add devicetree binding document for Tegra124 Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
[not found] ` <1386241070-4350-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 23:17 ` Stephen Warren
2013-12-05 23:17 ` Stephen Warren
2013-12-05 23:17 ` Stephen Warren
2013-12-06 6:21 ` Laxman Dewangan
2013-12-06 6:21 ` Laxman Dewangan
2013-12-05 10:57 ` [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
2013-12-05 23:16 ` Stephen Warren [this message]
2013-12-05 23:16 ` Stephen Warren
2013-12-05 23:19 ` Stephen Warren
2013-12-05 23:19 ` Stephen Warren
2013-12-06 6:05 ` Laxman Dewangan
2013-12-06 6:05 ` Laxman Dewangan
2013-12-05 10:57 ` [PATCH 3/4] ARM: tegra: select PINCTRL_TEGRA124 for Tegra124 SoC Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
[not found] ` <1386241070-4350-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 23:17 ` Stephen Warren
2013-12-05 23:17 ` Stephen Warren
2013-12-05 23:17 ` Stephen Warren
2013-12-12 18:36 ` Stephen Warren
2013-12-12 18:36 ` Stephen Warren
2013-12-05 10:57 ` [PATCH 4/4] pinctrl: tegra: add pinmux controller driver for Tegra124 Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
2013-12-05 10:57 ` Laxman Dewangan
[not found] ` <1386241070-4350-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 23:30 ` Stephen Warren
2013-12-05 23:30 ` Stephen Warren
2013-12-05 23:30 ` Stephen Warren
2013-12-06 9:58 ` Thierry Reding
2013-12-06 9:58 ` Thierry Reding
[not found] ` <52A10C7B.8070406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-06 6:27 ` Laxman Dewangan
2013-12-06 6:27 ` Laxman Dewangan
2013-12-06 6:27 ` Laxman Dewangan
2013-12-06 17:08 ` Stephen Warren
2013-12-06 17:08 ` Stephen Warren
2013-12-06 11:53 ` [PATCH 1/2] pinctrl: tegra: Various Tegra124 fixes Thierry Reding
[not found] ` <1386330839-30559-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-06 11:53 ` [PATCH 2/2] pinctrl: tegra: Whitespace fixes for Tegra124 Thierry Reding
[not found] ` <1386330839-30559-2-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-11 12:34 ` Linus Walleij
[not found] ` <CACRpkdYKqDgRkuQ4j6AeD+YWkh8r1hPCgjy1k90vQ2w+4vPxxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-11 12:33 ` Laxman Dewangan
2013-12-06 17:10 ` [PATCH 1/2] pinctrl: tegra: Various Tegra124 fixes Stephen Warren
[not found] ` <52A204E9.4080801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-06 19:33 ` Thierry Reding
2013-12-11 12:36 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A10932.1040903@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.