From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
Date: Tue, 10 Dec 2013 11:48:59 +0100 [thread overview]
Message-ID: <52A6F19B.8090309@gmail.com> (raw)
In-Reply-To: <52A6D44C.1010504@gmail.com>
On 12/10/2013 09:43 AM, Haojian Zhuang wrote:
> On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
>> Erratum 71 of PXA270M Processor Family Specification Update
>> (April 19, 2010) explains that watchdog reset time is just
>> 8us insead of 10ms in EMTS.
>>
>> If SDRAM is not reset, it causes memory bus congestion and
>> the device hangs. We put SDRAM in selfresh mode before watchdog
>> reset, removing potential freezes.
>>
>> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
>> reboots. With this patch it has successfully rebooted 500 times.
>>
>> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
>> ---
>> arch/arm/mach-pxa/reset.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
>> index 0d5dd64..263b152 100644
>> --- a/arch/arm/mach-pxa/reset.c
>> +++ b/arch/arm/mach-pxa/reset.c
>> @@ -13,6 +13,7 @@
>>
>> #include <mach/regs-ost.h>
>> #include <mach/reset.h>
>> +#include <mach/smemc.h>
>>
>> unsigned int reset_status;
>> EXPORT_SYMBOL(reset_status);
>> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
>> writel_relaxed(OSSR_M3, OSSR);
>> /* ... in 100 ms */
>> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
>> + /*
>> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
>> + * we put SDRAM into self-refresh to prevent that
>> + */
>> + while (1)
>> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
>> }
>>
>> void pxa_restart(enum reboot_mode mode, const char *cmd)
>> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char *cmd)
>> break;
>> }
>> }
>> -
>>
>
> Hi Daniel/Marek/Igor,
>
> Could you help to try this patch? I'm lack of PXA27x board.
I don't have any either right now ...
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Mack <zonque@gmail.com>
To: Haojian Zhuang <haojian.zhuang@gmail.com>,
Sergei Ianovich <ynvich@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Eric Miao <eric.y.miao@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Marek Vasut <marex@denx.de>,
Igor Grinberg <grinberg@compulab.co.il>
Subject: Re: [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
Date: Tue, 10 Dec 2013 11:48:59 +0100 [thread overview]
Message-ID: <52A6F19B.8090309@gmail.com> (raw)
In-Reply-To: <52A6D44C.1010504@gmail.com>
On 12/10/2013 09:43 AM, Haojian Zhuang wrote:
> On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
>> Erratum 71 of PXA270M Processor Family Specification Update
>> (April 19, 2010) explains that watchdog reset time is just
>> 8us insead of 10ms in EMTS.
>>
>> If SDRAM is not reset, it causes memory bus congestion and
>> the device hangs. We put SDRAM in selfresh mode before watchdog
>> reset, removing potential freezes.
>>
>> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
>> reboots. With this patch it has successfully rebooted 500 times.
>>
>> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
>> ---
>> arch/arm/mach-pxa/reset.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
>> index 0d5dd64..263b152 100644
>> --- a/arch/arm/mach-pxa/reset.c
>> +++ b/arch/arm/mach-pxa/reset.c
>> @@ -13,6 +13,7 @@
>>
>> #include <mach/regs-ost.h>
>> #include <mach/reset.h>
>> +#include <mach/smemc.h>
>>
>> unsigned int reset_status;
>> EXPORT_SYMBOL(reset_status);
>> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
>> writel_relaxed(OSSR_M3, OSSR);
>> /* ... in 100 ms */
>> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
>> + /*
>> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
>> + * we put SDRAM into self-refresh to prevent that
>> + */
>> + while (1)
>> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
>> }
>>
>> void pxa_restart(enum reboot_mode mode, const char *cmd)
>> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char *cmd)
>> break;
>> }
>> }
>> -
>>
>
> Hi Daniel/Marek/Igor,
>
> Could you help to try this patch? I'm lack of PXA27x board.
I don't have any either right now ...
Daniel
next prev parent reply other threads:[~2013-12-10 10:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 4:39 [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes Sergei Ianovich
2013-12-10 4:39 ` Sergei Ianovich
2013-12-10 8:43 ` Haojian Zhuang
2013-12-10 8:43 ` Haojian Zhuang
2013-12-10 10:48 ` Daniel Mack [this message]
2013-12-10 10:48 ` Daniel Mack
2013-12-10 18:31 ` Marek Vasut
2013-12-10 18:31 ` Marek Vasut
2013-12-11 7:18 ` Haojian Zhuang
2013-12-11 7:18 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6F19B.8090309@gmail.com \
--to=zonque@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.