* [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
@ 2013-12-10 4:39 ` Sergei Ianovich
0 siblings, 0 replies; 10+ messages in thread
From: Sergei Ianovich @ 2013-12-10 4:39 UTC (permalink / raw)
To: linux-arm-kernel
Erratum 71 of PXA270M Processor Family Specification Update
(April 19, 2010) explains that watchdog reset time is just
8us insead of 10ms in EMTS.
If SDRAM is not reset, it causes memory bus congestion and
the device hangs. We put SDRAM in selfresh mode before watchdog
reset, removing potential freezes.
Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
reboots. With this patch it has successfully rebooted 500 times.
Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
---
arch/arm/mach-pxa/reset.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
index 0d5dd64..263b152 100644
--- a/arch/arm/mach-pxa/reset.c
+++ b/arch/arm/mach-pxa/reset.c
@@ -13,6 +13,7 @@
#include <mach/regs-ost.h>
#include <mach/reset.h>
+#include <mach/smemc.h>
unsigned int reset_status;
EXPORT_SYMBOL(reset_status);
@@ -81,6 +82,12 @@ static void do_hw_reset(void)
writel_relaxed(OSSR_M3, OSSR);
/* ... in 100 ms */
writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
+ /*
+ * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
+ * we put SDRAM into self-refresh to prevent that
+ */
+ while (1)
+ writel_relaxed(MDREFR_SLFRSH, MDREFR);
}
void pxa_restart(enum reboot_mode mode, const char *cmd)
@@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char *cmd)
break;
}
}
-
--
1.8.4.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
@ 2013-12-10 4:39 ` Sergei Ianovich
0 siblings, 0 replies; 10+ messages in thread
From: Sergei Ianovich @ 2013-12-10 4:39 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel
Cc: Sergei Ianovich, Eric Miao, Russell King, Haojian Zhuang
Erratum 71 of PXA270M Processor Family Specification Update
(April 19, 2010) explains that watchdog reset time is just
8us insead of 10ms in EMTS.
If SDRAM is not reset, it causes memory bus congestion and
the device hangs. We put SDRAM in selfresh mode before watchdog
reset, removing potential freezes.
Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
reboots. With this patch it has successfully rebooted 500 times.
Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
---
arch/arm/mach-pxa/reset.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
index 0d5dd64..263b152 100644
--- a/arch/arm/mach-pxa/reset.c
+++ b/arch/arm/mach-pxa/reset.c
@@ -13,6 +13,7 @@
#include <mach/regs-ost.h>
#include <mach/reset.h>
+#include <mach/smemc.h>
unsigned int reset_status;
EXPORT_SYMBOL(reset_status);
@@ -81,6 +82,12 @@ static void do_hw_reset(void)
writel_relaxed(OSSR_M3, OSSR);
/* ... in 100 ms */
writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
+ /*
+ * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
+ * we put SDRAM into self-refresh to prevent that
+ */
+ while (1)
+ writel_relaxed(MDREFR_SLFRSH, MDREFR);
}
void pxa_restart(enum reboot_mode mode, const char *cmd)
@@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char *cmd)
break;
}
}
-
--
1.8.4.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
2013-12-10 4:39 ` Sergei Ianovich
@ 2013-12-10 8:43 ` Haojian Zhuang
-1 siblings, 0 replies; 10+ messages in thread
From: Haojian Zhuang @ 2013-12-10 8:43 UTC (permalink / raw)
To: linux-arm-kernel
On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
> Erratum 71 of PXA270M Processor Family Specification Update
> (April 19, 2010) explains that watchdog reset time is just
> 8us insead of 10ms in EMTS.
>
> If SDRAM is not reset, it causes memory bus congestion and
> the device hangs. We put SDRAM in selfresh mode before watchdog
> reset, removing potential freezes.
>
> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
> reboots. With this patch it has successfully rebooted 500 times.
>
> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
> ---
> arch/arm/mach-pxa/reset.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
> index 0d5dd64..263b152 100644
> --- a/arch/arm/mach-pxa/reset.c
> +++ b/arch/arm/mach-pxa/reset.c
> @@ -13,6 +13,7 @@
>
> #include <mach/regs-ost.h>
> #include <mach/reset.h>
> +#include <mach/smemc.h>
>
> unsigned int reset_status;
> EXPORT_SYMBOL(reset_status);
> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
> writel_relaxed(OSSR_M3, OSSR);
> /* ... in 100 ms */
> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
> + /*
> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
> + * we put SDRAM into self-refresh to prevent that
> + */
> + while (1)
> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
> }
>
> void pxa_restart(enum reboot_mode mode, const char *cmd)
> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char *cmd)
> break;
> }
> }
> -
>
Hi Daniel/Marek/Igor,
Could you help to try this patch? I'm lack of PXA27x board.
Best Regards
Haojian
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
@ 2013-12-10 8:43 ` Haojian Zhuang
0 siblings, 0 replies; 10+ messages in thread
From: Haojian Zhuang @ 2013-12-10 8:43 UTC (permalink / raw)
To: Sergei Ianovich, linux-kernel, linux-arm-kernel
Cc: Eric Miao, Russell King, Daniel Mack, Marek Vasut, Igor Grinberg
On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
> Erratum 71 of PXA270M Processor Family Specification Update
> (April 19, 2010) explains that watchdog reset time is just
> 8us insead of 10ms in EMTS.
>
> If SDRAM is not reset, it causes memory bus congestion and
> the device hangs. We put SDRAM in selfresh mode before watchdog
> reset, removing potential freezes.
>
> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
> reboots. With this patch it has successfully rebooted 500 times.
>
> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
> ---
> arch/arm/mach-pxa/reset.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
> index 0d5dd64..263b152 100644
> --- a/arch/arm/mach-pxa/reset.c
> +++ b/arch/arm/mach-pxa/reset.c
> @@ -13,6 +13,7 @@
>
> #include <mach/regs-ost.h>
> #include <mach/reset.h>
> +#include <mach/smemc.h>
>
> unsigned int reset_status;
> EXPORT_SYMBOL(reset_status);
> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
> writel_relaxed(OSSR_M3, OSSR);
> /* ... in 100 ms */
> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
> + /*
> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
> + * we put SDRAM into self-refresh to prevent that
> + */
> + while (1)
> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
> }
>
> void pxa_restart(enum reboot_mode mode, const char *cmd)
> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char *cmd)
> break;
> }
> }
> -
>
Hi Daniel/Marek/Igor,
Could you help to try this patch? I'm lack of PXA27x board.
Best Regards
Haojian
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
2013-12-10 8:43 ` Haojian Zhuang
@ 2013-12-10 10:48 ` Daniel Mack
-1 siblings, 0 replies; 10+ messages in thread
From: Daniel Mack @ 2013-12-10 10:48 UTC (permalink / raw)
To: linux-arm-kernel
On 12/10/2013 09:43 AM, Haojian Zhuang wrote:
> On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
>> Erratum 71 of PXA270M Processor Family Specification Update
>> (April 19, 2010) explains that watchdog reset time is just
>> 8us insead of 10ms in EMTS.
>>
>> If SDRAM is not reset, it causes memory bus congestion and
>> the device hangs. We put SDRAM in selfresh mode before watchdog
>> reset, removing potential freezes.
>>
>> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
>> reboots. With this patch it has successfully rebooted 500 times.
>>
>> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
>> ---
>> arch/arm/mach-pxa/reset.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
>> index 0d5dd64..263b152 100644
>> --- a/arch/arm/mach-pxa/reset.c
>> +++ b/arch/arm/mach-pxa/reset.c
>> @@ -13,6 +13,7 @@
>>
>> #include <mach/regs-ost.h>
>> #include <mach/reset.h>
>> +#include <mach/smemc.h>
>>
>> unsigned int reset_status;
>> EXPORT_SYMBOL(reset_status);
>> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
>> writel_relaxed(OSSR_M3, OSSR);
>> /* ... in 100 ms */
>> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
>> + /*
>> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
>> + * we put SDRAM into self-refresh to prevent that
>> + */
>> + while (1)
>> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
>> }
>>
>> void pxa_restart(enum reboot_mode mode, const char *cmd)
>> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char *cmd)
>> break;
>> }
>> }
>> -
>>
>
> Hi Daniel/Marek/Igor,
>
> Could you help to try this patch? I'm lack of PXA27x board.
I don't have any either right now ...
Daniel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
@ 2013-12-10 10:48 ` Daniel Mack
0 siblings, 0 replies; 10+ messages in thread
From: Daniel Mack @ 2013-12-10 10:48 UTC (permalink / raw)
To: Haojian Zhuang, Sergei Ianovich, linux-kernel, linux-arm-kernel
Cc: Eric Miao, Russell King, Marek Vasut, Igor Grinberg
On 12/10/2013 09:43 AM, Haojian Zhuang wrote:
> On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
>> Erratum 71 of PXA270M Processor Family Specification Update
>> (April 19, 2010) explains that watchdog reset time is just
>> 8us insead of 10ms in EMTS.
>>
>> If SDRAM is not reset, it causes memory bus congestion and
>> the device hangs. We put SDRAM in selfresh mode before watchdog
>> reset, removing potential freezes.
>>
>> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
>> reboots. With this patch it has successfully rebooted 500 times.
>>
>> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
>> ---
>> arch/arm/mach-pxa/reset.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
>> index 0d5dd64..263b152 100644
>> --- a/arch/arm/mach-pxa/reset.c
>> +++ b/arch/arm/mach-pxa/reset.c
>> @@ -13,6 +13,7 @@
>>
>> #include <mach/regs-ost.h>
>> #include <mach/reset.h>
>> +#include <mach/smemc.h>
>>
>> unsigned int reset_status;
>> EXPORT_SYMBOL(reset_status);
>> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
>> writel_relaxed(OSSR_M3, OSSR);
>> /* ... in 100 ms */
>> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
>> + /*
>> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
>> + * we put SDRAM into self-refresh to prevent that
>> + */
>> + while (1)
>> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
>> }
>>
>> void pxa_restart(enum reboot_mode mode, const char *cmd)
>> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char *cmd)
>> break;
>> }
>> }
>> -
>>
>
> Hi Daniel/Marek/Igor,
>
> Could you help to try this patch? I'm lack of PXA27x board.
I don't have any either right now ...
Daniel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
2013-12-10 10:48 ` Daniel Mack
@ 2013-12-10 18:31 ` Marek Vasut
-1 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2013-12-10 18:31 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, December 10, 2013 at 11:48:59 AM, Daniel Mack wrote:
> On 12/10/2013 09:43 AM, Haojian Zhuang wrote:
> > On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
> >> Erratum 71 of PXA270M Processor Family Specification Update
> >> (April 19, 2010) explains that watchdog reset time is just
> >> 8us insead of 10ms in EMTS.
> >>
> >> If SDRAM is not reset, it causes memory bus congestion and
> >> the device hangs. We put SDRAM in selfresh mode before watchdog
> >> reset, removing potential freezes.
> >>
> >> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
> >> reboots. With this patch it has successfully rebooted 500 times.
> >>
> >> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
> >> ---
> >>
> >> arch/arm/mach-pxa/reset.c | 8 +++++++-
> >> 1 file changed, 7 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
> >> index 0d5dd64..263b152 100644
> >> --- a/arch/arm/mach-pxa/reset.c
> >> +++ b/arch/arm/mach-pxa/reset.c
> >> @@ -13,6 +13,7 @@
> >>
> >> #include <mach/regs-ost.h>
> >> #include <mach/reset.h>
> >>
> >> +#include <mach/smemc.h>
> >>
> >> unsigned int reset_status;
> >> EXPORT_SYMBOL(reset_status);
> >>
> >> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
> >>
> >> writel_relaxed(OSSR_M3, OSSR);
> >> /* ... in 100 ms */
> >> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
> >>
> >> + /*
> >> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
> >> + * we put SDRAM into self-refresh to prevent that
> >> + */
> >> + while (1)
> >> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
> >>
> >> }
> >>
> >> void pxa_restart(enum reboot_mode mode, const char *cmd)
> >>
> >> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char
> >> *cmd)
> >>
> >> break;
> >>
> >> }
> >>
> >> }
> >>
> >> -
> >
> > Hi Daniel/Marek/Igor,
> >
> > Could you help to try this patch? I'm lack of PXA27x board.
>
> I don't have any either right now ...
On VPAC270
Tested-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
@ 2013-12-10 18:31 ` Marek Vasut
0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2013-12-10 18:31 UTC (permalink / raw)
To: Daniel Mack
Cc: Haojian Zhuang, Sergei Ianovich, linux-kernel, linux-arm-kernel,
Eric Miao, Russell King, Igor Grinberg
On Tuesday, December 10, 2013 at 11:48:59 AM, Daniel Mack wrote:
> On 12/10/2013 09:43 AM, Haojian Zhuang wrote:
> > On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
> >> Erratum 71 of PXA270M Processor Family Specification Update
> >> (April 19, 2010) explains that watchdog reset time is just
> >> 8us insead of 10ms in EMTS.
> >>
> >> If SDRAM is not reset, it causes memory bus congestion and
> >> the device hangs. We put SDRAM in selfresh mode before watchdog
> >> reset, removing potential freezes.
> >>
> >> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
> >> reboots. With this patch it has successfully rebooted 500 times.
> >>
> >> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
> >> ---
> >>
> >> arch/arm/mach-pxa/reset.c | 8 +++++++-
> >> 1 file changed, 7 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
> >> index 0d5dd64..263b152 100644
> >> --- a/arch/arm/mach-pxa/reset.c
> >> +++ b/arch/arm/mach-pxa/reset.c
> >> @@ -13,6 +13,7 @@
> >>
> >> #include <mach/regs-ost.h>
> >> #include <mach/reset.h>
> >>
> >> +#include <mach/smemc.h>
> >>
> >> unsigned int reset_status;
> >> EXPORT_SYMBOL(reset_status);
> >>
> >> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
> >>
> >> writel_relaxed(OSSR_M3, OSSR);
> >> /* ... in 100 ms */
> >> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
> >>
> >> + /*
> >> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
> >> + * we put SDRAM into self-refresh to prevent that
> >> + */
> >> + while (1)
> >> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
> >>
> >> }
> >>
> >> void pxa_restart(enum reboot_mode mode, const char *cmd)
> >>
> >> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char
> >> *cmd)
> >>
> >> break;
> >>
> >> }
> >>
> >> }
> >>
> >> -
> >
> > Hi Daniel/Marek/Igor,
> >
> > Could you help to try this patch? I'm lack of PXA27x board.
>
> I don't have any either right now ...
On VPAC270
Tested-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
2013-12-10 18:31 ` Marek Vasut
@ 2013-12-11 7:18 ` Haojian Zhuang
-1 siblings, 0 replies; 10+ messages in thread
From: Haojian Zhuang @ 2013-12-11 7:18 UTC (permalink / raw)
To: linux-arm-kernel
On 12/11/2013 02:31 AM, Marek Vasut wrote:
> On Tuesday, December 10, 2013 at 11:48:59 AM, Daniel Mack wrote:
>> On 12/10/2013 09:43 AM, Haojian Zhuang wrote:
>>> On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
>>>> Erratum 71 of PXA270M Processor Family Specification Update
>>>> (April 19, 2010) explains that watchdog reset time is just
>>>> 8us insead of 10ms in EMTS.
>>>>
>>>> If SDRAM is not reset, it causes memory bus congestion and
>>>> the device hangs. We put SDRAM in selfresh mode before watchdog
>>>> reset, removing potential freezes.
>>>>
>>>> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
>>>> reboots. With this patch it has successfully rebooted 500 times.
>>>>
>>>> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
>>>> ---
>>>>
>>>> arch/arm/mach-pxa/reset.c | 8 +++++++-
>>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
>>>> index 0d5dd64..263b152 100644
>>>> --- a/arch/arm/mach-pxa/reset.c
>>>> +++ b/arch/arm/mach-pxa/reset.c
>>>> @@ -13,6 +13,7 @@
>>>>
>>>> #include <mach/regs-ost.h>
>>>> #include <mach/reset.h>
>>>>
>>>> +#include <mach/smemc.h>
>>>>
>>>> unsigned int reset_status;
>>>> EXPORT_SYMBOL(reset_status);
>>>>
>>>> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
>>>>
>>>> writel_relaxed(OSSR_M3, OSSR);
>>>> /* ... in 100 ms */
>>>> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
>>>>
>>>> + /*
>>>> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
>>>> + * we put SDRAM into self-refresh to prevent that
>>>> + */
>>>> + while (1)
>>>> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
>>>>
>>>> }
>>>>
>>>> void pxa_restart(enum reboot_mode mode, const char *cmd)
>>>>
>>>> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char
>>>> *cmd)
>>>>
>>>> break;
>>>>
>>>> }
>>>>
>>>> }
>>>>
>>>> -
>>>
>>> Hi Daniel/Marek/Igor,
>>>
>>> Could you help to try this patch? I'm lack of PXA27x board.
>>
>> I don't have any either right now ...
>
> On VPAC270
>
> Tested-by: Marek Vasut <marex@denx.de>
>
> Best regards,
> Marek Vasut
>
Applied.
Thanks
Haojian
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes
@ 2013-12-11 7:18 ` Haojian Zhuang
0 siblings, 0 replies; 10+ messages in thread
From: Haojian Zhuang @ 2013-12-11 7:18 UTC (permalink / raw)
To: Marek Vasut, Daniel Mack
Cc: Sergei Ianovich, linux-kernel, linux-arm-kernel, Eric Miao,
Russell King, Igor Grinberg
On 12/11/2013 02:31 AM, Marek Vasut wrote:
> On Tuesday, December 10, 2013 at 11:48:59 AM, Daniel Mack wrote:
>> On 12/10/2013 09:43 AM, Haojian Zhuang wrote:
>>> On 12/10/2013 12:39 PM, Sergei Ianovich wrote:
>>>> Erratum 71 of PXA270M Processor Family Specification Update
>>>> (April 19, 2010) explains that watchdog reset time is just
>>>> 8us insead of 10ms in EMTS.
>>>>
>>>> If SDRAM is not reset, it causes memory bus congestion and
>>>> the device hangs. We put SDRAM in selfresh mode before watchdog
>>>> reset, removing potential freezes.
>>>>
>>>> Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
>>>> reboots. With this patch it has successfully rebooted 500 times.
>>>>
>>>> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
>>>> ---
>>>>
>>>> arch/arm/mach-pxa/reset.c | 8 +++++++-
>>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c
>>>> index 0d5dd64..263b152 100644
>>>> --- a/arch/arm/mach-pxa/reset.c
>>>> +++ b/arch/arm/mach-pxa/reset.c
>>>> @@ -13,6 +13,7 @@
>>>>
>>>> #include <mach/regs-ost.h>
>>>> #include <mach/reset.h>
>>>>
>>>> +#include <mach/smemc.h>
>>>>
>>>> unsigned int reset_status;
>>>> EXPORT_SYMBOL(reset_status);
>>>>
>>>> @@ -81,6 +82,12 @@ static void do_hw_reset(void)
>>>>
>>>> writel_relaxed(OSSR_M3, OSSR);
>>>> /* ... in 100 ms */
>>>> writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
>>>>
>>>> + /*
>>>> + * SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
>>>> + * we put SDRAM into self-refresh to prevent that
>>>> + */
>>>> + while (1)
>>>> + writel_relaxed(MDREFR_SLFRSH, MDREFR);
>>>>
>>>> }
>>>>
>>>> void pxa_restart(enum reboot_mode mode, const char *cmd)
>>>>
>>>> @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char
>>>> *cmd)
>>>>
>>>> break;
>>>>
>>>> }
>>>>
>>>> }
>>>>
>>>> -
>>>
>>> Hi Daniel/Marek/Igor,
>>>
>>> Could you help to try this patch? I'm lack of PXA27x board.
>>
>> I don't have any either right now ...
>
> On VPAC270
>
> Tested-by: Marek Vasut <marex@denx.de>
>
> Best regards,
> Marek Vasut
>
Applied.
Thanks
Haojian
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-12-11 7:18 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-10 4:39 [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes Sergei Ianovich
2013-12-10 4:39 ` Sergei Ianovich
2013-12-10 8:43 ` Haojian Zhuang
2013-12-10 8:43 ` Haojian Zhuang
2013-12-10 10:48 ` Daniel Mack
2013-12-10 10:48 ` Daniel Mack
2013-12-10 18:31 ` Marek Vasut
2013-12-10 18:31 ` Marek Vasut
2013-12-11 7:18 ` Haojian Zhuang
2013-12-11 7:18 ` Haojian Zhuang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.