From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH 1/2] evtchn/fifo: initialize priority when events are bound
Date: Tue, 10 Dec 2013 14:54:52 +0000 [thread overview]
Message-ID: <52A72B3C.7080009@citrix.com> (raw)
In-Reply-To: <52A73830020000780010BE4E@nat28.tlf.novell.com>
On 10/12/13 14:50, Jan Beulich wrote:
>>>> On 10.12.13 at 14:56, David Vrabel <david.vrabel@citrix.com> wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> Event channel ports that are reused or that were not in the initial
>> bucket would have a non-default priority.
>>
>> Add an init evtchn_port_op hook and use this to set the priority when
>> an event channel is bound.
>>
>> Within this new evtchn_fifo_init() call, also check if the event is
>> already on a queue and print a warning, as this event may have its
>> first event delivered on a queue with the wrong VCPU or priority.
>> This guest is expected to prevent this (if it cares) by not unbinding
>> events that are still linked.
>>
>
> Reported-by: Jan Beulich <jbeulich@suse.com>
Yes, sorry. Not the first time I've not properly attributed someone. I
shall have to be more careful in future.
>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
Thanks!
David
next prev parent reply other threads:[~2013-12-10 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 13:56 [PATCHv7 0/2] Xen: FIFO-based event channel fixes David Vrabel
2013-12-10 13:56 ` [PATCH 1/2] evtchn/fifo: initialize priority when events are bound David Vrabel
2013-12-10 14:50 ` Jan Beulich
2013-12-10 14:54 ` David Vrabel [this message]
2013-12-16 13:45 ` David Vrabel
2014-01-06 18:04 ` David Vrabel
2014-01-07 15:50 ` Keir Fraser
2013-12-10 13:57 ` [PATCH 2/2] evtchn/fifo: don't corrupt queues if an old tail is linked David Vrabel
2013-12-10 14:55 ` Jan Beulich
2014-01-07 15:50 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A72B3C.7080009@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.