From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/6] net: mv643xx_eth: properly start/stop phy device
Date: Wed, 11 Dec 2013 08:06:36 +0100 [thread overview]
Message-ID: <52A80EFC.8070806@gmail.com> (raw)
In-Reply-To: <20131210.215654.1165181423931409066.davem@davemloft.net>
On 12/11/2013 03:56 AM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 10 Dec 2013 21:52:53 -0500 (EST)
>
>>
>> This series looks good, applied to net-next, thanks.
>
> Actually, I had to revert.
>
> You cannot use late_initcall_sync() from code that is potentially
> built modular, this caused my build to fail at the mdio_bus code.
>
> drivers/net/phy/mdio_bus.c:344:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/phy/mdio_bus.c:344:1: error: type defaults to ?int? in declaration of ?late_initcall_sync? [-Werror=implicit-int]
> drivers/net/phy/mdio_bus.c:344:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/net/phy/mdio_bus.c:339:12: warning: ?mdio_bus_class_suspend_unused? defined but not used [-Wunused-function]
>
Hmm, I see. What about you drop patch 5 ("net: phy: suspend unused PHYs
on mdio_bus in late_initcall"), take the rest, and I'll have look at
suspending unused PHYs later?
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: f.fainelli@gmail.com, mugunthanvnm@ti.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/6] net: mv643xx_eth: properly start/stop phy device
Date: Wed, 11 Dec 2013 08:06:36 +0100 [thread overview]
Message-ID: <52A80EFC.8070806@gmail.com> (raw)
In-Reply-To: <20131210.215654.1165181423931409066.davem@davemloft.net>
On 12/11/2013 03:56 AM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 10 Dec 2013 21:52:53 -0500 (EST)
>
>>
>> This series looks good, applied to net-next, thanks.
>
> Actually, I had to revert.
>
> You cannot use late_initcall_sync() from code that is potentially
> built modular, this caused my build to fail at the mdio_bus code.
>
> drivers/net/phy/mdio_bus.c:344:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/phy/mdio_bus.c:344:1: error: type defaults to ‘int’ in declaration of ‘late_initcall_sync’ [-Werror=implicit-int]
> drivers/net/phy/mdio_bus.c:344:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/net/phy/mdio_bus.c:339:12: warning: ‘mdio_bus_class_suspend_unused’ defined but not used [-Wunused-function]
>
Hmm, I see. What about you drop patch 5 ("net: phy: suspend unused PHYs
on mdio_bus in late_initcall"), take the rest, and I'll have look at
suspending unused PHYs later?
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: f.fainelli@gmail.com, mugunthanvnm@ti.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/6] net: mv643xx_eth: properly start/stop phy device
Date: Wed, 11 Dec 2013 08:06:36 +0100 [thread overview]
Message-ID: <52A80EFC.8070806@gmail.com> (raw)
In-Reply-To: <20131210.215654.1165181423931409066.davem@davemloft.net>
On 12/11/2013 03:56 AM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 10 Dec 2013 21:52:53 -0500 (EST)
>
>>
>> This series looks good, applied to net-next, thanks.
>
> Actually, I had to revert.
>
> You cannot use late_initcall_sync() from code that is potentially
> built modular, this caused my build to fail at the mdio_bus code.
>
> drivers/net/phy/mdio_bus.c:344:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/phy/mdio_bus.c:344:1: error: type defaults to ¡int¢ in declaration of ¡late_initcall_sync¢ [-Werror=implicit-int]
> drivers/net/phy/mdio_bus.c:344:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/net/phy/mdio_bus.c:339:12: warning: ¡mdio_bus_class_suspend_unused¢ defined but not used [-Wunused-function]
>
Hmm, I see. What about you drop patch 5 ("net: phy: suspend unused PHYs
on mdio_bus in late_initcall"), take the rest, and I'll have look at
suspending unused PHYs later?
Sebastian
next prev parent reply other threads:[~2013-12-11 7:06 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 20:21 [PATCH RFC v1 0/7] net: phy: Ethernet PHY powerdown optimization Sebastian Hesselbarth
2013-11-20 20:21 ` Sebastian Hesselbarth
2013-11-20 20:21 ` [PATCH RFC v1 1/7] net: phy: marvell: provide genphy suspend/resume Sebastian Hesselbarth
2013-11-20 20:21 ` Sebastian Hesselbarth
2013-11-20 20:21 ` Sebastian Hesselbarth
2013-11-20 20:21 ` [PATCH RFC v1 2/7] net: phy: provide phy_resume/phy_suspend helpers Sebastian Hesselbarth
2013-11-20 20:21 ` Sebastian Hesselbarth
2013-11-20 20:36 ` Florian Fainelli
2013-11-20 20:36 ` Florian Fainelli
2013-11-20 20:21 ` [PATCH RFC v1 3/7] net: phy: resume/suspend PHYs on attach/detach Sebastian Hesselbarth
2013-11-20 20:21 ` Sebastian Hesselbarth
2013-11-20 20:21 ` [PATCH RFC v1 4/7] net: phy: suspend unused PHYs on mdio_bus in late_initcall Sebastian Hesselbarth
2013-11-20 20:21 ` Sebastian Hesselbarth
2013-11-20 20:58 ` Florian Fainelli
2013-11-20 20:58 ` Florian Fainelli
2013-11-20 21:05 ` Sebastian Hesselbarth
2013-11-20 21:05 ` Sebastian Hesselbarth
2013-11-20 22:36 ` Florian Fainelli
2013-11-20 22:36 ` Florian Fainelli
2013-11-20 20:21 ` [PATCH RFC v1 5/7] net: mv643xx_eth: resume/suspend PHY on port start/stop Sebastian Hesselbarth
2013-11-20 20:21 ` Sebastian Hesselbarth
2013-11-20 20:21 ` [PATCH RFC v1 6/7] net: mvneta: " Sebastian Hesselbarth
2013-11-20 20:21 ` Sebastian Hesselbarth
2013-11-20 20:21 ` [PATCH RFC v1 7/7] net: cpsw: " Sebastian Hesselbarth
2013-11-20 20:21 ` Sebastian Hesselbarth
2013-11-20 20:48 ` Florian Fainelli
2013-11-20 20:48 ` Florian Fainelli
2013-11-20 20:57 ` Sebastian Hesselbarth
2013-11-20 20:57 ` Sebastian Hesselbarth
2013-11-21 8:35 ` Mugunthan V N
2013-11-21 8:35 ` Mugunthan V N
2013-11-21 8:35 ` Mugunthan V N
2013-11-21 8:41 ` Sebastian Hesselbarth
2013-11-21 8:41 ` Sebastian Hesselbarth
2013-11-20 20:36 ` [PATCH RFC v1 0/7] net: phy: Ethernet PHY powerdown optimization David Miller
2013-11-20 20:36 ` David Miller
2013-11-20 20:54 ` Sebastian Hesselbarth
2013-11-20 20:54 ` Sebastian Hesselbarth
2013-11-20 21:10 ` Florian Fainelli
2013-11-20 21:10 ` Florian Fainelli
2013-11-20 21:20 ` Sebastian Hesselbarth
2013-11-20 21:20 ` Sebastian Hesselbarth
2013-11-20 22:15 ` David Miller
2013-11-20 22:15 ` David Miller
2013-12-04 15:44 ` [PATCH RFCv2 0/6] " Sebastian Hesselbarth
2013-12-04 15:44 ` Sebastian Hesselbarth
2013-12-04 15:44 ` Sebastian Hesselbarth
2013-12-05 7:57 ` Mugunthan V N
2013-12-05 7:57 ` Mugunthan V N
2013-12-06 0:16 ` Florian Fainelli
2013-12-06 0:16 ` Florian Fainelli
2013-12-08 14:40 ` [PATCH v1 " Sebastian Hesselbarth
2013-12-08 14:40 ` Sebastian Hesselbarth
2013-12-08 14:40 ` [PATCH v1 1/6] net: mv643xx_eth: properly start/stop phy device Sebastian Hesselbarth
2013-12-08 14:40 ` Sebastian Hesselbarth
2013-12-11 2:52 ` David Miller
2013-12-11 2:52 ` David Miller
2013-12-11 2:56 ` David Miller
2013-12-11 2:56 ` David Miller
2013-12-11 2:56 ` David Miller
2013-12-11 7:06 ` Sebastian Hesselbarth [this message]
2013-12-11 7:06 ` Sebastian Hesselbarth
2013-12-11 7:06 ` Sebastian Hesselbarth
2013-12-11 17:28 ` David Miller
2013-12-11 17:28 ` David Miller
2013-12-11 17:28 ` David Miller
2013-12-08 14:40 ` [PATCH v1 2/6] net: phy: marvell: provide genphy suspend/resume Sebastian Hesselbarth
2013-12-08 14:40 ` Sebastian Hesselbarth
2013-12-08 14:40 ` [PATCH v1 3/6] net: phy: provide phy_resume/phy_suspend helpers Sebastian Hesselbarth
2013-12-08 14:40 ` Sebastian Hesselbarth
2013-12-08 14:40 ` [PATCH v1 4/6] net: phy: resume/suspend PHYs on attach/detach Sebastian Hesselbarth
2013-12-08 14:40 ` Sebastian Hesselbarth
2013-12-08 14:40 ` [PATCH v1 5/6] net: phy: suspend unused PHYs on mdio_bus in late_initcall Sebastian Hesselbarth
2013-12-08 14:40 ` Sebastian Hesselbarth
2013-12-08 14:40 ` [PATCH v1 6/6] net: phy: suspend phydev when going to HALTED Sebastian Hesselbarth
2013-12-08 14:40 ` Sebastian Hesselbarth
2013-12-13 9:20 ` [PATCH v2 0/5] net: phy: Ethernet PHY powerdown optimization Sebastian Hesselbarth
2013-12-13 9:20 ` Sebastian Hesselbarth
2013-12-17 19:43 ` David Miller
2013-12-17 19:43 ` David Miller
2014-02-04 19:38 ` Sebastian Hesselbarth
2014-02-04 19:38 ` Sebastian Hesselbarth
2014-02-04 22:51 ` Florian Fainelli
2014-02-04 22:51 ` Florian Fainelli
2014-02-06 16:57 ` Ezequiel Garcia
2014-02-06 16:57 ` Ezequiel Garcia
2013-12-13 9:20 ` [PATCH v2 1/5] net: mv643xx_eth: properly start/stop phy device Sebastian Hesselbarth
2013-12-13 9:20 ` Sebastian Hesselbarth
2013-12-13 9:20 ` [PATCH v2 2/5] net: phy: marvell: provide genphy suspend/resume Sebastian Hesselbarth
2013-12-13 9:20 ` Sebastian Hesselbarth
2013-12-13 9:20 ` [PATCH v2 3/5] net: phy: provide phy_resume/phy_suspend helpers Sebastian Hesselbarth
2013-12-13 9:20 ` Sebastian Hesselbarth
2013-12-13 9:20 ` [PATCH v2 4/5] net: phy: resume/suspend PHYs on attach/detach Sebastian Hesselbarth
2013-12-13 9:20 ` Sebastian Hesselbarth
2013-12-13 9:20 ` Sebastian Hesselbarth
2013-12-13 9:20 ` [PATCH v2 5/5] net: phy: suspend phydev when going to HALTED Sebastian Hesselbarth
2013-12-13 9:20 ` Sebastian Hesselbarth
2013-12-04 15:44 ` [PATCH RFCv2 1/6] net: mv643xx_eth: properly start/stop phy device Sebastian Hesselbarth
2013-12-04 15:44 ` Sebastian Hesselbarth
2013-12-04 15:44 ` [PATCH RFCv2 2/6] net: phy: marvell: provide genphy suspend/resume Sebastian Hesselbarth
2013-12-04 15:44 ` Sebastian Hesselbarth
2013-12-04 15:44 ` [PATCH RFCv2 3/6] net: phy: provide phy_resume/phy_suspend helpers Sebastian Hesselbarth
2013-12-04 15:44 ` Sebastian Hesselbarth
2013-12-04 15:44 ` Sebastian Hesselbarth
2013-12-06 0:08 ` Florian Fainelli
2013-12-06 0:08 ` Florian Fainelli
2013-12-04 15:44 ` [PATCH RFCv2 4/6] net: phy: resume/suspend PHYs on attach/detach Sebastian Hesselbarth
2013-12-04 15:44 ` Sebastian Hesselbarth
2013-12-04 15:44 ` [PATCH RFCv2 5/6] net: phy: suspend unused PHYs on mdio_bus in late_initcall Sebastian Hesselbarth
2013-12-04 15:44 ` Sebastian Hesselbarth
2013-12-04 21:05 ` Sergei Shtylyov
2013-12-04 21:05 ` Sergei Shtylyov
2013-12-06 0:02 ` Florian Fainelli
2013-12-06 0:02 ` Florian Fainelli
2013-12-04 15:44 ` [PATCH RFCv2 6/6] net: phy: suspend phydev when going to HALTED Sebastian Hesselbarth
2013-12-04 15:44 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A80EFC.8070806@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.