From: Lokesh Vutla <lokeshvutla@ti.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tony@atomide.com, bcousson@baylibre.com, paul@pwsan.com
Subject: Re: [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL
Date: Thu, 12 Dec 2013 15:40:34 +0530 [thread overview]
Message-ID: <52A98B9A.4080804@ti.com> (raw)
In-Reply-To: <1386841969-765-1-git-send-email-rnayak@ti.com>
Hi Rajendra,
On Thursday 12 December 2013 03:22 PM, Rajendra Nayak wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On DRA7 though, we seem to be missing this flag, and atleast on the DRA7 EVM
> where we use uart1 for console, boot fails with DEBUG_LL enabled.
>
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Tested on DRA7 evm using Tero's V10 clock series.
Tested-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index db32d53..18f333c 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1637,7 +1637,7 @@ static struct omap_hwmod dra7xx_uart1_hwmod = {
> .class = &dra7xx_uart_hwmod_class,
> .clkdm_name = "l4per_clkdm",
> .main_clk = "uart1_gfclk_mux",
> - .flags = HWMOD_SWSUP_SIDLE_ACT,
> + .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP2UART1_FLAGS,
> .prcm = {
> .omap4 = {
> .clkctrl_offs = DRA7XX_CM_L4PER_UART1_CLKCTRL_OFFSET,
>
WARNING: multiple messages have this Message-ID (diff)
From: lokeshvutla@ti.com (Lokesh Vutla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL
Date: Thu, 12 Dec 2013 15:40:34 +0530 [thread overview]
Message-ID: <52A98B9A.4080804@ti.com> (raw)
In-Reply-To: <1386841969-765-1-git-send-email-rnayak@ti.com>
Hi Rajendra,
On Thursday 12 December 2013 03:22 PM, Rajendra Nayak wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On DRA7 though, we seem to be missing this flag, and atleast on the DRA7 EVM
> where we use uart1 for console, boot fails with DEBUG_LL enabled.
>
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Tested on DRA7 evm using Tero's V10 clock series.
Tested-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index db32d53..18f333c 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1637,7 +1637,7 @@ static struct omap_hwmod dra7xx_uart1_hwmod = {
> .class = &dra7xx_uart_hwmod_class,
> .clkdm_name = "l4per_clkdm",
> .main_clk = "uart1_gfclk_mux",
> - .flags = HWMOD_SWSUP_SIDLE_ACT,
> + .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP2UART1_FLAGS,
> .prcm = {
> .omap4 = {
> .clkctrl_offs = DRA7XX_CM_L4PER_UART1_CLKCTRL_OFFSET,
>
next prev parent reply other threads:[~2013-12-12 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 9:52 [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL Rajendra Nayak
2013-12-12 9:52 ` Rajendra Nayak
2013-12-12 10:10 ` Lokesh Vutla [this message]
2013-12-12 10:10 ` Lokesh Vutla
2013-12-26 4:13 ` Paul Walmsley
2013-12-26 4:13 ` Paul Walmsley
2013-12-26 4:41 ` Paul Walmsley
2013-12-26 4:41 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A98B9A.4080804@ti.com \
--to=lokeshvutla@ti.com \
--cc=bcousson@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.