* [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL
@ 2013-12-12 9:52 ` Rajendra Nayak
0 siblings, 0 replies; 8+ messages in thread
From: Rajendra Nayak @ 2013-12-12 9:52 UTC (permalink / raw)
To: linux-arm-kernel
With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
On DRA7 though, we seem to be missing this flag, and atleast on the DRA7 EVM
where we use uart1 for console, boot fails with DEBUG_LL enabled.
Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index db32d53..18f333c 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -1637,7 +1637,7 @@ static struct omap_hwmod dra7xx_uart1_hwmod = {
.class = &dra7xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
.main_clk = "uart1_gfclk_mux",
- .flags = HWMOD_SWSUP_SIDLE_ACT,
+ .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP2UART1_FLAGS,
.prcm = {
.omap4 = {
.clkctrl_offs = DRA7XX_CM_L4PER_UART1_CLKCTRL_OFFSET,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL
2013-12-12 9:52 ` Rajendra Nayak
@ 2013-12-12 10:10 ` Lokesh Vutla
-1 siblings, 0 replies; 8+ messages in thread
From: Lokesh Vutla @ 2013-12-12 10:10 UTC (permalink / raw)
To: Rajendra Nayak; +Cc: linux-omap, linux-arm-kernel, tony, bcousson, paul
Hi Rajendra,
On Thursday 12 December 2013 03:22 PM, Rajendra Nayak wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On DRA7 though, we seem to be missing this flag, and atleast on the DRA7 EVM
> where we use uart1 for console, boot fails with DEBUG_LL enabled.
>
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Tested on DRA7 evm using Tero's V10 clock series.
Tested-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index db32d53..18f333c 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1637,7 +1637,7 @@ static struct omap_hwmod dra7xx_uart1_hwmod = {
> .class = &dra7xx_uart_hwmod_class,
> .clkdm_name = "l4per_clkdm",
> .main_clk = "uart1_gfclk_mux",
> - .flags = HWMOD_SWSUP_SIDLE_ACT,
> + .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP2UART1_FLAGS,
> .prcm = {
> .omap4 = {
> .clkctrl_offs = DRA7XX_CM_L4PER_UART1_CLKCTRL_OFFSET,
>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL
@ 2013-12-12 10:10 ` Lokesh Vutla
0 siblings, 0 replies; 8+ messages in thread
From: Lokesh Vutla @ 2013-12-12 10:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi Rajendra,
On Thursday 12 December 2013 03:22 PM, Rajendra Nayak wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On DRA7 though, we seem to be missing this flag, and atleast on the DRA7 EVM
> where we use uart1 for console, boot fails with DEBUG_LL enabled.
>
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Tested on DRA7 evm using Tero's V10 clock series.
Tested-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index db32d53..18f333c 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1637,7 +1637,7 @@ static struct omap_hwmod dra7xx_uart1_hwmod = {
> .class = &dra7xx_uart_hwmod_class,
> .clkdm_name = "l4per_clkdm",
> .main_clk = "uart1_gfclk_mux",
> - .flags = HWMOD_SWSUP_SIDLE_ACT,
> + .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP2UART1_FLAGS,
> .prcm = {
> .omap4 = {
> .clkctrl_offs = DRA7XX_CM_L4PER_UART1_CLKCTRL_OFFSET,
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL
2013-12-12 9:52 ` Rajendra Nayak
@ 2013-12-26 4:13 ` Paul Walmsley
-1 siblings, 0 replies; 8+ messages in thread
From: Paul Walmsley @ 2013-12-26 4:13 UTC (permalink / raw)
To: Rajendra Nayak; +Cc: linux-omap, linux-arm-kernel, tony, bcousson, lokeshvutla
On Thu, 12 Dec 2013, Rajendra Nayak wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On DRA7 though, we seem to be missing this flag, and atleast on the DRA7 EVM
> where we use uart1 for console, boot fails with DEBUG_LL enabled.
>
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Thanks, queued with Lokesh's Tested-by.
- Paul
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL
@ 2013-12-26 4:13 ` Paul Walmsley
0 siblings, 0 replies; 8+ messages in thread
From: Paul Walmsley @ 2013-12-26 4:13 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 12 Dec 2013, Rajendra Nayak wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On DRA7 though, we seem to be missing this flag, and atleast on the DRA7 EVM
> where we use uart1 for console, boot fails with DEBUG_LL enabled.
>
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Thanks, queued with Lokesh's Tested-by.
- Paul
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL
2013-12-12 9:52 ` Rajendra Nayak
@ 2013-12-26 4:41 ` Paul Walmsley
-1 siblings, 0 replies; 8+ messages in thread
From: Paul Walmsley @ 2013-12-26 4:41 UTC (permalink / raw)
To: Rajendra Nayak; +Cc: linux-omap, linux-arm-kernel, tony, bcousson, lokeshvutla
On Thu, 12 Dec 2013, Rajendra Nayak wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On DRA7 though, we seem to be missing this flag, and atleast on the DRA7 EVM
> where we use uart1 for console, boot fails with DEBUG_LL enabled.
>
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
By the way, for future patches that fix previous commits, please put
"Fixes:" lines along with your signoffs, and Cc: lines for the original
patch authors (if they're not you). I've added the following line in this
case:
Fixes: 7dedd346941d ("ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with DEBUG_LL")
regards,
- Paul
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] ARM: DRA7: hwmod: Fix boot crash with DEBUG_LL
@ 2013-12-26 4:41 ` Paul Walmsley
0 siblings, 0 replies; 8+ messages in thread
From: Paul Walmsley @ 2013-12-26 4:41 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 12 Dec 2013, Rajendra Nayak wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On DRA7 though, we seem to be missing this flag, and atleast on the DRA7 EVM
> where we use uart1 for console, boot fails with DEBUG_LL enabled.
>
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
By the way, for future patches that fix previous commits, please put
"Fixes:" lines along with your signoffs, and Cc: lines for the original
patch authors (if they're not you). I've added the following line in this
case:
Fixes: 7dedd346941d ("ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with DEBUG_LL")
regards,
- Paul
^ permalink raw reply [flat|nested] 8+ messages in thread