All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
	Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] cgroup: fix fail path in cgroup_load_subsys()
Date: Thu, 12 Dec 2013 22:51:45 +0400	[thread overview]
Message-ID: <52AA05C1.1070709@parallels.com> (raw)
In-Reply-To: <20131212184506.GK32683-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>

On 12/12/2013 10:45 PM, Tejun Heo wrote:
> Hello,
>
> On Thu, Dec 12, 2013 at 10:37:32PM +0400, Vladimir Davydov wrote:
>> If so, I don't mind, but why? cgroup_unload_subsys() should never be
>> called without properly initialized css.
> Hmm.... I think it's generally preferable to reuse normal exit path
> for error handling as much as possible.  Plus, the normal cgroup init
> failure path behaves that way.  That said, it's more of a preference
> and if you have technical argument, I'd be happy to give in. :)

Got it, will do.

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Davydov <vdavydov@parallels.com>
To: Tejun Heo <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
	<devel@openvz.org>, Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH] cgroup: fix fail path in cgroup_load_subsys()
Date: Thu, 12 Dec 2013 22:51:45 +0400	[thread overview]
Message-ID: <52AA05C1.1070709@parallels.com> (raw)
In-Reply-To: <20131212184506.GK32683@htj.dyndns.org>

On 12/12/2013 10:45 PM, Tejun Heo wrote:
> Hello,
>
> On Thu, Dec 12, 2013 at 10:37:32PM +0400, Vladimir Davydov wrote:
>> If so, I don't mind, but why? cgroup_unload_subsys() should never be
>> called without properly initialized css.
> Hmm.... I think it's generally preferable to reuse normal exit path
> for error handling as much as possible.  Plus, the normal cgroup init
> failure path behaves that way.  That said, it's more of a preference
> and if you have technical argument, I'd be happy to give in. :)

Got it, will do.

Thanks.

  parent reply	other threads:[~2013-12-12 18:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-07  7:58 [PATCH] cgroup: fix fail path in cgroup_load_subsys() Vladimir Davydov
2013-12-07  7:58 ` Vladimir Davydov
     [not found] ` <1386403085-24866-1-git-send-email-vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-12-12  6:01   ` Li Zefan
2013-12-12  6:01     ` Li Zefan
2013-12-12 15:35   ` Tejun Heo
2013-12-12 15:35     ` Tejun Heo
     [not found]     ` <20131212153536.GD32683-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-12-12 15:55       ` Tejun Heo
2013-12-12 15:55         ` Tejun Heo
     [not found]         ` <20131212155523.GF32683-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-12-12 18:37           ` Vladimir Davydov
2013-12-12 18:37             ` Vladimir Davydov
     [not found]             ` <52AA026C.3040605-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-12-12 18:45               ` Tejun Heo
2013-12-12 18:45                 ` Tejun Heo
     [not found]                 ` <20131212184506.GK32683-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-12-12 18:51                   ` Vladimir Davydov [this message]
2013-12-12 18:51                     ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AA05C1.1070709@parallels.com \
    --to=vdavydov-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.