All of lore.kernel.org
 help / color / mirror / Atom feed
From: dinh.linux@gmail.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/9] usb: gadget: s3c-hsotg: enable build for other platforms
Date: Thu, 12 Dec 2013 15:51:31 -0600	[thread overview]
Message-ID: <52AA2FE3.3060200@gmail.com> (raw)
In-Reply-To: <1386854770-2173-4-git-send-email-mporter@linaro.org>

Hi Matt,

On 12/12/13 7:26 AM, Matt Porter wrote:
> Remove unused Samsung-specific machine include and Kconfig
> dependency on S3C.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> ---
>  drivers/usb/gadget/Kconfig     | 7 +++----
>  drivers/usb/gadget/s3c-hsotg.c | 2 --
>  2 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index a91e642..970bd1a 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -294,11 +294,10 @@ config USB_PXA27X
>  	   gadget drivers to also be dynamically linked.
>  
>  config USB_S3C_HSOTG
> -	tristate "S3C HS/OtG USB Device controller"
> -	depends on S3C_DEV_USB_HSOTG
> +	tristate "Designware/S3C HS/OtG USB Device controller"
>  	help
> -	  The Samsung S3C64XX USB2.0 high-speed gadget controller
> -	  integrated into the S3C64XX series SoC.
> +	  The Designware USB2.0 high-speed gadget controller
> +	  integrated into the S3C64XX and BCM281xx series SoC.
Thanks for doing this. The SOCFPGA platform is also using this driver.
So perhaps a
more generic message here?

Dinh
>  
>  config USB_S3C2410
>  	tristate "S3C2410 USB Device Controller"
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 33eb690..8ceb5ef 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -37,8 +37,6 @@
>  #include <linux/usb/phy.h>
>  #include <linux/platform_data/s3c-hsotg.h>
>  
> -#include <mach/map.h>
> -
>  #include "s3c-hsotg.h"
>  
>  static const char * const s3c_hsotg_supply_names[] = {

WARNING: multiple messages have this Message-ID (diff)
From: Dinh Nguyen <dinh.linux@gmail.com>
To: Matt Porter <mporter@linaro.org>, Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Kumar Gala <galak@codeaurora.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Christian Daudt <bcm@fixthebug.org>,
	Paul Zimmerman <paulz@synopsys.com>
Cc: Devicetree List <devicetree@vger.kernel.org>,
	Kamil Debski <k.debski@samsung.com>,
	Russell King <linux@arm.linux.org.uk>,
	Linaro Patches <patches@linaro.org>,
	Tomasz Figa <t.figa@samsung.com>,
	Linux USB List <linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 3/9] usb: gadget: s3c-hsotg: enable build for other platforms
Date: Thu, 12 Dec 2013 15:51:31 -0600	[thread overview]
Message-ID: <52AA2FE3.3060200@gmail.com> (raw)
In-Reply-To: <1386854770-2173-4-git-send-email-mporter@linaro.org>

Hi Matt,

On 12/12/13 7:26 AM, Matt Porter wrote:
> Remove unused Samsung-specific machine include and Kconfig
> dependency on S3C.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> ---
>  drivers/usb/gadget/Kconfig     | 7 +++----
>  drivers/usb/gadget/s3c-hsotg.c | 2 --
>  2 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index a91e642..970bd1a 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -294,11 +294,10 @@ config USB_PXA27X
>  	   gadget drivers to also be dynamically linked.
>  
>  config USB_S3C_HSOTG
> -	tristate "S3C HS/OtG USB Device controller"
> -	depends on S3C_DEV_USB_HSOTG
> +	tristate "Designware/S3C HS/OtG USB Device controller"
>  	help
> -	  The Samsung S3C64XX USB2.0 high-speed gadget controller
> -	  integrated into the S3C64XX series SoC.
> +	  The Designware USB2.0 high-speed gadget controller
> +	  integrated into the S3C64XX and BCM281xx series SoC.
Thanks for doing this. The SOCFPGA platform is also using this driver.
So perhaps a
more generic message here?

Dinh
>  
>  config USB_S3C2410
>  	tristate "S3C2410 USB Device Controller"
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 33eb690..8ceb5ef 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -37,8 +37,6 @@
>  #include <linux/usb/phy.h>
>  #include <linux/platform_data/s3c-hsotg.h>
>  
> -#include <mach/map.h>
> -
>  #include "s3c-hsotg.h"
>  
>  static const char * const s3c_hsotg_supply_names[] = {

  reply	other threads:[~2013-12-12 21:51 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12 13:26 [PATCH v5 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 13:26 ` [PATCH v5 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 18:18   ` Felipe Balbi
2013-12-12 18:18     ` Felipe Balbi
2013-12-12 18:18     ` Felipe Balbi
2013-12-13  9:55     ` Kishon Vijay Abraham I
2013-12-13  9:55       ` Kishon Vijay Abraham I
2013-12-13  9:55       ` Kishon Vijay Abraham I
2013-12-12 13:26 ` [PATCH v5 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 18:19   ` Felipe Balbi
2013-12-12 18:19     ` Felipe Balbi
2013-12-12 18:19     ` Felipe Balbi
2013-12-12 13:26 ` [PATCH v5 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 21:51   ` Dinh Nguyen [this message]
2013-12-12 21:51     ` Dinh Nguyen
2013-12-12 22:07     ` Matt Porter
2013-12-12 22:07       ` Matt Porter
2013-12-12 22:07       ` Matt Porter
2013-12-13  0:05       ` Dinh Nguyen
2013-12-13  0:05         ` Dinh Nguyen
2013-12-13  0:05         ` Dinh Nguyen
2013-12-12 13:26 ` [PATCH v5 4/9] usb: gadget: s3c-hsotg: add snps, dwc2 compatible string Matt Porter
2013-12-12 13:26   ` [PATCH v5 4/9] usb: gadget: s3c-hsotg: add snps,dwc2 " Matt Porter
2013-12-12 13:26 ` [PATCH v5 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-13 11:00   ` Kishon Vijay Abraham I
2013-12-13 11:00     ` Kishon Vijay Abraham I
2013-12-13 11:00     ` Kishon Vijay Abraham I
2013-12-12 13:26 ` [PATCH v5 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-13 11:02   ` Kishon Vijay Abraham I
2013-12-13 11:02     ` Kishon Vijay Abraham I
2013-12-13 11:02     ` Kishon Vijay Abraham I
2013-12-12 13:26 ` [PATCH v5 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 13:26 ` [PATCH v5 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 13:26   ` Matt Porter
2013-12-12 13:26 ` [PATCH v5 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
2013-12-12 13:26   ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AA2FE3.3060200@gmail.com \
    --to=dinh.linux@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.