From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support
Date: Fri, 13 Dec 2013 16:30:46 +0530 [thread overview]
Message-ID: <52AAE8DE.2030801@ti.com> (raw)
In-Reply-To: <1386854770-2173-6-git-send-email-mporter@linaro.org>
On Thursday 12 December 2013 06:56 PM, Matt Porter wrote:
> If a generic phy is present, call phy_init()/phy_exit(). This supports
> generic phys that must be soft reset before power on.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/usb/gadget/s3c-hsotg.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 7c5d8bd..e9683c2 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -3621,6 +3621,9 @@ static int s3c_hsotg_probe(struct platform_device *pdev)
> goto err_supplies;
> }
>
> + if (hsotg->phy)
> + phy_init(hsotg->phy);
> +
> /* usb phy enable */
> s3c_hsotg_phy_enable(hsotg);
>
> @@ -3714,6 +3717,8 @@ static int s3c_hsotg_remove(struct platform_device *pdev)
> }
>
> s3c_hsotg_phy_disable(hsotg);
> + if (hsotg->phy)
> + phy_exit(hsotg->phy);
> clk_disable_unprepare(hsotg->clk);
>
> return 0;
>
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Matt Porter <mporter@linaro.org>, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Christian Daudt <bcm@fixthebug.org>,
Paul Zimmerman <paulz@synopsys.com>
Cc: Devicetree List <devicetree@vger.kernel.org>,
Kamil Debski <k.debski@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Linaro Patches <patches@linaro.org>,
Tomasz Figa <t.figa@samsung.com>,
Linux USB List <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support
Date: Fri, 13 Dec 2013 16:30:46 +0530 [thread overview]
Message-ID: <52AAE8DE.2030801@ti.com> (raw)
In-Reply-To: <1386854770-2173-6-git-send-email-mporter@linaro.org>
On Thursday 12 December 2013 06:56 PM, Matt Porter wrote:
> If a generic phy is present, call phy_init()/phy_exit(). This supports
> generic phys that must be soft reset before power on.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/usb/gadget/s3c-hsotg.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 7c5d8bd..e9683c2 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -3621,6 +3621,9 @@ static int s3c_hsotg_probe(struct platform_device *pdev)
> goto err_supplies;
> }
>
> + if (hsotg->phy)
> + phy_init(hsotg->phy);
> +
> /* usb phy enable */
> s3c_hsotg_phy_enable(hsotg);
>
> @@ -3714,6 +3717,8 @@ static int s3c_hsotg_remove(struct platform_device *pdev)
> }
>
> s3c_hsotg_phy_disable(hsotg);
> + if (hsotg->phy)
> + phy_exit(hsotg->phy);
> clk_disable_unprepare(hsotg->clk);
>
> return 0;
>
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Matt Porter <mporter@linaro.org>, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Christian Daudt <bcm@fixthebug.org>,
Paul Zimmerman <paulz@synopsys.com>
Cc: Tomasz Figa <t.figa@samsung.com>,
Kamil Debski <k.debski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Linux USB List <linux-usb@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linaro Patches <patches@linaro.org>
Subject: Re: [PATCH v5 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support
Date: Fri, 13 Dec 2013 16:30:46 +0530 [thread overview]
Message-ID: <52AAE8DE.2030801@ti.com> (raw)
In-Reply-To: <1386854770-2173-6-git-send-email-mporter@linaro.org>
On Thursday 12 December 2013 06:56 PM, Matt Porter wrote:
> If a generic phy is present, call phy_init()/phy_exit(). This supports
> generic phys that must be soft reset before power on.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/usb/gadget/s3c-hsotg.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 7c5d8bd..e9683c2 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -3621,6 +3621,9 @@ static int s3c_hsotg_probe(struct platform_device *pdev)
> goto err_supplies;
> }
>
> + if (hsotg->phy)
> + phy_init(hsotg->phy);
> +
> /* usb phy enable */
> s3c_hsotg_phy_enable(hsotg);
>
> @@ -3714,6 +3717,8 @@ static int s3c_hsotg_remove(struct platform_device *pdev)
> }
>
> s3c_hsotg_phy_disable(hsotg);
> + if (hsotg->phy)
> + phy_exit(hsotg->phy);
> clk_disable_unprepare(hsotg->clk);
>
> return 0;
>
next prev parent reply other threads:[~2013-12-13 11:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 13:26 [PATCH v5 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 13:26 ` [PATCH v5 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 18:18 ` Felipe Balbi
2013-12-12 18:18 ` Felipe Balbi
2013-12-12 18:18 ` Felipe Balbi
2013-12-13 9:55 ` Kishon Vijay Abraham I
2013-12-13 9:55 ` Kishon Vijay Abraham I
2013-12-13 9:55 ` Kishon Vijay Abraham I
2013-12-12 13:26 ` [PATCH v5 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 18:19 ` Felipe Balbi
2013-12-12 18:19 ` Felipe Balbi
2013-12-12 18:19 ` Felipe Balbi
2013-12-12 13:26 ` [PATCH v5 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 21:51 ` Dinh Nguyen
2013-12-12 21:51 ` Dinh Nguyen
2013-12-12 22:07 ` Matt Porter
2013-12-12 22:07 ` Matt Porter
2013-12-12 22:07 ` Matt Porter
2013-12-13 0:05 ` Dinh Nguyen
2013-12-13 0:05 ` Dinh Nguyen
2013-12-13 0:05 ` Dinh Nguyen
2013-12-12 13:26 ` [PATCH v5 4/9] usb: gadget: s3c-hsotg: add snps, dwc2 compatible string Matt Porter
2013-12-12 13:26 ` [PATCH v5 4/9] usb: gadget: s3c-hsotg: add snps,dwc2 " Matt Porter
2013-12-12 13:26 ` [PATCH v5 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-13 11:00 ` Kishon Vijay Abraham I [this message]
2013-12-13 11:00 ` Kishon Vijay Abraham I
2013-12-13 11:00 ` Kishon Vijay Abraham I
2013-12-12 13:26 ` [PATCH v5 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-13 11:02 ` Kishon Vijay Abraham I
2013-12-13 11:02 ` Kishon Vijay Abraham I
2013-12-13 11:02 ` Kishon Vijay Abraham I
2013-12-12 13:26 ` [PATCH v5 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 13:26 ` [PATCH v5 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 13:26 ` Matt Porter
2013-12-12 13:26 ` [PATCH v5 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
2013-12-12 13:26 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AAE8DE.2030801@ti.com \
--to=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.