From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Philip Wernersbach <philip.wernersbach@gmail.com>
Cc: Ian.Campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.
Date: Tue, 17 Dec 2013 19:27:47 +0000 [thread overview]
Message-ID: <52B0A5B3.6090903@citrix.com> (raw)
In-Reply-To: <CAO5Rg13ezpV=99pPA2jJ8T7TsDsxAD6HuATOcZgXd0mGKehwsQ@mail.gmail.com>
On 17/12/13 19:09, Philip Wernersbach wrote:
> I can't post patches inline because my mail client corrupts the
> patches with extra white space. The linked patch should meet all
> requirements listed in Submitting_Xen_Patches.
>
> Thanks,
> Philip Wernersbach
In which case I shall do a cursory review right now.
You have used tabs not spaces. This needs fixing, and will likely fix
the alignment issues
"static acpi_physical_address __initdata global_rsdp_address;" should
not be static. As the patch currently stands you have two static
variables with same name.
"static char __initdata global_rsdp_address_string" again shouldn't be
static
acpi_os_get_root_pointer() already a global function which does what you
want. No need to edit drivers/acpi/tables at all.
~Andrew
next prev parent reply other threads:[~2013-12-17 19:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 19:09 [PATCH] xen: Pass the location of the ACPI RSDP to DOM0 Philip Wernersbach
2013-12-17 19:18 ` Ian Campbell
2013-12-17 20:51 ` Philip Wernersbach
2013-12-17 19:27 ` Andrew Cooper [this message]
2013-12-17 20:48 ` Philip Wernersbach
-- strict thread matches above, loose matches on Subject: below --
2013-12-17 0:22 Philip Wernersbach
2013-12-17 0:24 ` Philip Wernersbach
2013-12-17 10:02 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B0A5B3.6090903@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=philip.wernersbach@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.