Re: [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

Re: [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

[Philip Wernersbach]

I can't post patches inline because my mail client corrupts the
patches with extra white space. The linked patch should meet all
requirements listed in Submitting_Xen_Patches.

Thanks,
Philip Wernersbach


On Tue, Dec 17, 2013 at 5:02 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>
> On Mon, 2013-12-16 at 19:24 -0500, Philip Wernersbach wrote:
> > Oops! The correct link to the patch is
> > http://gist.github.com/philip-wernersbach/7997637.
>
> Please see http://wiki.xen.org/wiki/Submitting_Xen_Patches for advice on
> how to submit a patch.
>
> >
> > On Mon, Dec 16, 2013 at 7:22 PM, Philip Wernersbach
> > <philip.wernersbach@gmail.com> wrote:
> > > Hello Everyone,
> > >
> > > I recently ran into a problem deploying Xen on a new IBM server. The
> > > problem was that DOM0 couldn't find the ACPI RSDP, since newer IBM
> > > servers only allow access to that information through EFI. Since Xen
> > > nukes DOM0's access to EFI, DOM0 couldn't find this information, and
> > > so it proceeded with degraded functionality.
> > >
> > > I made a patch to correct this, and uploaded it to
> > > http://gist.github.com/philip-wernersbach/6473042, in hopes that I can
> > > get this patch included into mainline Xen.
> > >
> > > Sincerely,
> > > Philip Wernersbach
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
>
>

Re: [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

[Ian Campbell]

(please don't top-post)
On Tue, 2013-12-17 at 14:09 -0500, Philip Wernersbach wrote:
> I can't post patches inline because my mail client corrupts the
> patches with extra white space. The linked patch should meet all
> requirements listed in Submitting_Xen_Patches.

Then please send it inline for review and attached for an uncorrupted
copy for application.

Please try and use whatever "preformatted" or "unformatted" etc option
you can find in your client for the inline version.

Ian.

Re: [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

[Philip Wernersbach]

On Tue, Dec 17, 2013 at 2:18 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> Then please send it inline for review and attached for an uncorrupted
> copy for application.
>
> Please try and use whatever "preformatted" or "unformatted" etc option
> you can find in your client for the inline version.

When I redo the patch I'll try to get my client to behave.

Re: [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

[Andrew Cooper]

On 17/12/13 19:09, Philip Wernersbach wrote:
> I can't post patches inline because my mail client corrupts the
> patches with extra white space. The linked patch should meet all
> requirements listed in Submitting_Xen_Patches.
>
> Thanks,
> Philip Wernersbach

In which case I shall do a cursory review right now.

You have used tabs not spaces.  This needs fixing, and will likely fix
the alignment issues

"static acpi_physical_address __initdata global_rsdp_address;" should
not be static.  As the patch currently stands you have two static
variables with same name.

"static char __initdata global_rsdp_address_string" again shouldn't be
static

acpi_os_get_root_pointer() already a global function which does what you
want.  No need to edit drivers/acpi/tables at all.

~Andrew

Re: [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

[Philip Wernersbach]

On Tue, Dec 17, 2013 at 2:27 PM, Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
> acpi_os_get_root_pointer() already a global function which does what you
> want.  No need to edit drivers/acpi/tables at all.

I'll redo the patch to use this function and repost.

[PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

[Philip Wernersbach]

Hello Everyone,

I recently ran into a problem deploying Xen on a new IBM server. The
problem was that DOM0 couldn't find the ACPI RSDP, since newer IBM
servers only allow access to that information through EFI. Since Xen
nukes DOM0's access to EFI, DOM0 couldn't find this information, and
so it proceeded with degraded functionality.

I made a patch to correct this, and uploaded it to
http://gist.github.com/philip-wernersbach/6473042, in hopes that I can
get this patch included into mainline Xen.

Sincerely,
Philip Wernersbach

Re: [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

[Philip Wernersbach]

Oops! The correct link to the patch is
http://gist.github.com/philip-wernersbach/7997637.

On Mon, Dec 16, 2013 at 7:22 PM, Philip Wernersbach
<philip.wernersbach@gmail.com> wrote:
> Hello Everyone,
>
> I recently ran into a problem deploying Xen on a new IBM server. The
> problem was that DOM0 couldn't find the ACPI RSDP, since newer IBM
> servers only allow access to that information through EFI. Since Xen
> nukes DOM0's access to EFI, DOM0 couldn't find this information, and
> so it proceeded with degraded functionality.
>
> I made a patch to correct this, and uploaded it to
> http://gist.github.com/philip-wernersbach/6473042, in hopes that I can
> get this patch included into mainline Xen.
>
> Sincerely,
> Philip Wernersbach

Re: [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

[Ian Campbell]

On Mon, 2013-12-16 at 19:24 -0500, Philip Wernersbach wrote:
> Oops! The correct link to the patch is
> http://gist.github.com/philip-wernersbach/7997637.

Please see http://wiki.xen.org/wiki/Submitting_Xen_Patches for advice on
how to submit a patch.

> 
> On Mon, Dec 16, 2013 at 7:22 PM, Philip Wernersbach
> <philip.wernersbach@gmail.com> wrote:
> > Hello Everyone,
> >
> > I recently ran into a problem deploying Xen on a new IBM server. The
> > problem was that DOM0 couldn't find the ACPI RSDP, since newer IBM
> > servers only allow access to that information through EFI. Since Xen
> > nukes DOM0's access to EFI, DOM0 couldn't find this information, and
> > so it proceeded with degraded functionality.
> >
> > I made a patch to correct this, and uploaded it to
> > http://gist.github.com/philip-wernersbach/6473042, in hopes that I can
> > get this patch included into mainline Xen.
> >
> > Sincerely,
> > Philip Wernersbach
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel