From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: jaegeuk.kim@samsung.com
Cc: 'fsdevel' <linux-fsdevel@vger.kernel.org>,
'linux-kernel' <linux-kernel@vger.kernel.org>,
'f2fs' <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [PATCH] f2fs: move all the bio initialization into __bio_alloc
Date: Thu, 19 Dec 2013 17:22:18 +0800 [thread overview]
Message-ID: <52B2BACA.80600@cn.fujitsu.com> (raw)
In-Reply-To: <1387443585.2101.216.camel@kjgkr>
Hi Kim, Yu,
Thanks for your review!
On 12/19/2013 04:59 PM, Jaegeuk Kim wrote:
> Hi Gu,
>
> I agreed with Chao.
> It is more readable to use something like "is_read" instead of "rw".
Agree. I'll follow it.
Regards,
Gu
> Thanks,
>
> 2013-12-19 (목), 09:23 +0800, Chao Yu:
>> Hi Gu,
>>
>>> -----Original Message-----
>>> From: Gu Zheng [mailto:guz.fnst@cn.fujitsu.com]
>>> Sent: Wednesday, December 18, 2013 6:29 PM
>>> To: Kim
>>> Cc: fsdevel; linux-kernel; f2fs
>>> Subject: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc
>>>
>>> Move all the bio initialization into __bio_alloc, and some minor cleanups are
>>> also added.
>>
>> Looks more neat!
>>
>>> @@ -178,17 +179,16 @@ void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct page *page,
>>> block_t blk_addr, struct f2fs_io_info *fio)
>>> {
>>> enum page_type btype = PAGE_TYPE_OF_BIO(fio->type);
>>> - struct block_device *bdev = sbi->sb->s_bdev;
>>> struct f2fs_bio_info *io;
>>> - int bio_blocks;
>>> + int rw = is_read_io(fio->rw);
>>
>> Maybe it's more neat to use 'is_read' to instead of 'rw'.
>>
>> Thanks
>>
>
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: jaegeuk.kim@samsung.com
Cc: Chao Yu <chao2.yu@samsung.com>,
"'fsdevel'" <linux-fsdevel@vger.kernel.org>,
"'linux-kernel'" <linux-kernel@vger.kernel.org>,
"'f2fs'" <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc
Date: Thu, 19 Dec 2013 17:22:18 +0800 [thread overview]
Message-ID: <52B2BACA.80600@cn.fujitsu.com> (raw)
In-Reply-To: <1387443585.2101.216.camel@kjgkr>
Hi Kim, Yu,
Thanks for your review!
On 12/19/2013 04:59 PM, Jaegeuk Kim wrote:
> Hi Gu,
>
> I agreed with Chao.
> It is more readable to use something like "is_read" instead of "rw".
Agree. I'll follow it.
Regards,
Gu
> Thanks,
>
> 2013-12-19 (목), 09:23 +0800, Chao Yu:
>> Hi Gu,
>>
>>> -----Original Message-----
>>> From: Gu Zheng [mailto:guz.fnst@cn.fujitsu.com]
>>> Sent: Wednesday, December 18, 2013 6:29 PM
>>> To: Kim
>>> Cc: fsdevel; linux-kernel; f2fs
>>> Subject: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc
>>>
>>> Move all the bio initialization into __bio_alloc, and some minor cleanups are
>>> also added.
>>
>> Looks more neat!
>>
>>> @@ -178,17 +179,16 @@ void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct page *page,
>>> block_t blk_addr, struct f2fs_io_info *fio)
>>> {
>>> enum page_type btype = PAGE_TYPE_OF_BIO(fio->type);
>>> - struct block_device *bdev = sbi->sb->s_bdev;
>>> struct f2fs_bio_info *io;
>>> - int bio_blocks;
>>> + int rw = is_read_io(fio->rw);
>>
>> Maybe it's more neat to use 'is_read' to instead of 'rw'.
>>
>> Thanks
>>
>
next prev parent reply other threads:[~2013-12-19 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 10:29 [PATCH] f2fs: move all the bio initialization into __bio_alloc Gu Zheng
2013-12-18 10:29 ` [f2fs-dev][PATCH] " Gu Zheng
2013-12-19 1:23 ` [PATCH] " Chao Yu
2013-12-19 1:23 ` [f2fs-dev] " Chao Yu
2013-12-19 8:59 ` Jaegeuk Kim
2013-12-19 8:59 ` [f2fs-dev] " Jaegeuk Kim
2013-12-19 9:22 ` Gu Zheng [this message]
2013-12-19 9:22 ` Gu Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B2BACA.80600@cn.fujitsu.com \
--to=guz.fnst@cn.fujitsu.com \
--cc=jaegeuk.kim@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.