All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Tero Kristo <t-kristo@ti.com>,
	linux-omap@vger.kernel.org, paul@pwsan.com, tony@atomide.com,
	rnayak@ti.com, bcousson@baylibre.com, mturquette@linaro.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv11 00/49] ARM: TI SoC clock DT conversion
Date: Thu, 19 Dec 2013 09:07:20 -0600	[thread overview]
Message-ID: <52B30BA8.2060108@ti.com> (raw)
In-Reply-To: <1387452260-23276-1-git-send-email-t-kristo@ti.com>

On 12/19/2013 05:23 AM, Tero Kristo wrote:
[...]
>
> branch: 3.13-rc4-dt-clks-v11 : contains everything, shall me merged last


Tero,
Considering Pauls'  concerns with v10 last time, I ran
[1] and got a few sparse, smatch and checkpatch warnings:
http://pastebin.mozilla.org/3810314

I think we can ignore sparse spam about "__ksymtab" for the moment.
but stuff like:
+drivers/clk/ti/clk.c:88 ti_clk_retry_init() error: potential null 
dereference 'retry'.  (kzalloc returns null)

the checkpatch warn that Paul stated:"extern struct of_device_id 
__clk_of_table" still remain should be fixed IMHO.

I am unfortunately on vacation right now, and will not be able to test 
until second week of jan on platforms - thanks to my completely messed 
up vpn setup.

[1] https://github.com/nmenon/kernel_patch_verify

Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv11 00/49] ARM: TI SoC clock DT conversion
Date: Thu, 19 Dec 2013 09:07:20 -0600	[thread overview]
Message-ID: <52B30BA8.2060108@ti.com> (raw)
In-Reply-To: <1387452260-23276-1-git-send-email-t-kristo@ti.com>

On 12/19/2013 05:23 AM, Tero Kristo wrote:
[...]
>
> branch: 3.13-rc4-dt-clks-v11 : contains everything, shall me merged last


Tero,
Considering Pauls'  concerns with v10 last time, I ran
[1] and got a few sparse, smatch and checkpatch warnings:
http://pastebin.mozilla.org/3810314

I think we can ignore sparse spam about "__ksymtab" for the moment.
but stuff like:
+drivers/clk/ti/clk.c:88 ti_clk_retry_init() error: potential null 
dereference 'retry'.  (kzalloc returns null)

the checkpatch warn that Paul stated:"extern struct of_device_id 
__clk_of_table" still remain should be fixed IMHO.

I am unfortunately on vacation right now, and will not be able to test 
until second week of jan on platforms - thanks to my completely messed 
up vpn setup.

[1] https://github.com/nmenon/kernel_patch_verify

Regards,
Nishanth Menon

  parent reply	other threads:[~2013-12-19 15:07 UTC|newest]

Thread overview: 142+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 11:23 [PATCHv11 00/49] ARM: TI SoC clock DT conversion Tero Kristo
2013-12-19 11:23 ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 01/49] clk: add support for registering clocks from description Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-20 10:53   ` Paul Walmsley
2013-12-20 10:53     ` Paul Walmsley
2013-12-20 13:14     ` Tero Kristo
2013-12-20 13:14       ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 03/49] clk: divider: add support for registering divider clock from descriptor Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-20 10:54   ` Paul Walmsley
2013-12-20 10:54     ` Paul Walmsley
2013-12-19 11:23 ` [PATCHv11 04/49] clk: mux: add support for registering mux " Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-20 10:55   ` Paul Walmsley
2013-12-20 10:55     ` Paul Walmsley
2013-12-19 11:23 ` [PATCHv11 05/49] clk: gate: add support for registering gate " Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-20 10:56   ` Paul Walmsley
2013-12-20 10:56     ` Paul Walmsley
2013-12-19 11:23 ` [PATCHv11 06/49] clk: add support for low level register ops Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-20 11:00   ` Paul Walmsley
2013-12-20 11:00     ` Paul Walmsley
2013-12-20 11:17     ` Tero Kristo
2013-12-20 11:17       ` Tero Kristo
2013-12-20 16:09       ` Paul Walmsley
2013-12-20 16:09         ` Paul Walmsley
2013-12-19 11:23 ` [PATCHv11 07/49] clk: divider: add support for low level ops Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 18:26   ` Tony Lindgren
2013-12-19 18:26     ` Tony Lindgren
2013-12-19 19:02     ` Tero Kristo
2013-12-19 19:02       ` Tero Kristo
2013-12-20 10:07       ` Rajendra Nayak
2013-12-20 10:07         ` Rajendra Nayak
2013-12-20 10:29         ` Tero Kristo
2013-12-20 10:29           ` Tero Kristo
2013-12-20 10:39           ` Rajendra Nayak
2013-12-20 10:39             ` Rajendra Nayak
2013-12-20 16:16             ` Tony Lindgren
2013-12-20 16:16               ` Tony Lindgren
2013-12-20 16:33               ` Tero Kristo
2013-12-20 16:33                 ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 08/49] clk: gate: " Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 09/49] clk: mux: " Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 10/49] CLK: TI: add DT alias clock registration mechanism Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 11/49] CLK: ti: add init support for clock IP blocks Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 12/49] CLK: TI: Add DPLL clock support Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 13/49] CLK: TI: add autoidle support Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 14/49] clk: ti: add composite clock support Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 15/49] CLK: ti: add support for ti divider-clock Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 16/49] clk: ti: add support for TI fixed factor clock Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 17/49] CLK: TI: add support for gate clock Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 18/49] CLK: TI: add support for clockdomain binding Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-20 11:46   ` Paul Walmsley
2013-12-20 11:46     ` Paul Walmsley
2013-12-19 11:23 ` [PATCHv11 19/49] clk: ti: add support for basic mux clock Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 20/49] CLK: TI: add omap4 clock init file Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 21/49] CLK: TI: add omap5 " Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 22/49] CLK: TI: omap5: Initialize USB_DPLL at boot Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 23/49] CLK: TI: DRA7: Add APLL support Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 24/49] CLK: TI: add dra7 clock init file Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 25/49] CLK: TI: add am33xx " Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:23 ` [PATCHv11 27/49] CLK: TI: add omap3 " Tero Kristo
2013-12-19 11:23   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 30/49] ARM: dts: omap5 clock data Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 31/49] ARM: dts: dra7 " Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 32/49] ARM: dts: clk: Add apll related clocks Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 33/49] ARM: dts: DRA7: Change apll_pcie_m2_ck to fixed factor clock Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 34/49] ARM: dts: DRA7: Add PCIe related clock nodes Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 35/49] ARM: dts: am33xx clock data Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 36/49] ARM: dts: omap3 " Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 37/49] ARM: dts: AM35xx: use DT " Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 39/49] ARM: OMAP2+: clock: add support for indexed memmaps Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 40/49] ARM: OMAP2+: clock: use driver API instead of direct memory read/write Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 45/49] ARM: OMAP4: remove old clock data and link in new clock init code Tero Kristo
2013-12-19 11:24   ` Tero Kristo
     [not found] ` <1387452260-23276-1-git-send-email-t-kristo-l0cyMroinI0@public.gmane.org>
2013-12-19 11:23   ` [PATCHv11 02/49] clk: fixed-rate: add support for registering fixed-rate clock from descriptor Tero Kristo
2013-12-19 11:23     ` Tero Kristo
2013-12-19 11:23   ` [PATCHv11 26/49] CLK: TI: add interface clock support for OMAP3 Tero Kristo
2013-12-19 11:23     ` Tero Kristo
2013-12-19 11:23   ` [PATCHv11 28/49] CLK: TI: add am43xx clock init file Tero Kristo
2013-12-19 11:23     ` Tero Kristo
2013-12-19 11:24   ` [PATCHv11 29/49] ARM: dts: omap4 clock data Tero Kristo
2013-12-19 11:24     ` Tero Kristo
2013-12-19 11:24   ` [PATCHv11 38/49] ARM: dts: am43xx " Tero Kristo
2013-12-19 11:24     ` Tero Kristo
2013-12-19 11:24   ` [PATCHv11 41/49] ARM: OMAP: hwmod: fix an incorrect clk type cast with _get_clkdm Tero Kristo
2013-12-19 11:24     ` Tero Kristo
2013-12-19 11:24   ` [PATCHv11 42/49] ARM: OMAP3: hwmod: initialize clkdm from clkdm_name Tero Kristo
2013-12-19 11:24     ` Tero Kristo
2013-12-19 11:24   ` [PATCHv11 43/49] ARM: OMAP2+: PRM: add support for initializing PRCM clock modules from DT Tero Kristo
2013-12-19 11:24     ` Tero Kristo
2013-12-20 11:49     ` Paul Walmsley
2013-12-20 11:49       ` Paul Walmsley
2013-12-20 13:12       ` Tero Kristo
2013-12-20 13:12         ` Tero Kristo
2013-12-19 11:24   ` [PATCHv11 44/49] ARM: OMAP2+: io: use new clock init API Tero Kristo
2013-12-19 11:24     ` Tero Kristo
2013-12-19 11:24   ` [PATCHv11 46/49] ARM: OMAP: DRA7: Enable clock init Tero Kristo
2013-12-19 11:24     ` Tero Kristo
2013-12-19 11:24   ` [PATCHv11 47/49] ARM: AM43xx: " Tero Kristo
2013-12-19 11:24     ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 48/49] ARM: AM33xx: remove old clock data and link in new clock init code Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 11:24 ` [PATCHv11 49/49] ARM: OMAP3: use DT clock init if DT data is available Tero Kristo
2013-12-19 11:24   ` Tero Kristo
2013-12-19 15:07 ` Nishanth Menon [this message]
2013-12-19 15:07   ` [PATCHv11 00/49] ARM: TI SoC clock DT conversion Nishanth Menon
2013-12-19 18:05   ` Tony Lindgren
2013-12-19 18:05     ` Tony Lindgren
2013-12-20  6:52 ` Keerthy
2013-12-20  6:52   ` Keerthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B30BA8.2060108@ti.com \
    --to=nm@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.