All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Andrey Borzenkov <arvidjaar@gmail.com>,
	Benno Schulenberg <bensberg@justemail.net>
Subject: Re: please attempt to minimize string changes
Date: Sun, 22 Dec 2013 16:18:10 +0100	[thread overview]
Message-ID: <52B702B2.2010409@gmail.com> (raw)
In-Reply-To: <1387703902.20556.62526541.60D1FDDC@webmail.messagingengine.com>

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

On 22.12.2013 10:18, Benno Schulenberg wrote:
> 
> On Sun, Dec 22, 2013, at 5:55, Andrey Borzenkov wrote:
>> Will below patch help? It also removes trailing dot on the first
>> paragraph which was not present before.
> 
> Thanks, the patch looks good.  Except that the trailing dot needs
> to be there: it is a doc string and should end in a period.  The
> addition of the dot was an improvement.  :)
> 
@Andrey. Could you commit your patch with this suggestion?
Thanks
> The general rule is: when the string starts with a capitalized word,
> it wants to be a full sentence and should end in a period.  When the
> message starts with a lowercase letter, don't use a period anywhere
> in the message; when you need a second sentence, use a semicolon.
> 
>> I usually use [TERMINAL ...] (with extra spaces). I find it established
>> enough practice at least in UNIX manuals.
> 
> Indeed.  Although in most of the man pages I've looked at just now
> (df, ls, grep, sed, swapon, gawk), only gawk uses a space before the
> dots.  But whatever you choose, please make it consistent across
> grub -- I've seen at least one instance without a space before the
> dots in grub's messages.
> 
> Regards,
> 
> Benno
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]

  reply	other threads:[~2013-12-22 15:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.145169.1387663970.10747.bug-grub@gnu.org>
     [not found] ` <1387665282.17387.62428913.56FD8AA4@webmail.messagingengine.com>
2013-12-21 23:55   ` please attempt to minimize string changes Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-22  4:55     ` Andrey Borzenkov
2013-12-22  9:18       ` Benno Schulenberg
2013-12-22 15:18         ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-12-22 11:31       ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-22 13:24         ` Andrey Borzenkov
2013-12-22 13:37           ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-22 16:12             ` Benno Schulenberg
2013-12-22  9:28     ` Benno Schulenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B702B2.2010409@gmail.com \
    --to=phcoder@gmail.com \
    --cc=arvidjaar@gmail.com \
    --cc=bensberg@justemail.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.