From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LM Sensors <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
Corentin LABBE
<clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2 2/5] input: sun4i-ts: Add support for temperature sensor
Date: Tue, 31 Dec 2013 16:02:32 +0100 [thread overview]
Message-ID: <52C2DC88.3060902@redhat.com> (raw)
In-Reply-To: <20131231130006.GW3144@lukather>
Hi,
On 12/31/2013 02:00 PM, Maxime Ripard wrote:
> Hi,
>
> On Fri, Dec 27, 2013 at 05:13:04PM -0800, Dmitry Torokhov wrote:
>> On Fri, Dec 27, 2013 at 03:59:56PM +0100, Hans de Goede wrote:
>>>
>>> +Optional properties:
>>> + - ts-attached: boolean set this to tell the driver that an actual touchscreen
>>> + is attached and that it should register an input device,
>>> + without this it only registers the builtin temperate sensor
>>
>> I believe the guidance is to avoid describing kernel behavior in DT
>> property so I think it should say:
>>
>> - ts-attached: boolean indicating that an actual touchscreen is
>> attached to the controller.
>
> Custom properties are also supposed to be prefixed by the vendor prefix.
Will fix for v3.
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LM Sensors <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
Corentin LABBE
<clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [lm-sensors] [PATCH v2 2/5] input: sun4i-ts: Add support for temperature sensor
Date: Tue, 31 Dec 2013 15:02:32 +0000 [thread overview]
Message-ID: <52C2DC88.3060902@redhat.com> (raw)
In-Reply-To: <20131231130006.GW3144@lukather>
Hi,
On 12/31/2013 02:00 PM, Maxime Ripard wrote:
> Hi,
>
> On Fri, Dec 27, 2013 at 05:13:04PM -0800, Dmitry Torokhov wrote:
>> On Fri, Dec 27, 2013 at 03:59:56PM +0100, Hans de Goede wrote:
>>>
>>> +Optional properties:
>>> + - ts-attached: boolean set this to tell the driver that an actual touchscreen
>>> + is attached and that it should register an input device,
>>> + without this it only registers the builtin temperate sensor
>>
>> I believe the guidance is to avoid describing kernel behavior in DT
>> property so I think it should say:
>>
>> - ts-attached: boolean indicating that an actual touchscreen is
>> attached to the controller.
>
> Custom properties are also supposed to be prefixed by the vendor prefix.
Will fix for v3.
Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] input: sun4i-ts: Add support for temperature sensor
Date: Tue, 31 Dec 2013 16:02:32 +0100 [thread overview]
Message-ID: <52C2DC88.3060902@redhat.com> (raw)
In-Reply-To: <20131231130006.GW3144@lukather>
Hi,
On 12/31/2013 02:00 PM, Maxime Ripard wrote:
> Hi,
>
> On Fri, Dec 27, 2013 at 05:13:04PM -0800, Dmitry Torokhov wrote:
>> On Fri, Dec 27, 2013 at 03:59:56PM +0100, Hans de Goede wrote:
>>>
>>> +Optional properties:
>>> + - ts-attached: boolean set this to tell the driver that an actual touchscreen
>>> + is attached and that it should register an input device,
>>> + without this it only registers the builtin temperate sensor
>>
>> I believe the guidance is to avoid describing kernel behavior in DT
>> property so I think it should say:
>>
>> - ts-attached: boolean indicating that an actual touchscreen is
>> attached to the controller.
>
> Custom properties are also supposed to be prefixed by the vendor prefix.
Will fix for v3.
Regards,
Hans
next prev parent reply other threads:[~2013-12-31 15:02 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 14:59 [PATCH v2 0/5] input: Add new sun4i-ts driver for Allwinner sunxi Hans de Goede
2013-12-27 14:59 ` Hans de Goede
2013-12-27 14:59 ` [lm-sensors] " Hans de Goede
[not found] ` <1388156399-29677-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-27 14:59 ` [PATCH v2 1/5] input: Add new sun4i-ts driver for Allwinner sunxi SoC's rtp controller Hans de Goede
2013-12-27 14:59 ` Hans de Goede
2013-12-27 14:59 ` [lm-sensors] " Hans de Goede
2013-12-27 14:59 ` [PATCH v2 2/5] input: sun4i-ts: Add support for temperature sensor Hans de Goede
2013-12-27 14:59 ` Hans de Goede
2013-12-27 14:59 ` [lm-sensors] " Hans de Goede
[not found] ` <1388156399-29677-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-27 16:34 ` Guenter Roeck
2013-12-27 16:34 ` Guenter Roeck
2013-12-27 16:34 ` Guenter Roeck
[not found] ` <20131227163419.GA20135-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-12-31 10:57 ` Hans de Goede
2013-12-31 10:57 ` Hans de Goede
2013-12-31 10:57 ` Hans de Goede
2013-12-28 1:10 ` Dmitry Torokhov
2013-12-28 1:10 ` Dmitry Torokhov
2013-12-28 1:10 ` [lm-sensors] " Dmitry Torokhov
[not found] ` <20131228011007.GA14188-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2013-12-31 11:10 ` Hans de Goede
2013-12-31 11:10 ` Hans de Goede
2013-12-31 11:10 ` [lm-sensors] " Hans de Goede
2013-12-28 1:13 ` Dmitry Torokhov
2013-12-28 1:13 ` Dmitry Torokhov
2013-12-28 1:13 ` [lm-sensors] " Dmitry Torokhov
[not found] ` <20131228011304.GB14188-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2013-12-31 11:17 ` Hans de Goede
2013-12-31 11:17 ` Hans de Goede
2013-12-31 11:17 ` [lm-sensors] " Hans de Goede
2013-12-31 13:00 ` Maxime Ripard
2013-12-31 13:00 ` Maxime Ripard
2013-12-31 13:00 ` [lm-sensors] " Maxime Ripard
2013-12-31 15:02 ` Hans de Goede [this message]
2013-12-31 15:02 ` Hans de Goede
2013-12-31 15:02 ` [lm-sensors] " Hans de Goede
2013-12-27 14:59 ` [PATCH v2 3/5] ARM: dts: sun4i: Add rtp controller node Hans de Goede
2013-12-27 14:59 ` Hans de Goede
2013-12-27 14:59 ` [lm-sensors] " Hans de Goede
2013-12-27 14:59 ` [PATCH v2 4/5] ARM: dts: sun5i: " Hans de Goede
2013-12-27 14:59 ` Hans de Goede
2013-12-27 14:59 ` [lm-sensors] " Hans de Goede
2013-12-27 14:59 ` [PATCH v2 5/5] ARM: dts: sun7i: " Hans de Goede
2013-12-27 14:59 ` Hans de Goede
2013-12-27 14:59 ` [lm-sensors] " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C2DC88.3060902@redhat.com \
--to=hdegoede-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.