From: Jan Kiszka <jan.kiszka@web.de>
To: Marcelo Tosatti <mtosatti@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: nested_free_all_saved_vmcss freeing vmx->vmcs01?
Date: Fri, 03 Jan 2014 20:53:06 +0100 [thread overview]
Message-ID: <52C71522.7060802@web.de> (raw)
In-Reply-To: <20140103190217.GB16151@amt.cnet>
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
On 2014-01-03 20:02, Marcelo Tosatti wrote:
>
> Am i missing something, or should nested_free_all_saved_vmcss not
> call
>
> if (vmx->loaded_vmcs != &vmx->vmcs01)
> free_loaded_vmcs(&vmx->vmcs01);
>
> ?
This is relevant if we call nested_free_all_saved_vmcss on cleanup while
L2 was still active. In this case, the
free_loaded_vmcs(vmx->loaded_vmcs) will free the item's loaded_vmcs we
skipped earlier in that function - OK, and now I also understand your patch.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2014-01-03 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 19:02 nested_free_all_saved_vmcss freeing vmx->vmcs01? Marcelo Tosatti
2014-01-03 19:53 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C71522.7060802@web.de \
--to=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.